Does this leak?

[Shoto]

Does this trigger leak?

And if i have a unit variable, will i need to remove the variable before setting it to another value?
if yes, how do i do that?

 

[Dr Super Good]

It leaks a group.

You can not remove globals as they are allocated staticly when the script is loaded. You just allocate a variable to a new value and it will replace the old value in memory (as it links to the same storage location in memory).

 

[WaterKnight]

function CountLivingPlayerUnitsOfTypeId takes integer unitId, player whichPlayer returns integer
    local group g
    local integer matchedCount

    set g = CreateGroup()
    set bj_livingPlayerUnitsTypeId = unitId
    call GroupEnumUnitsOfPlayer(g, whichPlayer, filterLivingPlayerUnitsOfTypeId)
    set matchedCount = CountUnitsInGroup(g)
    call DestroyGroup(g)

    return matchedCount
endfunction

The group is destroyed but its id not released. Do not know anymore if the group is properly cleared via DestroyGroup to get rid of remaining references.

 

[Shoto]

i'd prefer not using jass, as i'm not doing advanced stuff here. and i have no idea how it works.
how can i clean it up using only the world editors triggering system?

 

[Narogog]

just put this custom script in front of your set gold mine number.

• Custom Script: set bj_wantDestroyGroup = true [trigger].
• it'll make it destroy the group.

 

[Dr Super Good]

By passing the group object as an argument to the DestroyGroup native.

 

[Shoto]

so, this happens and it disables the trigger.

 

[WaterKnight]

true not True. Jass is case-sensitive. But you have not listened to me. The function Unit - Count Living Units Owned By Player you know from GUI looks like I posted above in jass. You do not pass a group argument nor does it return one, so there is no reason to keep a group alive and it gets destroyed as you should be able to see there.

 

[Vladadamm]

https://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

Just a little question, do you have one trigger like this for each player ?

 

[Shoto]

@WaterKnight: Thanks! uh.. i don't really get what you're telling me.

@Vladadamm: Yes, one for each player.

 

[Spartipilo]

Shoto... fixing 'player' triggers is not needed. Almost any kind of trigger can be 'Generic', meaning that it can work for the player you want, without having to tell the trigger the exact player.

Example:

• Trigger
• Events
  • Time - Every 2.00 seconds of gameplay
• Conditions
• Actions
  • Player Group - Pick every player in (All Players) an do (Actions):
    • Loop - Actions
    • Set gold_mine_number = (Number of living ABandoned Gold Mine units owned by (Picked Player))
    • Player - Add gold_mine_number to (Picked Player).

There, it works for 1 or 12 players. Whatever you want. You can add If/then/Else if you want to filter/exclude/include certain players depending on whatever you want.

 

[Shoto]

@Spartipilo: yes, i'm aware of "generic" triggers, but i can't really come up with how to make generic triggers for everything
thanks for the trigger, hehe ^^ but doesn't it leak, like mine did?
...or did mine leak? you guys confuse me xD

 

[Maker]

Yeah, Spartipilo's trigger leaks.

 

[Shoto]

okay, thanks for pointing that out, i'll use the custom script posted earlier at this page to clean it up then?

oh and also, i have four of follwing trigger, one for each player.
is there a way to "generalize" (make only one trigger for everyone) this, or do i have to have separate ones as i have multiple regions?
I want sheep (trees) to spawn in different regions, close to the different players starting locations.

Trigger here

• Sheep Spawn player 1
  • Events
    • Time - Every 30.00 seconds of game time
  • Conditions
  • Actions
    • Set number = ((Current research level of More Sheep for Player 1 (Red)) + 3)
    • Set temp_point = (Center of Region 000 <gen>)
    • Unit - Create number Dummy for Player 1 (Red) at temp_point facing Default building facing degrees
    • Unit Group - Pick every unit in (Units in Region 000 <gen>) and do (Actions)
      • Loop - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Unit-type of (Picked unit)) Equal to Dummy
          • Then - Actions
            • Unit - Remove (Picked unit) from the game
            • Set temp_point = (Random point in Region 000 <gen>)
            • Destructible - Create a Sheep (Tree) at temp_point facing (Random angle) with scale 1.50 and variation 0
          • Else - Actions
            • Do nothing
    • Custom script: call RemoveLocation (udg_temp_point)

 

[Spartipilo]

Oops... Oh... you just have to declare "Number of living units owned by Player" in a Group variable before the "Pick Every Player" and use the group inside the loop, then remove it after the "Pick every player". I'm not sure if "set bj_wantDestroyGroup = true" before that variable set could work, I doubt it.

Also, filter your players using If/Then/Else inside, otherwise, if you use "All Players Matching" i've heard that leaks, you would have to declare the Force (Force = Player group) and Pick every player in the force, and then destroy the force (call DestroyForce(udg_YourForceName)).

---

Yeah... it's possible to make everything generic, MPI (Multi player instanceable) and MUI (Multi Unit Instanceable). Maybe something like this->

Trigger here

1) Create a "Region" type Variable, and check it as an Array, call it whatever you want.
2) Set Region[1] = Player 1 starting region (You have to create it)
Set Region[2] = Player 2 ...
Etc.

• Sheep Spawn player 1
  • Events
    • Time - Every 30.00 seconds of game time
  • Conditions
  • Actions
    • For each integer A from 1 to *YourPlayerNumber* do (Actions):
      • Loop - Actions
        • Set number = ((Current research level of More Sheep for Player(Integer A)) + 3)
        • Set temp_point = (Random Point in Region[Integer A])
        • For each integer B from 1 to number do (Actions):
          • Loop - Actions
          • Destructible - Create a Sheep (Tree) at temp_point facing (Random angle) with scale 1.50 and variation 0
        • Custom script: call RemoveLocation (udg_temp_point)

I don't understand why you create a dummy, then remove it to create a destructible in a random point... So I'll remove that part.
EDIT: Oh... How's that you can't create destructibles with numbers the same way you create units?...
EDIT: I did this without the editor... I guess it should work.

 

[Shoto]

meh, i'll go with it, i'll try and fix it if the leaks make the game unplayable.

Thanks for the sheep spawn trigger, but i'll go with my own with one for every player, heh ;P

 

[Spartipilo]

... Come on... don't be scared. You're using 5 complex triggers for something you can do with 1 simple. Try it, and you'll see it's better and efficient.

 

[Shoto]

haha, you'll have to explain yours clearly then, because i don't understand how the integer functions work, and i like to understand how stuff works ;P

 

[Spartipilo]

OK. Integer A and Integer B are default functions in Wc3 GUI. The only think is that they can't be working at the same time (You can't have 2 triggers working at the same time using "For each integer A") That' why there are Integer A, integer B, and even Variable integer.

---

Small Integer A Explanation

What it does is...

For each integer A from 1 to 10 do:
loop
Game - Display Message "Integer A".

It will display:
1
2
3
4
5
6
7
8
9
10.

What it does is do the actions in the loop for each one of the values between the X and Y, being "for each integer A from X to Y".

---

If you use:
For each integer A from 1 to (Number of Players Matching - User and Playing) do:
loop
Game - Display Message "Player(Integer A) Is a noob".

-> Player 1 is a noob
-> Player 2 is a noob
-> Player 3 is a computer, so, it won't display anything.
-> Player 4 is a noob.

---

It's the same than "Pick Every unit - Loop" since the actions will work for each one of the picked units. In this case are not units, but integers.

---

If you declare regions[1, 2, 3, 4], you can use:

For each integer A from 1 to 4 do:
-Loop
Unit - Create (Integer A) Footman for Player(Integer A) at Region(Integer A).

It will:
Create 1 footman for Player 1 at Region 1
Create 2 footman for Player 2 at Region 2
Create 3 footman for Player 3 at Region 3
Create 4 footman for Player 4 at Region 4

My Trigger Explanation

• Sheep Spawn player 1
  • Events
    • Time - Every 30.00 seconds of game time
  • Conditions
  • Actions
    • For each integer A from 1 to *YourPlayerNumber* do (Actions):
      • Loop - Actions
      • Set number = ((Current research level of More Sheep for Player(Integer A)) + 3)
      • Set temp_point = (Random Point in Region[Integer A])
      • For each integer B from 1 to number do (Actions):
        • Loop - Actions
        • Destructible - Create a Sheep (Tree) at temp_point facing (Random angle) with scale 1.50 and variation 0
      • Custom script: call RemoveLocation (udg_temp_point)

It will run the loop for 1, 2, 3, 4 5... etc untill your number of players. Lets take the 1.

• Sheep Spawn player 1
  • Events
    • Time - Every 30.00 seconds of game time
  • Conditions
  • Actions
    • Set number = ((Current research level of More Sheep for Player(1) + 3)
    • Set temp_point = (Random Point in Region[1])
    • For each integer B from 1 to number do (Actions):
      • Loop - Actions
      • Destructible - Create a Sheep (Tree) at temp_point facing (Random angle) with scale 1.50 and variation 0
    • Custom script: call RemoveLocation (udg_temp_point)

It's important to know that "For each Integer A" it will create the Temp_Point, so, for each integer A, you have to remove it too inside the loop
- When it runs for Integer A = 1, It will turn all the values inside the loop using [Integer A] to 1.
- When Integer A = 3, It will turn all the values inside the loop using [Integer A] to 3.

So, when you say "For Each integer A from 1 to 5", it will run the trigger 5 times making A=1, A=2, A=3, A=4, A=5.

That should be enough

 

[Shoto]

lots of thanks, i've learnt something new today ^^
i'll probably use integer functions in more of my triggers when i get the hang of it ^^

 

[Dr Super Good]

The idea is to reduce procedural coupling by generalizing procedures. When programming using real languages like C the reduction in code complexity makes for more efficient instruction caching which means fewer memory reads. It also makes your code easier to maintain as you only need to change it at 1 location instead of many (and each change introduces probabilities of errors being made).

Ironicly, the actual execution advantage is often lost in JASS due to how the language is interpreted by a very slow interpreter. The main reason to do it is so your script is more readable and maintainable.

 

[Spartipilo]

An example of something Dr Super Good Said:

If you want to add one more player to your map, you don't have to copy all the trigger and edit all the player values... You just increase The max Integer A by 1.

 

[Shoto]

yes, it does seem simpler than having multiple triggers for every player ;P

 

[Shoto]

I can't find one of the functions...

• Set temp_point = (Random Point in Region[Integer A])

I have no idea how to do that.

 

[Vladadamm]

It's "Set Variable" GUI action.

 

[Spartipilo]

Follow the instructions I gave:

1- Create the regions in the world editor
2- Create a Region type array variable, I called it "Region". It will request you an index this way Region[index].
3- In your first trigger (Map Initialization) you have to ->
3.1 Set Region[1] = Player 1 region
3.2 Set Region[2] = Player 2 region
... and so on.

Then, when you're setting the point, choose the Region variable, and it will request you an [index]. There you place "For integer A" option.

 

[Shoto]

@ Vladadamm: that's not what i was having issues with.
@Spartipilo: ah, thanks works fine, exept i miswrote something that made multiple sheep spawn at the same point xD fixed it though, thanks alot )))

 

[Magtheridon96]

set bj_wantDestroyGroup = true

Will do nothing in this case. (Just trying to clarify a few things)

 

[Shoto]

will it work without leaking if i do this?
(tested, it ticks correctly, but does it leak?)

trigger here

• Gold Tick
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Player Group - Pick every player in player_group and do (Actions)
      • Loop - Actions
        • Set gold_mine_number = (Number of living Abandoned Gold Mine units owned by (Picked player))
        • Player - Add gold_mine_number to (Picked player) Current gold

The "player_group" is a variable:

• Melee Initialization
  • Events
    • Map initialization
  • Conditions
  • Actions
    • Set player_group = (All players matching (((Matching player) controller) Equal to User))

 

[Dr Super Good]

Ofcourse it leaks. You create a new group every 2 seconds for every player in player_group but nowhere do you free (Destroy) the groups.

 

[Spartipilo]

Every 2 secs.

-> Set player_group = (All players matching (((Matching player) controller) Equal to User))
-> Pick every player in player_group and do:
-----> Loop: bla bla
-> call DestroyForce(udg_player_group)

 

[Dr Super Good]

Every 2 secs.

-> Set player_group = (All players matching (((Matching player) controller) Equal to User))
-> Pick every player in player_group and do:
-----> Loop: bla bla
-> call DestroyForce(udg_player_group)

Shoto's apprach is better. Pointless rebuilding a force every 2 seconds if it is unlikly to change in that time.

Ultimatly you only ever want to change the force at...
1. Map initilization when you first can test who is playing.
2. When a player leaves / is no longer taking part.

This saves unnescescary overhead of continiously reconstructing the force and freeing it. Your approach might leave a lower continious memory footprint, but that means nothing compared to the CPU time you are wasting.

 

[Spartipilo]

Yeah, I tough about that... forgot for a sec how it works

 

[Shoto]

so is there a way to fix the leak?

 

[Spartipilo]

I'm not sure... but I guess "call DestroyForce(udg_player_group)" after the "Pick every player in player_group".

 

[Shoto]

okay, i'll try that

 

[Dr Super Good]

He is not leaking a force... He is leaking lots of groups (unit groups for you GUI people...).

"living Abandoned Gold Mine units owned by (Picked player)" returns a group. Nowhere do you deallocate this group via DestroyGroup.

 

[Shoto]

so if i "set bj_wantDestroyGroup = true" it shouldn't leak?

Like this?

• Gold Tick
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Player Group - Pick every player in player_group and do (Actions)
      • Loop - Actions
        • Custom script: set bj_wantDestroyGroup = true
        • Set gold_mine_number = (Number of living Abandoned Gold Mine units owned by (Picked player))
        • Player - Add gold_mine_number to (Picked player) Current gold

 

[Spartipilo]

No.

You have to

1- Declare the group "(Number of living Abandoned Gold Mine units owned by (Picked player))" inside the loop, use Add Number of Living Abandoned Gold Mine units in GoldMines(This is a Unit-Group), and then "call DestroyGroup(udg_GoldMines)"

OR

2- Create that group (with an array) in map init with size = Number of players that can play, and use a trigger to add the "Abandoned Gold Mines" to that UnitGroup[Player Number of (Owner of The Mine)] <- This way you don't have to destroy the groups.

I don't know if there's another way (there is, for sure).

I would pick the first one Since it's easier, though not the fastest and efficient. I don't know which one would that be.

 

[Shoto]

bleh, could you show me how #1 would look in GUI?

 

[Spartipilo]

Pick every player in Player_Group and do:
Set Group = (living Abandoned Gold Mine units owned by (Picked player))
Add (Number of Units in Group) to (Picked Player) Current Gold.
call DestroyGroup(udg_Group)

 

[Shoto]

thanks, will try that )

Edit: works fine