Quick Question: Does this Leak?

[Aoen]

If you set a Point Variable more than once (lets say 1000 times), does it leak, or does it just overwrite the variable every single time it is set?

Oh, and another quick question, does this leak?
Set Temp_Point to equal Position of Picked Unit
Unit - Create 1 Locust at Temp_Point offset by 100 towards 10 degrees
Custom Script (call RemoveLocation (udg_TempPoint))

 

[HappyTauren]

1. no you gotta use RemoveLocation each time
2. it doesnt leak

 

[Aoen]

Thanks again Happy Tauren .

 

[Wolverabid]

Just as an aside, in case you are not already using it, Leak Check v2 is an outstanding program that will analize any GUI trigger for leaks.

 

[paskovich]

But you don't have to (you can't) put the function call in brackets!! It's simply:
Custom script - call RemoveLocation (udg_TempPoint)

 

[Mechanical Man]

And if he would make this, this would leak?

Unit - Create 1 Locust at (Position of Picked Unit)Point offset by 100 towards 10 degrees

 

[paskovich]

Sure! It creates two location leaks.
1. 1 leak for the Polar Projection Offset
2. and inside the PPO, 1 for the Position of Picked Unit

Oh and i just noticed.
Aoen, your version still creates 1 leak. Correct one:

• Set TempPointA = Position of Picked Unit
• Set TempPointB = TempPointA offset by 100 towards 10 degrees
• Unit - Create 1 Locust at TempPointB
• Custom script - call RemoveLocation (udg_TempPointA)
• Custom script - call RemoveLocation (udg_TempPointB)

 

[Mechanical Man]

Thank you very very much. Finally I solved this great mystery. So directly using function inside the action will surely cause leak. I would make a java comparison, I am sure you know it, you seem programmer type to me:

Let say we have two classes: class Main and class Argument
Main has a constructor with a parameter of type Argument

if we make this way:
Main variable = new Main(new Argument)

I am sure that the garbage collector will erase Argument type object which is used as a parameter after this statement, because no pointer points to it.

If we compare with JASS, no garbage collector is present, all dereferenced variables are not automatically deleted. It requires manual deletion. Even worse. if I make the way like above a thing in JASS, I cannot even delete it, as the pointer is not avalaible! So that method is not advisable to use. Then if I am not wrong, the Pick units action is useless (unless in cinematics maybe)!


WTF!!! Only 8 reputation points??

 

[paskovich]

Uhh, wow, i understood none of your words Mechanical Man, as i don't know any other programming languages...

WTF!!! Only 8 reputation points??

Cruel world!

 

[Aoen]

Actually Paskovich thats what I wanted to know in the first place, I just wanted to know if you would have to set the offset point to a new point, guess Happy Tauren was wrong , oh well thanks Paskovich and HappyTauren anyways.

 

[Mechanical Man]

What about this:

Event - unit enters region

Condition - entering unit is equal to footman

Action - set movement speed of (entering unit) to 100


Does it leak and I must use variables to store entering unit, so I can remove it at the end of the trigger?

 

[l33t5up4h4x0r]

Uhmm these are basic things i doubt many ppol actually check for leaks in these unless your map is really really laggy already. I havent checked any leaks for my map yet it works fine even though it has a lot of demi-second events and does not remove stored variables.

 

[Mechanical Man]

Yes, but if it is triggered often

 

[paskovich]

No Mechanical Man, that trigger uses an event-based variable (Entering unit). These do not leak, as they do not create new handles (like the locations). Local variables in jass are different, as they store data in the memory. In GUI, only the location leaks need "care". And special effects. Even if the effect does not have a "stand" animation, (so just sreates an effect once), they must be destroyed, as they remain on the map:

Create S.E. at <Loc> ...
Set SEvar = Last Created S.E.
Destroy SEvar

 

[Mechanical Man]

Good then. Actually I malformed my first question. It should be like this

Unit Group - Pick all units in Region01<gen> and order (picked unit) to move to <Region02>

What about this? Notice that Region variables are just picked directly from the map with 'Select a region'.

 

[paskovich]

They are an other type of variables, called generated variables. And they do not leak...
Btw, i forgot groups. They must be destroyed too:

Set TempGroup = Pick all units in Plyable Map Area
Pick all units in TempGroup ...
-Loop ...
call DestroyGroup(udg_TempGroup)