Does "Replace Unit" cause a memory leak?

[Peacehagen]

As stated in title, does the "Replace Unit" function in trigger cause a memory leak? If so, is there any easy way to fix it or is it better to just not use it at all?

Im adding units to a marketplace from a random pool of over 60 units so instead of removing every singel unit type when refreshing the marketplace, i just replace the marketplace with a new one. Maybe thats a bad idea.

Thanks in advance

 

[Strydhaizer]

I don't think so, replacing unit is just like creating unit and removing the previous unit.

Here's a full list of possible memory leaks.

Memory Leaks

 

[Drake53]

A unit will always keep a tiny bit of memory, even when removed properly. 0.04 kb and unpreventable.

And since ReplaceUnit creates a new unit, the answer is yes.

 

[Peacehagen]

Thank you for your answers. I am not very knowledgable about leaks. Would around 800 Replace Unit functions result in the map being laggy?
Thinking the marketplace might refresh a maximum of 100 times per player during a full playthrough and a total of 8 players.

If you dont know its ok, i will keep it as it is and see through testing if its a problem or not

 

[Ceday]

Would around 800 Replace Unit functions result in the map being laggy?

Such a low number won't cause a problem (but if all replacements occur at the same time, you may feel a spike depending on your computer specs), the leak that is mentioned above is very minor you won't feel it before thousands of unit creation/removing.

Also you can test such stuff yourself. Just open your task manager and note memory usage, replace N amount of units and wait for a while (W3 does not immediately clear unused memory so waiting is crucial, it will start going down after a while), then compare memory usages. Try not doing anything else though, even moving your camera from one point to another increases memory usage temporarily so you may misjudge the result.

 

[Strydhaizer]

Thank you for your answers. I am not very knowledgable about leaks. Would around 800 Replace Unit functions result in the map being laggy?
Thinking the marketplace might refresh a maximum of 100 times per player during a full playthrough and a total of 8 players.

If you dont know its ok, i will keep it as it is and see through testing if its a problem or not

Yes, you're technically creating 800 new units in your map every time you 'refresh', even if you have only 100 units created at a single second you will already notice game stutter/heavy performance hit.

 

[Pyrogasm]

The actual issue with Replace Unit is that it has a reference leak. Look at the JASS function and you will see it declares a local unit variable that isn’t nulled before the function returns. There is nothing you can do about this in GUI and you will likely not notice this.

 

[Peacehagen]

Thank you everyone for the answers, it has been very helpful!