Do we need to null array members?

[sethmachine]

Hi,

Suppose I have a dialog and I store its buttons in an array of buttons. I then call DialogDestroy(d). Presumably this also destroys all the buttons. Now, do I need to go back to the array of buttons and null them all? Or does DestroyDialog(d) do that for me?

local button array bttns
local dialog d
set d = DialogCreate()
set bttns[0] = DialogAddButton(...)
call DestroyDialog(d)
//now do I need to still null bttns[0]?
set bttns[0] = null //is this call necessary?

 

[Nestharus]

The buttons won't be nulled. However, as they are global, the references will be cleaned up the next time the bttns are set. If you'd prefer the references to be cleaned immediately, you'll need to null them when you destroy the dialog.

 

[Adiktuz]

w8, didn't he made a local array for the buttons (so he'd really need to null them)?

 

[Nestharus]

Oh, I didn't realize that it was local.

Then yes, he would have to null them.

Local arrays are like never used in JASS, lol...

 

[Malhorne]

Local handle have to be nulled.
Even globals handle have to be nulled if it is something that will be destroyed in order to be recycled.
Welcome in JASS XD

 

[BPower]

For example you run a certain spell quickly 20 times, but for the rest of the game you only have 2 cast simultaneously.
Now you have 18 instances which never will be overwritten or cleaned up.
Opinions vary when it comes to nulling, even along the veterans around here.

 

[Malhorne]

Even if there is a reference in globals you have to clean it.
Maker will tell you the same thing : global leak when not nulled.