Do buttons permanently leak after a dialog is destroyed?

[sethmachine]

Hi,

There seems to be some uncertainty if buttons permanently leak, probably because there is no native like DestroyButton or RemoveButton--dialogs have to be "redrawn" or "repainted" in order to remove a button.

See https://www.hiveworkshop.com/forums/submissions-414/system-dialog-button-254366/ for some apparent discussion on this dubious topic.

So, if a Dialog is destroyed, are its buttons also deallocated? Or is there a permanent leak for each button?

 

[Bannar]

Thank you @sethmachine for encouraging ppl to test this thing
With my latest tests, edo494 might be just right, however, it would be perfect if multiple users shared their opinion here.

 

[Bannar]

Bump.

 

[WaterKnight]

DialogClear as well as DialogDestroy remove buttons. And do not confuse what is drawn with what is present within jass. Jass is only an interface to the engine.

 

[sethmachine]

Aye so both DialogClear and DialogDestroy deallocate the memory that each button used?

 

[WaterKnight]

This I cannot say but likely. The handle vanishes and to date only RemoveUnit was reported to leave some remains. Then you can as well question all other handle types/destroy functions.

 

[Bannar]

Perfect! Thanks for help @WaterKnight. One opinion means not much, but since it is you, together with edo494 reported that button-leak is not an issue I'm calm now

 

[WaterKnight]

I did nothing more than a simple test, checking whether the ids reoccur. Besides, a button has not much raison d'être than residing within a dialog.

 

[Bannar]

I have performed probably the same "simple" tests, yet the lack of native for destroying button still was giving me impression that those handles leak somehow.