Disarm System v1.1.1

[Moderator]

12:11, 7th Apr 2015
IcemanBo: Useful.

 

[Kazeon]

It's very easy and faster to use timer and hashtable instead of periodical unit enumeration. It's getting heavier as the disarmed units are increasing.

 

[Daffa]

Using Hashtables and Timer Enum, I might consider it though.
But I doubt it's too heavy as I see multiple units can be added just fine.

 

[Wietlol]

Disarm... what does it do?
WC3 does not have "weapons" so units cannot be disarmed.
(I know that it is just "blind" but yea you did not mention it.)

Also why does this one has to be used over the existing ones?
People who already use those must know why they should use this one instead.
People who do not use any yet and want to use one will use the same as everyone else does... 70% of the time.

 

[Daffa]

This one offers complete control over the disarmed units, you have practically all the access you need.
Basically, in short this one grants full control for users, want to disarm unit while giving them DPS? Sure, disarm then slow them at the end? Why not, disarm and deal double damage to them while disarmed? Okay.
In short, it offers control over the target, which sometime might be a case for user who wants to make a complex spell relying in disarmed units (or in short, blind).

 

[IcemanBo]

Looks good and simple to use.
If unit is already registred no need to increase the counter and no need to add the unit to group.
Getting unit's current stun duration could be useful, too. Just an idea.
User could take it in consideration to define the new disarm duration onRegister.

DisarmAttachment
DisatmEffect

^These should be constants, and be set once in config part. You won't anyway create an other effect if unit is registered already, so it will never have different effects.

So register will only look like:
Set DisarmUnit = <MyUnit>
Set Duration = <MyDuration>

What could be maybe useful is to change the static boolean to stack/not stack to dynamic one.
Though that's also only an idea.

 

[Wietlol]

And this is done by adding an ability to a unit and removing it when the disarm would be removed?

(I do see the complex stuff about remaining duration and stuff but just that we are on the same level.)

 

[Daffa]

Looks good and simple to use.
If unit is already registred no need to increase the counter and no need to add the unit to group.
Getting unit's current stun duration could be useful, too. Just an idea.
User could take it in consideration to define the new disarm duration onRegister.

DisarmAttachment
DisatmEffect

^These should be constants, and be set once in config part. You won't anyway create an other effect if unit is registered already, so it will never have different effects.

So register will only look like:
Set DisarmUnit = <MyUnit>
Set Duration = <MyDuration>

What could be maybe useful is to change the static boolean to stack/not stack to dynamic one.
Though that's also only an idea.

Thanks

I will fix that one.

I consider getting the duration, but that would requires a little nifty code to make it easy to implement.

The effect is optioned so that each units can have different effects and such.
The duration Boolean?

And this is done by adding an ability to a unit and removing it when the disarm would be removed?

(I do see the complex stuff about remaining duration and stuff but just that we are on the same level.)

Yeah, it's using the basic technique, which is also applied to my old Blind Spell (in my resources list).
It's not complex for the basic technique, but this one offers a lot for users that wants a completely controllable disarming.

 

[Wietlol]

I can write your system with only 1 configuration trigger inside my EOT System
Not to just kick your (_._)... that system of mine is also not yet approved :\

 

[IcemanBo]

But if you want to register unit once again (now with different effect), it won't be shown. :/

 

[Daffa]

I can write your system with only 1 configuration trigger inside my EOT System
Not to just kick your (_._)... that system of mine is also not yet approved :\

It's your call, all I want to give is a simple system with some features. Users have their calls, and it's their preference to choose which they want.
The system isn't too complex so it's not difficult for user to learn it's features, and not a pain for me to create.

But if you want to register unit once again (now with different effect), it won't be shown. :/

Yeah, tried some different tricks yet none worked, I wonder if overriding the old one is better than discarding the new one, your opinion?
Hope I figure something by a few days or anything,

 

[Wietlol]

and not a pain for me to create.

Haha, I got problems with that one

 

[Daffa]

Okay, planned updates :

1. Fix the annoying SFX issue, so users can attach SFX directly to system without buffs, the retrieving method still requires a filter to check which spell or attack affect the disarmed unit.
2. Allows duration manipulation, this is to allow user adding, subtract, multiplies, divides and so on the remaining duration of disarmed units, meaning user has full control over disarmed unit's duration.
3. Point 2 will also come along with another Boolean that allows or prohibits a certain unit from having their duration manipulated. A mechanic will also be explained for this one.
4. Duration stacking Boolean changed into dynamic one. The mechanic will be explained later.
5. Improves the registration trigger, giving it more optimization
6. if possible, animations can be included, mainly during the start and ending phase. {Optional}

Well, hope they can be applied to the system

 

[IcemanBo]

I wonder if overriding the old one is better than discarding the new one, your opinion?

In this case removing the old and using the new indeed might be better, but frankly I don't think you have to bother with multiple effects.
People probably don't need many different effects to indicate a "disarmed" unit. You doubtless could go with one constant one I believe!

animations can be included, mainly during the start and ending phase

User already can catch the start and end event, so he can use this for animation if really needed.

With doing as less extra features as possible you're doing fine I believe.. it will be useful. Gl with next update!

 

[Daffa]

In this case removing the old and using the new indeed might be better, but frankly I don't think you have to bother with multiple effects.
People probably don't need many different effects to indicate a "disarmed" unit. You doubtless could go with one constant one I believe!


User already can catch the start and end event, so he can use this for animation if really needed.

With doing as less extra features as possible you're doing fine I believe.. it will be useful. Gl with next update!

Perhaps you're correct about that one, but users might want different effects for some units and some others (example : unit A effect A, unit B effect B and so on) or anything else in their minds.

To be honest, you're correct, I should have think about it before

Thanks, hope I can carry out the update

 

[Daffa]

Here's a list of status while preparing the new version :

1. Successfully implement point 4, but... Refer to 2
2. About stacking, how should the stack rules applies? Should stacking and non-stacking duration holds 2 different durations?
3. I figure out that modification of the duration (Point 2 & 3 from the planned update) is quite difficult to control and seems advanced. I might not implement Boolean rules into it, so maybe only point 2 will applies in next update
4. SFX issue still persist, but this time e newest one will be shown instead of the older one.
5. Scrapped Point 6, IcemanBo explains it well in this post.

 

[Daffa]

Alright, here's a surprise news.

Current status :
1. Well, point 3 is scrapped (for now) and I manage to find a solution to point 2, it's by making the default duration remaining variable modifiable by user
2. Making a new manual for an in-depth guide through the system usage, what I said in point 1 is included in this new manual, as advanced usage.

Below are planned stuffs before the update :
1. Make the disarm source accessible, this is important for damage through disarm and such that involves caster <-> target
2. Make the duration possible to be "frozen", causing it to stop decreasing until "unfrozen"

 

[Chaosy]

Plz.. stop putting 3 comment lines and one GUI line.. it seriously annoys me.

 

[Daffa]

Alright, I'll take that into my note and fix it, might switch to a comment trigger or Jass for the Disarm Manual trigger though.

EDIT :
Found a major bug with the disarm freezing duration mechanic, don't use it until the next update!

 

[Daffa]

Forget to mention that the bug from the previous post has been fixed

 

[ukn0wnD3str0y3r]

Hello Bello

 

[Daffa]

Hello Bello

Hello
Any feedback?

 

[IcemanBo]

If an instance is "frozen" the onLoop event should probably not fire.

Set DisarmDurationStackBoolean[DisarmUnitValue] = DisarmDurationStack [/stable] ^This is not needed. You only use it onRegistration. Nothing significant, but in loop you could jump into else block and then: Or - Any (Conditions) are true Conditions DisarmDurRemain[DisarmUnitValue] < 0.00 (DisarmedUnit is dead) == True Or - Multiple Conditions block is not needed. Can be -> (DisarmDurRemain[DisarmUnitValue] >= 0.00 (DisarmedUnit is alive) == True (^Not important)

 

[IcemanBo]

Well since the user still has possibility to check the the state if duration is stopped or not onLoop event, it's okay.
Something like each 0.1 seconds would also be completly fine for interval in my opinion.

Anyway... all works good, easy to use, and simple! Approved.

 

[Daffa]

If an instance is "frozen" the onLoop event should probably not fire.

Set DisarmDurationStackBoolean[DisarmUnitValue] = DisarmDurationStack [/stable] ^This is not needed. You only use it onRegistration. Nothing significant, but in loop you could jump into else block and then: Or - Any (Conditions) are true Conditions DisarmDurRemain[DisarmUnitValue] < 0.00 (DisarmedUnit is dead) == True Or - Multiple Conditions block is not needed. Can be -> (DisarmDurRemain[DisarmUnitValue] >= 0.00 (DisarmedUnit is alive) == True (^Not important)

Kinda difficult to handle those frozen instance. I'll think of a possibility. Really? I fear the stack get bugged that way when 2 different booleans are send in succession. Interesting, wait, between IsUnitAlive and IsUnitDead which is faster? Forget about that one. Well since the user still has possibility to check the the state if duration is stopped or not onLoop event, it's okay. Something like each 0.1 seconds would also be completly fine for interval in my opinion. Anyway... all works good, easy to use, and simple! Approved. I fear in 0.01 it's too much for older comps to handle. Thanks!

 

[ukn0wnD3str0y3r]

Great work!!haha, I forgot most of the triggers things... since I've stop onoine so long

 

[Daffa]

No update, just a slight documentation fixing which should've been done since the start of Hive 2 and those emoji.

 

[Daffa]

Updated the resources to address a new native IcemanBo mentioned in his Disarmament v1.1 resources.

 

[KaiZen7th]

in 1.32 and above, you can easily choose which type of weapon to be "silent" in the Silence Spell data.