Destroying Sounds

[QueenOfOblivion]

• Rain
  • Events
    • Time - Elapsed game time is 5.00 seconds
  • Conditions
  • Actions
    • Sound - Play RollingThunder1 <gen>
    • Sound - Set volume of (Last played sound) to 100.00%
    • Sound - Destroy (Last played sound)
    • Wait (Random real number between 150.00 and 300.00) seconds
    • Trigger - Run (This trigger) (checking conditions)

The sound only works the first time, If you destroy a sound you can't play it again? how can I fix this?

 

[Yixx]

I thought you had to set it in a variable? I dont know for sure but that could work =D

 

[Super-Sheep]

Set SOUND1 = Last played sound
Destroy SOUND1 after wait

 

[QueenOfOblivion]

Okay, thanks +1
Edit: Like this?

• Rain
  • Events
    • Time - Elapsed game time is 5.00 seconds
  • Conditions
  • Actions
    • Sound - Play RollingThunder1 <gen>
    • Set Sound = (Last played sound)
    • Sound - Set volume of Sound to 100.00%
    • Sound - Destroy Sound
    • Wait (Random real number between 150.00 and 300.00) seconds
    • Trigger - Run (This trigger) (checking conditions)

 

[Super-Sheep]

Wait - (Sound - Leght of Sound)
Destroy Sound

 

[Element of Water]

No no no I think none of you get the point. I think the point is, after you destroy a sound, you can't play it again. The obvious answer would be not to destroy the sound - why do you need to destroy it anyway?

 

[QueenOfOblivion]

Because it leaks

 

[Element of Water]

It doesn't leak though - you don't create a sound every time you play one, therfore you don't need to destroy it after you've played it...

 

[QueenOfOblivion]

Are you 100% sure?
Edit: And how should I make it then? Sound - Stop playing sound ?

 

[Element of Water]

100%. The JASS for playing sounds is this:

function PlaySoundBJ takes sound soundHandle returns nothing
    set bj_lastPlayedSound = soundHandle
    if (soundHandle != null) then
        call StartSound(soundHandle)
    endif
endfunction

Basically, what this does is sets the last played sound to the sound you pass it, and if that sound exists, plays it. You create the sound via the sound editor. This function does not. It just plays a sound which has already been created.

 

[QueenOfOblivion]

I'm not that good with Jass, How can I make it in GUI?

And how should I make it then? Sound - Stop playing sound ?

 

[Element of Water]

No, you don't get my point. What I was pointing out was that the JASS function which the GUI Play Sound uses is that function. And that function does not create a sound.

Whatever it doesn't matter, basically DON'T destroy sounds after you've played them - they won't leak.

 

[QueenOfOblivion]

Hmm, mkay sorry for being a dummy just one question, is this right? or should I remove the Sound - Stop (Last played sound) After fading ?

• Rain
  • Actions
    • Sound - Play RollingThunder1 <gen>
    • Sound - Set volume of (Last played sound) to 100.00%
    • Sound - Stop (Last played sound) After fading

 

[Dynasti]

Well when destroying a sound you are destroying a soundhandle, that is created upon game initialization. What you need to do is creating a new sound after destroying it( or create a sound to be destroyed ).

This can be done with a simple jass function

 

[Eleandor]

There's no reason why you would want to destroy a sound if you'll be re-using it. There's no reason to destroy anything if you're going to reuse it.

 

[QueenOfOblivion]

And yet, nobody answered me. and for some reason this trigger doesn't work?

• Rain
  • Actions
    • Sound - Play RollingThunder1 <gen>
    • Sound - Set volume of (Last played sound) to 100.00%
    • Sound - Stop (Last played sound) After fading

 

[Element of Water]

You don't need to stop the sound, no. It will stop on its own once it's finished. There is no reason why that trigger shouldn't work.

 

[SlickR]

• Rain
  • Events
    • Time - Elapsed game time is 5.00 seconds
  • Conditions
  • Actions
    • Sound - Play RollingThunder1 <gen>
    • Sound - Set volume of (Last played sound) to 100.00%
    • Sound - Destroy (Last played sound)
    • Wait (Random real number between 150.00 and 300.00) seconds
    • Trigger - Run (This trigger) (checking conditions)

The sound only works the first time, If you destroy a sound you can't play it again? how can I fix this?

your trigger is fine, just use it and everything should be okay.
Though what is the wait for? It does not seem to have any function!

 

[Element of Water]

SlickR, that trigger is not fine AT ALL. If it destroys the sound, how can you play it again? And that wait is so it makes a sound every 150-300 seconds... duh!

Don't post if you don't know what you're talking about!

 

[SlickR]

SlickR, that trigger is not fine AT ALL. If it destroys the sound, how can you play it again? And that wait is so it makes a sound every 150-300 seconds... duh!

Don't post if you don't know what you're talking about!

can you behave?
whats your problem?
if i make a mistake somewhere because i wasn't paying that much attention is no big deal, you on the other hand really have some issues. Clear them out before you talk to me!

My bad about the wait, i saw it said checking conditions so i assumed he had another trigger set up to run this one, but you really need to clear your head up, you can't jump on every person if they made a small mistake or you don't agree with them.

yeah he just needs to remove destroy last created sound and thats that.
He can make a separate trigger to destroy the sound when he wishes to and does not need the sound anymore!

 

[Element of Water]

can you behave?
whats your problem?
if i make a mistake somewhere because i wasn't paying that much attention is no big deal, you on the other hand really have some issues. Clear them out before you talk to me!

My bad about the wait, i saw it said checking conditions so i assumed he had another trigger set up to run this one, but you really need to clear your head up, you can't jump on every person if they made a small mistake or you don't agree with them.

It's not because you made ONE SMALL mistake, it's because you've made several LARGE mistakes over most of your posts in the Triggers and Scripts forum, and I'm getting annoyed with you posting crap everywhere.

The trigger is fine again, coz now that the wait is cleared up that means the sound is recreated every time the trigger is run, so destroying it will not cause problems. Essentially he is creating a new sound every time and destroying it.

WRONG. The sound is created and destroyed each time, it's created ONCE at map initialization, and just PLAYED every time the trigger runs.