[DDS Plugin] Damage Event

[Nestharus]

This resource has moved here.

--

gone

 

[Nestharus]

gone

 

[Nestharus]

Updated

changed locks set to unlock call

 

[HammerFist132]

Ney mate, what is this comparing with your dds in spell forums. If I hate something in your resources, then it is that you dont give excamples, dont give some info when test maps starts and I have not seen intalling intruction, so most of your dc works are totaly useles for us medium level coders.

 

[Nestharus]

The DDS is just a skeleton that plugins can go into. This is a plugin submission : p. The plugin pack has all of my plugins in it =).


Oh, and updated to no longer lock/unlock indexes to improve efficiency. Moved locking to damage modification and made it. Did it on timer damage so as not to constantly lock/unlock =).

 

[Magtheridon96]

Approved.

 

[Nestharus]

Updated enabled to play nice with ArcheType plugin. This laptop doesn't have wc3, so the update isn't currently in the Plugin Install Pack. You'll have to cnp the code from this thread.

The update makes it so that the system continues to run, it just doesn't call user code. Enabled will now disable user code, it won't disable the system.

 

[Cokemonkey11]

Edit: Basically there's a bug in your system which makes GetUnitState(u,UNIT_STATE_LIFE) unsafe by sometimes returning the value of the unit's health + the offset of the maximum life ability.

I haven't had time to look at what might be causing this, but somehow lfh's script circumvents this issue.

On the bright side, after attacks stop occurring, this script proves the correctness of all 3 scripts (10,000 attacks dealing 1 damage each will deal 10,000 damage, regardless of whether or not the attacks occur simultaneously - this is good news for scripts that use the ITEM_MAX_HEALTH ability)

 

[Nestharus]

Yes, I know.

*       readonly static real life
*           -   how much life the target unit has

: p

 

[looking_for_help]

That doesn't help.

call UnitDamageTarget(u1, u2, 0.5*GetUnitState(u2, UNIT_STATE_LIFE), true, false, null, DAMAGE_TYPE_UNIVERSAL, null)

can run between damage event and timer. Further nothing to get a units max life.

 

[Nestharus]

The variable is accurate, and it accounts for damage that is currently being applied. If a unit has 1000 hp and 999 damage is applied, life will be 1.

Use life instead of GetUnitState. I put it in there for a reason =).

 

[looking_for_help]

Its not an accuracy thing.

1.) You don't have acces to life from everywhere, so you can't use scopes:

1

struct Test extends array
    private static method onDamage takes nothing returns nothing
        set damage = 0.0001*damage
    endmethod

    implement DDS
endstruct

scope test initializer Init
    private function slowCallback takes nothing returns nothing
        call UnitDamageTarget(gg_unit_hkni_0000, gg_unit_hkni_0000, 0.5*GetUnitState(gg_unit_hkni_0000, UNIT_STATE_MAX_LIFE), true, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, null)
    endfunction
    
    private function fastCallback takes nothing returns nothing
        call UnitDamageTarget(gg_unit_hkni_0000, gg_unit_hkni_0000, 10000.0, true, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, null)
    endfunction

    private function Init takes nothing returns nothing
        call TimerStart(CreateTimer(), 0.01, true, function fastCallback)
        call TimerStart(CreateTimer(), 1.00, true, function slowCallback)
    endfunction
endscope

So this will break all spells that use GetWidgetLife/GetUnitState from scopes/libraries that are not implemented into DDS.

2.) Even if you have access, it then may not contain anything (only zero):

2

struct Test extends array
    private static method onDamage takes nothing returns nothing
        set damage = 0.0001*damage
    endmethod

    implement DDS
endstruct

struct test extends array
    private static method slowCallback takes nothing returns nothing
        call BJDebugMsg(R2S(life))
        call UnitDamageTarget(gg_unit_hkni_0000, gg_unit_hkni_0000, 0.5*GetUnitState(gg_unit_hkni_0000, UNIT_STATE_MAX_LIFE), true, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, null)
    endmethod
    
    private static method fastCallback takes nothing returns nothing
        call UnitDamageTarget(gg_unit_hkni_0000, gg_unit_hkni_0000, 10000.0, true, false, ATTACK_TYPE_CHAOS, DAMAGE_TYPE_UNIVERSAL, null)
    endmethod

    private static method onInit takes nothing returns nothing
        call TimerStart(CreateTimer(), 0.01, true, function thistype.fastCallback)
        call TimerStart(CreateTimer(), 1.00, true, function thistype.slowCallback)
    endmethod
    
    implement DDS
endstruct

 

[Nestharus]

Huh?

What you said made no sense

readonly static real life

It's static... and it's in DDS

What's hard about doing DDS.life?

 

[looking_for_help]

Yes thats right.. I'm already quite tired lol

But the second problem remains, the variable is empty so you have no way to get the units life, nor its max life.

 

[Nestharus]

Huh? The variable isn't empty.

If a damage event is up, the variable has something in it.

Unless you mean for a general function working with unit life that takes a unit and is called within a damage event? Or code that runs in between that has nothing to do with the damage event stuff. I see what you mean now : ).

edit
A lot of overhead is added to maintain the correct health of a unit from event to event. The logic gets very complicated too : |. However, now that I see this issue, it might be worth it to look into that.

I'm also looking into figuring out some way to disable all of DDS so that spell damage doesn't run 2 triggers every time.

 

[looking_for_help]

Or code that runs in between that has nothing to do with the damage event stuff. I see what you mean now : ).

Exactly this.

 

[Nestharus]

Updated with improved performance

 

[Heaven Editor]

Hai. I have a problem. I use dummy to cast flame strike. The damaged units seem to kill themselves. I think this is the cause.

In Damage Event Modification DDS Plugin trigger

call RemoveAfterDamage(targetId_p)
                    if (actualDamage < 0) then
                        set DDS[targetId_p].enabled = false
                        call SetWidgetLife(u, damageOriginal)
                        call UnitDamageTarget(u, u, damageOriginal*100, true, false, null, DAMAGE_TYPE_UNIVERSAL, null)
                        call UnitDamageTarget(u, u, damageOriginal*100, true, false, null, DAMAGE_TYPE_NORMAL, null)
                        set DDS[targetId_p].enabled = true
                    else
                        call SetWidgetLife(u, actualDamage)
                    endif

I don't want them to kill themselves. What am i suppose to do?

 

[Nestharus]

That's not the cause, look above it

                if (life - damage_p < .4051) then
                    call RemoveAfterDamage(targetId_p)
                    if (actualDamage < 0) then
                        set DDS[targetId_p].enabled = false
                        call SetWidgetLife(u, damageOriginal)
                        call UnitDamageTarget(u, u, damageOriginal*100, true, false, null, DAMAGE_TYPE_UNIVERSAL, null)
                        call UnitDamageTarget(u, u, damageOriginal*100, true, false, null, DAMAGE_TYPE_NORMAL, null)
                        set DDS[targetId_p].enabled = true
                    else
                        call SetWidgetLife(u, actualDamage)
                    endif

if (life - damage_p < .4051) then

This says that if the unit is going to die from the damage, then kill that unit. The unit will either die from UnitDamageTarget if the actual damage is negative (spell damage is negative, it has to be accounted for) or set the unit's life to the actual damage if it's not negative to ensure that it dies.

I've never run into this issue. It sounds like Flame Strike is hitting the stuff that is killing itself. If Flame Strike is doing damage to them, that explains it ;o.

 

[looking_for_help]

Why is unit u killing u (himself)? I just tested it and it seems that heros also don't get XP from killing enemy units with modified spell damage, so I guess the problems are not caused by flamestrike.

 

[Nestharus]

Ur right, source of damage should be killing the units. I'll do an update today. Fix the spell damage thing that breaks code event and this ;o.

It's nice that the code of DDS is so easy to read and manage ;D, makes finding and fixing bugs very easy ;p. This is probably the cleanest/prettiest code I've ever written ;o.

 

[looking_for_help]

Yes, it's nice indeed

 

[Nestharus]

Updated

See DDS Thread

Update 11