Data Multiboard v1.3

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

01:21, 10th Jan 2015
IcemanBo:

The system is hardcoded. A data multiboard should be customizeable.

 

[Deleted member 219079]

You should upload triggers here. http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

 

[userid907]

You should upload triggers here. http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

Thank you!
+rep

 

[userid907]

sorry the icon reversed :v
sorry bad english :v
im indonesian people :v

 

[Deleted member 219079]

No problem.


Btw, you should hide your rep until you've got to green. People are biased against red rep people.

 

[Lender]

Delete every single "Do Nothing" line from your script , coz as it says it does nothing but initiates a native call for no reason calls an empty function (thx edo ).

EDIT:

remove: these

• (Player number of (Owner of (Killing unit))) Greater than or equal to 1

it's always true so pointless

also use (triggering unit) instead of (dying unit) and don't use (last created multiboard) . save it in a variable and use that.
like:

• Set YourMultiboardVar= Create multiboard....

and always store everything in a Var if used more then once

EDIT:
Why do u use those specific button icons?:/ it's just makes no sense to me
u can leave them out and delete all the "display type" lines and just use this one once

• Custom script: call MultiboardSetItemsStyle(udg_YourMultiboardVar,true,false)

it sets the display type of ALL the multiboard items so u don't have to set one-by-one

shrink your hero level set trigger like this:
leave this out funny

• ((Leveling Hero) is A Hero) Equal to True

• Hero Level update
  • Events
    • Unit - A unit Gains a level
  • Conditions
    • (Player number of (Owner of (Leveling Hero))) Less than or equal to 9
  • Actions
    • Set TempInt = (Player number of(Owner of (Triggering unit)))
    • Set TempLvl = (String((Level of (Triggering unit)))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • TempInt Less then 4 (Red)
      • Then - Actions
        • Multiboard - Set the text for YourMultiboardVar item in column 4, row (TempInt+2) to (TempLvl)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • TempInt Greater then 6 (Red)
          • Then - Actions
            • Multiboard - Set the text for YourMultiboardVar item in column 4, row (TempInt+4) to (TempLvl)
          • Else - Actions
            • Multiboard - Set the text for YourMultiboardVar item in column 4, row (TempInt+3) to (TempLvl)

something similar can be done with total death and kill
and there is still more how this can be optimized, good luck

 

[edo494]

Delete every single "Do Nothing" line from your script , coz as it says it does nothing but initiates a native call for no reason.

it actually makes the interpreter run empty Jass function, not call native function.

http://jass.sourceforge.net/doc/api/Blizzard_j-source.shtml#1173

 

[Lender]

it actually makes the interpreter run empty Jass function, not call native function.

yeah, I recalled it wrong thx for the correction

 

[deathismyfriend]

Never use an and all condition block unless it is inside an or all condition block.

• ((Dying unit) is A Hero) Equal to True
• (Player number of (Owner of (Killing unit))) Less than or equal to 9
• (Player number of (Owner of (Killing unit))) Greater than or equal to 1
• (Player number of (Owner of (Dying unit))) Less than or equal to 12
• (Player number of (Owner of (Dying unit))) Greater than or equal to 1
  • And - All (Conditions) are true
    • Conditions
      • (Unit-type of (Dying unit)) Not equal to
      • (Unit-type of (Dying unit)) Not equal to
      • (Unit-type of (Dying unit)) Not equal to
      • (Unit-type of (Dying unit)) Not equal to
      • (Unit-type of (Dying unit)) Not equal to
      • (Unit-type of (Dying unit)) Not equal to

Anything used twice or more should be stored in a variable and the variable should be used.

Never use integer A / B. Make a custom integer and use that for your looping. Integer A / B are less efficient and slower than a custom integer.

You will need to make this more configurable. I don't see this being approved in its current state. It will be to hard to modify for someones map.

 

[userid907]

Ok Ok Thanks !!! For you criticsm

 

[deathismyfriend]

This can be removed as it does nothing.

• -------- Multiboard Custom Integer --------
• Set MultiboardCustomInteger = (Integer A)

Never use Dying unit use triggering unit instead.

Anything used twice or more should be stored into a variable and the variable should be used. Example: store triggering unit into a temp variable and use that.

You should look at your Acumulation Kill And Sound trigger. You check if the player number is less than or equal to 9. In the then block of that ITE you have an ITE that check if the number is 10 / 11 / 12 which will never be true.

Also you make the sound trigger more efficient like this.

• Acumulation Kill And Sound
  • Events
    • Unit - A unit owned by Player 1 (Red) Dies
    • Unit - A unit owned by Player 2 (Blue) Dies
    • Unit - A unit owned by Player 3 (Teal) Dies
    • Unit - A unit owned by Player 4 (Purple) Dies
    • Unit - A unit owned by Player 5 (Yellow) Dies
    • Unit - A unit owned by Player 6 (Orange) Dies
    • Unit - A unit owned by Player 7 (Green) Dies
    • Unit - A unit owned by Player 8 (Pink) Dies
    • Unit - A unit owned by Player 9 (Gray) Dies
    • Unit - A unit owned by Player 10 (Light Blue) Dies
    • Unit - A unit owned by Player 11 (Dark Green) Dies
    • Unit - A unit owned by Player 12 (Brown) Dies
  • Conditions
    • ((Triggering unit) is A Hero) Equal to True
  • Actions
    • Set tempPlayer = (Owner of (Killing unit))
    • Set tempInt = (Player number of tempPlayer)
    • Game - Display to (All players) the text: ((|c001ce6b9 + ((Name of tempPlayer) + |r)) + ( |cff9C00B4has just pawned|r |cffFEFFD7 + ((Name of Triggering player) + <Empty String>)))
    • Set Sound1[tempInt] = (Sound1[tempInt] + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Sound1 Less than or equal to 15
      • Then - Actions
        • Sound - Play Music[Sound1[tempInt]]
      • Else - Actions
        • Sound - Play Music[Sound1[tempInt]]
    • Set Sound1[(Player number of Triggering player)] = 1

The other triggers can be made more efficient like the above.

Also a Multiboard called Multiboard is to common of a name and must be changed.

 

[Lender]

these are all the same no difference in actions

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Owner of (Killing unit)) Equal to Player 4 (Purple)
  • Then - Actions
    • Multiboard - Set the text for Multiboard item in column 2, row 6 to (String(GlobalKills[2]))
  • Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Owner of (Killing unit)) Equal to Player 5 (Yellow)
  • Then - Actions
    • Multiboard - Set the text for Multiboard item in column 2, row 6 to (String(GlobalKills[2]))
  • Else - Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • (Owner of (Killing unit)) Equal to Player 6 (Orange)
  • Then - Actions
    • Multiboard - Set the text for Multiboard item in column 2, row 6 to (String(GlobalKills[2]))
  • Else - Actions

just do

• Multiboard - Set the text for Multiboard item in column 2, row 2 to (String(GlobalDeath[1]))
• Multiboard - Set the text for Multiboard item in column 2, row 6 to (String(GlobalDeath[2]))
• Multiboard - Set the text for Multiboard item in column 2, row 10 to (String(GlobalDeath[3]))

same for total kill

EDIT: I see u added the custm script line so u can remove these lines

• Multiboard - Set the display style for Multiboard item in column x, row y to Show text and Hide icons

all of it

 

[Vinz]

Interesting usefulness.