Custom spells not working (Jass)

[Meronia]

I'm re-writing this post because I noticed that... it's not understandable lmao
I downloaded a map with some spells. Everything works perfectly, tested it and runs well. I followed all the steps to implement them into my map and it's not working. It puts me to the lobby of WC3 instead of the map. I found out that any Jass/vJass trigger I put, it does the same thing. I am using JNGP. Is there anything maybe that I have to do to make my map work with Jass?

 

[Meronia]

I've checked whole code and it's not the code that's the problem. I have everything the same as in the attached map... and still it doesn't work. Just doesn't load the map - puts me to warcraft lobby

 

[Pyrogasm]

I am using JNGP.

Don't. There is literally no reason to do this. It's now many patches out of date (thus is missing new functionality), has been explicitly deprecated, and doesn't provide any reasonable functionality not in the editor now... except for //! external calls.

In the current WE: Trigger Editor menu bar > JASSHelper > Enable JASSHelper and Enable vJASS both need to be turned on (and are defaulted to off when you load this map, as well as any other wc3 map that hasn't had these flags manually set since Blizzard changed them to default to off instead). Doesn't seem like that's your problem because of the editor you're using, but a map that saves and then crashes in the loading screen sounds to me like a map whose script isn't actually getting compiled. I can open this map, change some stuff, save, and successfully launch it... so the issue is on your end whatever it is.

The issue could be the //! external objectmerger calls in the Objects trigger. These lines create all of the relevant abilities for you automatically when the script is saved/compiled the first time. //! external calls can no longer be made from the WE, so anything that relies on them to make stuff will fail. I honestly don't know how this interacts with JNGP now because presumably those were only ever active during script compilation.

 

[Meronia]

Welp that's bad. I guess I will try to somehow get this to work. I just don't understand why it doesn't run after 1. doing everything that should be done according to implementing guide and 2. Well everything looks the same on my map as it is on the attached one, that's the weirdest thing I have come across so far

And it's for sure not because of the //! external functions in the Objects trigger because I tried the other spell I downloaded and same issue. It acts just like it can't do any scripts that are made in Jass

I also thought that it may be something because of using JNGP but... well I can play it on the demo spell map

Edit: Tried WEX because it kind of has better functionality but still same issue, can't find where
Edit: I turned on some things and now I'm getting maaany syntax errors lmao

 

[Pyrogasm]

I also thought that it may be something because of using JNGP but... well I can play it on the demo spell map

JNGP has no connection to the actual game that is launched; it is only an extension to the editor (as is WEX). Once you launch the map it's using whatever your normal wc3 install is.

Edit: Tried WEX because it kind of has better functionality but still same issue, can't find where

I also would recommend you not to use WEX, UMSWE, HiveWE, SharpCraft, or Reinventing the Craft either for the same reasons you shouldn't use JNGP. You should just use the actual vanilla WE now. Update your game install to at least 1.30, if not a more recent patch. You can do so through Battle.net to get the most recent version (1.35), which does not require owning Reforged (I do not, just using my CD keys from the original games back in the day).

As I said I can open, mess with, save, and then run the map you put in this thread without any issues so the problem is with your editor if you can't do the same. You can always upload your actual map here to confirm I can save that, too. It's possible JASSHelper is disabled by default in the JNGP now (which you still shouldn't use), so you should at least check that it seems to be working.

Is your map set to Lua mode (should show in map description/options somewhere)? That would also present issues when trying to import/use JASS resources.