[Trigger] crop farm trigger

[Gallin]

well first of all i would like to thank everyone who will be as kind to help me
i need help in making a trigger that once a player builds a farm every 30 seconds or so about 3 crops spawn arond it that if they are killed u get more lumber

 

[Volvox]

The triggers should look like this.

variable rnd is a random real number array.

replace footman with your crop unit in both triggers.
change the raw values to your preferences.
you can control number of crops spawned, spawning area, spawning interval and lumber gained for kill.
I hope this helps, enjoy!

 

[Gallin]

ya welll thxs but i already got it before

 

[Volvox]

well that's good for you

 

[GhostWolf]

The problem is - it leaks.

I think that to remove the leaks it must use the "FirstOfGroup" action which is in JASS.

Just to give you basic guidence if you want to create it:

You pick all units of the type you want, you then select the "first unit" of the group with the "FirstOfGroup(groupName)", then you do your actions - set a location on him, set a new location at the place you want (a random place near him), then create there the crop, remove the location (or 2 if you used 2, if you do this in JASS you could use X,Y for the second one), you then remove the "first unit" from the group with the "GroupRemoveUnit(groupName,unit_you_want_to_be_removed)", and then you pick the next "first unit" of the group.

 

[Volvox]

everything in gui leaks and i'm still learning jass, i do what i can to help.

 

[GhostWolf]

I didn't say your trigger is bad, its actualy the best the GUI can offer in this situation.
I just noted that out since the probability of this trigger running a lot of times in the map is high (actualy it seems like it will... without any probability ^^), the maker should note that it leaks.

I take it as a rule that triggers that run more then one time should always be 100% non-leaking, so im sorry if I offended you in any way.

[offtopic] And just a tip, if you are trying to learn JASS through the normal WE, don't.
You can either use JassCraft or JNGP (Jass New Gen Pack = vJass), they are about x10000 usefull then the sucky WE lol.

 

[Volvox]

You didn't offend me and i'm learning jass trough jasscraft, thank you for offering help

 

[GhostWolf]

Actualy, I thought on this and also the "Random unit from group" can be used here via GUI. Here is the concerning trigger:

• Untitled Trigger 008
  • Events
    • Time - Every 30.00 seconds of game time
  • Conditions
  • Actions
    • Set Farms = (Units of type Footman)
    • For each (Integer A) from 1 to (Number of units in Farms), do (Actions)
      • Loop - Actions
        • Unit Group - Pick every unit in (Random 1 units from Farms) and do (Actions)
          • Loop - Actions
            • For each (Integer B) from 1 to (Random integer number between 1 and 3), do (Actions)
              • Loop - Actions
                • Set Point[0] = (Position of (Picked unit))
                • Set Point[1] = (Point[0] offset by (Random real number between 50.00 and 300.00) towards (Random real number between 0.00 and 359.00) degrees)
                • Unit - Create 1 Footman for Neutral Passive at Point[1] facing Default building facing degrees
                • Custom script: call RemoveLocation(udg_Point[0])
                • Custom script: call RemoveLocation(udg_Point[1])
            • Unit Group - Remove (Picked unit) from Farms
    • Custom script: call DestroyGroup(udg_Farms)

 

[Gallin]

does it matter anymore i got a trigger already form other person

 

[GhostWolf]

Yes it matters indeed. If this trigger runs every 30 seconds and you will have multiple farms, you're in big trouble if you leak.

 

[Volvox]

Read wyrmlord's tutorial about using local variables in gui. It's the most useful thing i found so far. It's in the help zone under triggers.

 

[GhostWolf]

The problem with that tutorial (well it isn't really the tut's fault) is that I don't think that anyone that reads it will actually understand what he reads.
I for one, read it (didn't even know what are locals back then) and I hardly understood what it does and how it helps.

Concerning this specific question, locals won't really help.
It has to use a group and use either the "GroupPickRandomUnit" or the "FirstOfGroup" actions.

 

[Volvox]

but locals can easily be destroyed just by assigning null to them.

 

[GhostWolf]

Are you talking about the points and group removing scripts I put there ? Also in JASS you need to put them, for example:

local group g = someGroup
// actions
call DestroyGroup(g)
set g = null

and

local location l = someWhere
local real x = GetLocationX(l)
local real y = GetLocationY(l)
call RemoveLocation(l)
set l = null

 

[Volvox]

Yeah that's what i was talking about.

 

[GhostWolf]

Be sure to remember you also need to remove them in JASS ! I always forget and then wonder why my code's lag ^^

 

[Volvox]

hehe... I keep forgetting stuff like 'set' and then my WE crashes. I used to work with visual basic where you could just write a = a + 1. Now i suffer

 

[GhostWolf]

If you are using JassCraft, don't write your code in the WE as it always crashes at unexpected times lol.
Just check your code with the Syntax Checker of JassCraft, it always find the problems ! (oh well... almost always lol).

The WE however... if you have 1 typing mistake it will suddenly report to you about 300+ other "wrong" things (yes, it did it to me tons of times...).

 

[Volvox]

That's exactly what i do, but i don't really see such errors. It says syntax error and i just can't get it untill my WE crashes. Then i get it...

 

[Gallin]

Omfg I Dont Even Need This Anymore

 

[Volvox]

Don't swear, some people might get offended. That is a wonderful way to say thank you.. Me and GhostWolf have spent some time thinking about how to help you...

 

[GhostWolf]

Gallin, I will repeat myself yet again.

If your trigger leaks locations (I.E - it doesn't use a group with a loop like I did), you are in big deep trouble.
Think about it like this - every 30 seconds, your map will leak 2x(number of farms) locations.
So, if you have 10 farms, it will leak 20 locations, if you have 100 farms, it will leak 200.
Since this trigger runs every 30 seconds... thats REALLY BAD !

You don't have to use my trigger, you can continue leaking, we tried to help you, now its your choice if you want to use that help or not, but atleast show us some gratitude please.


[backToNonTopic] what do you mean you don't get it ?

Syntax Errors are the "real" problems. If you have one, check it right away.
Usually they just come from forgetting to make a "call" before calling something, or giving too much/not as much as needed arguments into a function.

And are you using the JassCraft Syntax Checker ? because it sounds like you don't.

 

[Volvox]

(off topic) Now that's a funny part. I use JassCraft's syntax checker, i'm just too stupid to correct the syntax errors

 

[GhostWolf]

Lol, then fix them ^^

 

[Gallin]

what i mean is like at the begining i found A TRIGGER TO DO IT so then i said nvm i got it and then u contunied posting

 

[Volvox]

Yeah, well, that's because THAT F*** TRIGGER MAY BE LEAKING. Do you even know what a leak causes over time? Leak wastes your RAM and once your RAM is filled up, there are many unpleasant possible events. The best thing: It is gonna crash your warcraft. The worst thing: It's gonna crash your windows. Good thing is this is not permanent since RAM gets reset every time you turn your computer on. Bad thing is... Well how many people will be playing a map that keeps crashing their computer? None i think...

 

[Gallin]

the guy i got it form said he got it form his amp and he said it worked fine so i just used that one

 

[Volvox]

If it's checked, go ahead. There is nothing to lose anyway

 

[Gallin]

well then after u gave the trigger it just turned into a talk between u and ghostwolf

 

[Volvox]

True... Sorry...

 

[GhostWolf]

Can you please post your trigger ?

 

[Gallin]

well i just gave it to my friend that then put it in his map so right now i dont got the trigger

 

[GhostWolf]

Gave ? what, is it written on paper ? lol...

 

[Gallin]

um ya it acculy was i took a picture of it and emailed him it lol so it was written on paper

 

[GhostWolf]

If you emailed it, it wasn't deleted, it was COPIED and sent to him.
You still have the picture in your computer...

 

[GhostWolf]

Ok since it seems you are not going to show it lets say it like this - if it uses a Unit Group and removes units from the group - its fine, if it doesn't however, you will be wise to use my trigger that does those things.

 

[Gallin]

i delted it after i sent tho