Creep Respawn On Death

[Nazghul_Master]

Hello everyone,

I want to ask you people how to make a creep respawn within a certain area (for example if you got multiple areas with level 1-10, 10-20,20-30 creeps) after a certain time after its death (like ehh, 20 secs?) and so it will still drop certain items if I want too. So like the creep normally drops ehh lets say 5 gold, than after its respawned it will still drop 5 gold when he dies.

If there is already a post about this please link me, cause I couldnt find an appropiate one.

Yours sincerely,

Nazghul_Master

 

[Horn]

I could link you to several systems at Wc3c but it is down.

Here's one system you could use and adapt (based on johnfn's, used in my KNIGHTS map).

An initialisation trigger to store custom vars to units on the map:

function Trig_Init_Actions takes nothing returns nothing

   local unit p //will be used to loop through each of the creeps, along with
   local group g=GetUnitsOfPlayerAll(Player(PLAYER_NEUTRAL_AGGRESSIVE)) //this - the unit group of EACH creep (minus the ones already looped through, you'll see what I mean)
   local integer eachUnit=0 //and this - the number that represents each creep individually.

//init the creep structure
   loop
//this whole loop is the jass substitute for a For Each Unit In Group loop in GUI
         set p=FirstOfGroup(g) //sets p to the first unit in the group so that we can deal with it
         exitwhen (p==null) //if there are no more units, we're done with the loop so exit out of it
         set eachUnit = (eachUnit + 1) //but assuming there still are, increment the unit counter by one so it remains unique for the selected unit
         set udg_Location_of_monster[eachUnit] = GetUnitLoc(p) //set up 1 part of our array of locations corresponding to each unit
         set udg_Type_of_monster[eachUnit] = p //set up the array of creep types with the unit type of p
         call SetUnitUserData( p, eachUnit ) //set the custom value of the unit to eachUnit so that it is easily accessible later on

         call GroupRemoveUnit(g,p) //now that we've added it to the arrays, we don't need it in the group any more , so we get rid of it
    endloop    
    call DestroyGroup( g)
    set g = null

endfunction

//===========================================================================
function InitTrig_Init takes nothing returns nothing
    set gg_trg_Init = CreateTrigger(  )
    call TriggerRegisterTimerEventSingle( gg_trg_Init, 0.01 ) //run this trigger as the map initializes
    call TriggerAddAction( gg_trg_Init, function Trig_Init_Actions )
endfunction

And a trigger that is called when a unit dies:

function Trig_Respawn_Monster_Actions takes nothing returns nothing
    local integer dyingUnitsCV
set dyingUnitsCV = GetUnitUserData(GetDyingUnit())
    // Set here because if i just used custom value of the dying unit below the wait, it could be a different dying unit.
    call TriggerSleepAction( 60.00 ) // This wait could be as long as you want it to be before the creeps respawn.
    call CreateNUnitsAtLoc( 1, GetUnitTypeId(udg_Type_of_monster[dyingUnitsCV]), Player(PLAYER_NEUTRAL_AGGRESSIVE), udg_Location_of_monster[dyingUnitsCV], bj_UNIT_FACING )


    call SetUnitUserData( GetLastCreatedUnit(), dyingUnitsCV) //set the CV back to the unit because it's lost when the unit dies
endfunction

//===========================================================================
function InitTrig_Respawn_Monster takes nothing returns nothing
    set gg_trg_Respawn_Monster = CreateTrigger(  )
    call TriggerRegisterPlayerUnitEventSimple( gg_trg_Respawn_Monster, Player(PLAYER_NEUTRAL_AGGRESSIVE), EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( gg_trg_Respawn_Monster, function Trig_Respawn_Monster_Actions )
endfunction

Change the 60 to however long you want to wait (ie 20).
As for how much money they drop, you can define that in the unit editor for each units as normal.

 

[Nazghul_Master]

Do I just copy that in the trigger editor? Nothing to do elsewards? I just made my own little trigger which goes something like this:

P.S. I forgot how to trigger most parts, since I stopped triggering for some point, I was kinda advanced but at the point where I had to use variables I lost it and stopped. So that's why I kinda 'de-learned' triggering.

 

[Horn]

I can't read that.

 

[Nazghul_Master]

Check the attachment ^^ you CAN read that one hehe

 

[Horn]

That will nuke your game with lag.

If you copy the two triggers I posted into two triggers in your map, it shoud work fine.

Make 2 new triggers in your map. Convert them to custom text, then replace the text.

 

[Nazghul_Master]

So to make it clear I just got to copy what U just stated? And if so, how can I convert a trigger to custom text? Sorry that I sound noobish btw

P.S. could you maybe just make the trigger work ingame FOR me? I know it takes more time and if more people ask you got no spare time, but please? I seriously suck at triggers like that hehe

 

[paskovich]

That two-ine triggersucks bacause it revives the creep where it dies, and not where it originally "camps".

 

[Horn]

Wtf is 'two-ine' and no, it respawns at its original location. So gtfo.

 

[Nazghul_Master]

oke but can you please do it for me whitehorn?

 

[paskovich]

Two-line trigger:

• Wait x seconds
• Create unit at (Position of Triggering unit) ..

-> this will create the newest breed where the other died, and not where they should camp..

I wrote a script that does not require global variables, or multiple triggers, as it uses game cache (modified handle vars if you like..). Simply create a trigger called CreepRespawn, convert it to custom script, and replace the text you see there with this one. Then, set the respawn duration time in the second line of the script. You don't have to do anything else. It works flawlessly, i tested it.

Pros:
-Requires 1 trigger only
-Does not use global variables
-Does not uses the units' custom value
-Uses coordinates instead of locations --> leak free
-Revives creeps at their initial locations
-Also stores the initial facing of the creeps

Cons:
-I don't know if JASS would be a con, but some people don't like it

constant function CreepRespawnDelay takes nothing returns real
    return 20.0    //The respawn duration in seconds -- set this!
endfunction


//---Creep Respawn System---
function CR_H2I takes handle h returns integer
    return h
    return 0
endfunction

function SetCreepRespawnPoints takes nothing returns nothing
    local group g = CreateGroup()
    local unit u = null
    call GroupEnumUnitsOfPlayer(g,Player(12),null)
    loop
        set u = FirstOfGroup(g)
        call GroupRemoveUnit(g,u)
        exitwhen u == null
        call StoreReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnX", GetUnitX(u))
        call StoreReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnY", GetUnitY(u))
        call StoreReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnFacing", GetUnitFacing(u))
    endloop
    call DestroyGroup(g)
    set g = null
endfunction

function RespawnCreeps takes nothing returns nothing
    local unit u = GetTriggerUnit()
    local real x = GetStoredReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnX")
    local real y = GetStoredReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnY")
    local real f = GetStoredReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnFacing")
    call TriggerSleepAction(CreepRespawnDelay())
    set u = CreateUnit(Player(12), GetUnitTypeId(u), x, y, f)
    call StoreReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnX", x)
    call StoreReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnY", y)
    call StoreReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnFacing", f)
    set u = null
endfunction

//===========================================================================
function InitTrig_CreepRespawn takes nothing returns nothing
    call SetCreepRespawnPoints()
    set gg_trg_CreepRespawn = CreateTrigger()
    call TriggerRegisterPlayerUnitEvent(gg_trg_CreepRespawn, Player(12), EVENT_PLAYER_UNIT_DEATH, null)
    call TriggerAddAction(gg_trg_CreepRespawn, function RespawnCreeps)
endfunction

 

[Horn]

The guy can't even copy some text into a trigger

 

[paskovich]

So to make it clear I just got to copy what U just stated? And if so, how can I convert a trigger to custom text? Sorry that I sound noobish btw

OK i see... Create a trigger, rename it FIRST, then go to one of the menus (i can't remember which), and click "Convert to custom text". Delete the text you see there, and paste my script into the blank field. Fair enough??

 

[Nazghul_Master]

The guy can't even copy some text into a trigger

yes I CAN ^^ but I'm curious what I got to change, like what unit will spawn from grave hehe

btw, ur a genious paskovich! ty

btw, dude, ur trigger shows error in my map

btw, am I supposed to remove all the green text?

 

[Nazghul_Master]

(sorry for double posting but I had to to show the post)

In the attachment you can see what error I get, but for people who cant read it:

Line 81: Expected a variable name
Line 82: Expected a name
Line 83: Expected a name

 

[paskovich]

As i said
NAME IT CreepRespawn, not Creep Respawn or Creep Respawning!!

CreepRespawn
Creep Respawn

You see the difference??

 

[Horn]

Simply create a trigger called CreepRespawn

EDIT: d'oh, you posted it.

 

[Nazghul_Master]

oke... your trigger works fine for 1 time... buit the second tiem you kill ythem they exponentionally grow in number, maybe you can fix it...

 

[paskovich]

I don't really understand what you wrote..

So you want more and more creeps to spawn or what? But why couldn't you mention that before???
Write details...

 

[Nazghul_Master]

I dont want it! I just want it to happen when I see a creep, I attack him, and he walks from his 'start point' towards me, and I kill him, he gets respawned at his original start point. With your trigger tht works fine, but for some reason it summons 'extra units' aswell! So it wont only summon the unit on his original start point, it will summon extra units TOO! It's not like this:

Unit dies - wait X seconds - respawn it at start point - Unit dies - wait x seconds etc.

but its more like

Unit dies - wait X seconds - respawn it at start point - Unit dies - wait x seconds - respawn it a start point + spawn 2 extra units

So I think there is something wrong with your JASS

EDIT: sorry, I forgot to remove my ollder version :$

 

[Horn]

I'm eager to see your finished map

 

[Nazghul_Master]

^^ is that a request to join the beta? join the queue! just kidding hehe

 

[paskovich]

EDIT: sorry, I forgot to remove my ollder version :$

Oh come on! You can't be that nut.. :S

 

[Nazghul_Master]

dude, I ment the version with the creep respawns on death spot I saved that trigger in case that urs wasnt gonna work hehe

 

[Nazghul_Master]

(again sorry for double posting but I think it might be in the best interest for everyone)

Maybe it would be smart to sticky this one? I mean it's a very usefull trigger and might help others aswell?

 

[paskovich]

I'm gonna put all "creep-systems" into a map, and upload it to the resource section. Or I'll write a tutorial. No.. i don't have time for that

Gonna upload a map.
It will include:
-creep respawn
-creep item-drop
-...what else should i put in?

 

[johannesr]

paskovich ur trigger crashed WE and i lost most of the work i did on the map today! thanks alot

 

[paskovich]

My trigger works. What do you think, i uploaded a WE-crashing trigger just to disturb you? It's not my problem that you cannot implement it. Is it really that hard? Just for the noobs:
-Create a trigger
-Rename it to CreepRespawn
-Convert it to custom text
-Replace everything with my script
4 steps man.. Don't attack me because you can't do that.
Also, learn to use the save button!

 

[johannesr]

I did all that and it crashed WE. And sorry for attacking u, i was angry at the moment.

 

[jak]

Well im having a problem. i take your script and put in a trigger that was changed to custom script, but every time i try to save it keeps telling me that i have errors. so i ignor that and just go on to testing the map. Yet another problem arises. I cant PLAY the MAP!!
do you know what might be causing these problems?

 

[paskovich]

How could I help if you don't even write what error message it displays?

Did you
1. Create a trigger
2. Rename it to CreepRespawn
3. Convert it to custom text
4. Replace everything with my script??

But here is the newest and best version of the respawn system.

 

[jak]

Well srry bout that, and here are the errors i get.

expected end of line:

loop set u = FirstOfGroup(g)



Unexpected exit when:
call StoreReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnX", GetUnitX(u))


Expected a code statement:

call StoreReal(InitGameCache("CR"), I2S(CR_H2I(u)), "RespawnX", GetUnitX(u))


expected a code expression:

set u = null endfunction

expected end of line:

call SetCreepRespawnPoints() set gg_trg_CreepRespawn = CreateTrigger()


expected a function name:

call InitTrig_CreepRespawn( )





by the way i used the creep system you attached to the other post and it work just fine so thank you for that.

 

[YoshiRyu]

not the same: (end of line required after loop)

loop set u = FirstOfGroup(g)

    loop
        set u = FirstOfGroup(g)

not the same: (end of line required before endfunction)

set u = null endfunction

    set g = null
endfunction

not the same: (you've understand that return aren't randomly use now i think)

call SetCreepRespawnPoints() set gg_trg_CreepRespawn = CreateTrigger()

    call SetCreepRespawnPoints()
    set gg_trg_CreepRespawn = CreateTrigger()

and these point can maybe fix other ones!
first try this

 

[M_reaper]

This Works!

Thanks, Paskovich!
I've been looking for a working Creep Respawn trigger for a long time, and now I finaly have one that doesn't slow my map down like it takes half a minute for a second to pass (I have made one myself for a map, but all creeps respawn at the same time, and it took a LOT of patience to do. This I can use on any map). If you come up with a good trigger for level-based respawning (i.e a level one creep respawns in X seconds, a level 2 creep in 2X seconds, a level 3 creep in 3X seconds and so on), then post it here!