Couter bash 1.3

[Moderator]

Approved

A basic knockback retaliation spell that could benefit from additional polishing.

Suggested changes

• The knockback speed could diminish over time
• Instead of pausing the unit, check that the unit is not already in the knockback group
  Spells should not really pause units
  You can also try to stun them instead
• Add the bash chance to the tooltip
• Disabled version of the icon is missing
• The research icon should not be the passive version of the icon
• You could use tree detection system, if BOOM = true it will destroy brisges also for example

Old reviews

Required changes

• Disabled icon is missing, passive abilities should have passive version of icons
• In importing instructions you must mention that the ability used in cast trigger must be configured manually
  For both the condition and the distance
• You need to flush child hashtable when the spell ends. Hashtable - clear child hashtable of picked unit

Suggested changes

• Instead of pausing the unit, check that the unit is not already in the knockback group
• Add the bash chance to the tooltip
• You could use tree detection system

Required changes

• Learn tooltip icon is missing
• In importing instructions you must mention that the ability used in the
  condition in A unit is attacked trigger must be configured manually
• Set loop initially off
• Move unit instantly action has a location leak
• You're setting position of picked unit twice in the looping trigger, set it only once
• You need to flush child hashtable
• Units can end up with their collision turned off after the spell is over
• After moving a unit instantly, the unit can targets nearby enemies. Thus if the bash chance is high, the unit can be caught in a loop. You can push your enemy across the map this way

Suggested changes

• Mention the hotkey in tooltip, add the chance to the tooltip
• Change 0.04 to 0.03. 0.04 is not smooth. The knocback could use diminishing speed to make it look better
• You could use tree detection system
• Don't load distance and angle if time < 0
• Abil level >= 1 condition is not needed, the other condition covers that

 

[maddeem]

you should use

call SetUnitX(udg_u,udg_real1)
call SetUnitY(udg_u,udg_real2)

u being the unit
Reals are the converted cords of ur point you move the units.
This would allow many units to be knocked back at the same time with little or no delay.

OR

Use a knockback system
Because atm ur system kills more then trees.

 

[Chaosy]

@maddeem yeah did not think of that i will see what i can do about that

@maker thanks for all those tips i will fix all i can shortly

 

[Magtheridon96]

• -------- THIS ACTION IS NOT NEEDED! --------
• Hero - Learn skill for Paladin 0002 <gen>: |cffff0000Counter bash|r

Then put it in a different trigger

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • CB_BOOOM Equal to True
  • Then - Actions
    • Unit - Turn collision for (Picked unit) Off
  • Else - Actions

I think you mean "On".

 

[Chaosy]

fixed a few things.
-collision is now on again after the knockback is over
-learn skill action is in another trigger
-loop is initally off
-loop speed is changed to 0.03
-temploc is only set once in loop trigger
-removed one condition in the cast trigger
-added the learn hotkey in the learn desp
-location leak should be fixed (i think)
-unit is now paused to avoid attacking during the knock back
-animation speed reduce removed

more will be added but its all for now. will edit this post

 

[Magtheridon96]

• Set CB_distance = (CB_distance_setup[(Level of |cffff0000Counter bash|r for CB_defender)] x 0.04)

You meant 0.03 right?

Also, this leaks:

• Set CB_temploc = ((Position of (Picked unit)) offset by CB_distance towards CB_angle degrees)

You need two locations:

• Set CB_temploc1 = (Position of (Picked unit))
• Set CB_temploc2 = CB_temploc1 offset by CB_distance towards CB_angle degrees

Also, instead of constantly repeating that (Picked unit) call, you could store the picked unit into a unit
variable and use that variable to increase efficiency.

edit
You can do the same for Key(Picked unit), Key(Attacking unit), (Attacking unit), etc..
You can do it for ANYTHING that is used more than once

 

[Chaosy]

thanks magtheridon96 i get working at once

edit done rep+ for your help

edit 2; the new version 1.3 should be ready for approval now

 

[Chaosy]

Long overdue update.
Noticed hive 2.0 fucked up the name of the spell.

Added some extra configuration
Added knockback effect

 

[yram44]

Wow 1 of your long time spell. Finally updated I will try it tomorrow!

 

[KaiZen7th]

I found 2 issues: 1. Units are being knockbacked through doodads & terrain. 2. Range attackers & Building attackers are also able to be knockbacked. And it is inappropriate, don't you think? What if I want my hero only bash counters melee attackers? And what if I want units who were pushed back to be stunned if they hit a doodads?

How should I modify your spell?

 

[Pyrogasm]

Range attackers & Building attackers are also able to be knockbacked.

You can add any conditions you want to the "cast" trigger, using the attacked/attacking units and anything else.

I want units who were pushed back to be stunned if they hit a doodads?

The part of the "loop" trigger that kills destructibles can be used to stun the unit being moved. I would dummy cast an invisible, quick storm bolt at the moved unit.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • CB_BOOOM Equal to True
  • Then - Actions
    • Destructible - Pick every destructible within 100.00 of CB_temploc_2 and do (Actions)
      • Loop - Actions
        • Destructible - Kill (Picked destructible)
  • Else - Actions

Changed to:

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • CB_BOOOM Equal to True
  • Then - Actions
    • Set TempBool = False
    • Destructible - Pick every destructible within 100.00 of CB_temploc_2 and do (Actions)
      • Loop - Actions
        • Destructible - Kill (Picked destructible)
        • Set TempBool = True
    • If - Conditions
      • TempBool Equal to True
    • Then - Actions
      • Set TempPoint = (Position of CB_temp_unit)
      • Unit - Create 1 DUMMY CASTER for (Owner of CB_temp_unit) at TempPoint facing Default building facing degrees
      • Unit - Add STORM BOLT ABILITY to (Last created unit)
      • Unit - Add a 1.00 second generic expiration timer to (Last created unit)
      • Unit - Order (Last created unit) to Human Mountain King - Storm Bolt CB_temp_unit
    • Else - Actions
  • Else - Actions

In my opinion, the cast trigger has a shitty event; A Unit is Attacked sucks and can be abused. Instead you want to use a damage detection system that can tell you when a unit did an attack. This one I would recommend can differentiate between a melee attack and a ranged attack, or if damage was caused by an ability or by code ordering the unit to deal damage. You would then need to change the following lines in the cast trigger:

• Events
  • Game - DamageEvent becomes Less than or equal to 0.00 //runs only for melee attacks
• Conditions
  • (DamageEventSource is a Building) equal to False //if you want it not to work for structures either
  • (Level of COUNTER BASH ABILITY for DamageEventTarget) greater than 0 //this line isn't in the spell but it should be so that this only triggers for units that have the counter bash ability
• Actions
  • Set CB_defender = DamageEventTarget //change these two lines
  • Set CB_attacker = DamageEventSource

 

[KaiZen7th]

You can add any conditions you want to the "cast" trigger, using the attacked/attacking units and anything else.

Hey @Pyrogasm , I don't know how to limit it to only ground units. I'm an Artist not IT, so it's unfamiliar to me.

 

[Pyrogasm]

In the "cast" trigger you would add conditions like this (triggering unit is the attacked unit, in that trigger):

• Conditions
  • ((Triggering unit) is A flying unit) Equal to False
  • ((Triggering unit) is A structure) Equal to False

 

[KaiZen7th]

In the "cast" trigger you would add conditions like this (triggering unit is the attacked unit, in that trigger):

• Conditions
  • ((Triggering unit) is A flying unit) Equal to False
  • ((Triggering unit) is A structure) Equal to False

Hi, thank you for your helps. Are those conditions only available from 1.32 and above?

 

[Pyrogasm]

No, they are boolean comparisons, which you can tell because they compare "Equal to False". False is a boolean, therefore it's a boolean comparison.

 

[KaiZen7th]

No, they are boolean comparisons, which you can tell because they compare "Equal to False". False is a boolean, therefore it's a boolean comparison.

And which condition is that (image)?

 

[Pyrogasm]

Think about it. You are trying to stop the knockback from occurring at all when the attacked unit is of those types. That would be filtering them out at the trigger conditions level because nothing should happen unless the target isn't a building/flyer.

 

[KaiZen7th]

Think about it. You are trying to stop the knockback from occurring at all when the attacked unit is of those types. That would be filtering them out at the trigger conditions level because nothing should happen unless the target isn't a building/flyer.

I did it, thanks for your guidance and patience!