Corruption (v1.3)

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Corruption (v1.3) | Reviewed by Maker | 17th Aug 2013

NEEDS FIX

You should add importing instructions. The ability requires one to import 24 objects which is kind of much. If you relied more on triggering, it would help a lot.

[tr][td]

 

[Losam]

Well, I'll test it as soon as possible and I will do complete analysis of your work.
But post the triggers of his spell and put a more concise name (example: Corruption (v1.0) and dowload, you can put: Corruption by TheWickedWitch)
Are my suggestions..

 

[TheWickedWitch]

Thank you. But I havent thought of a cool name for this spell. The trigger is very simple, it is too embarassing

 

[Losam]

Thank you. But I havent thought of a cool name for this spell. The trigger is very simple, it is too embarassing

Anytime. If you need help, tell me (do whatever possible).
See examples of my work (both recent).
: D

 

[TheWickedWitch]

Thanks you for your help. Did I do good?

 

[Magtheridon96]

Next time, be sure to put your triggers between [trigger][/trigger] tags.

(I edited the description for you. Note: I also put them inside [hidden][/hidden] tags.)

 

[TheWickedWitch]

Thanks for editting and for the info. I didnt know about those tags. But I'll make sure ill use that if I get a chance to post again in the hive

 

[Chaosy]

I got the best suggestion ever!
create a spell with only triggers.

because anyone can do this in a matter of minutes.

object editor spells are not even allowed if you had read the rules

 

[TheWickedWitch]

I've read the rules, nothing is said about the spells should be triggered. Please show me the complete rules, I must have missed something. Chaosy, in my opinion, making spells should be practical. Yes, I can make this using triggers, but it will only complicate the process. Plus, trigger are more prone to errors. Thanks for you comment though

 

[Tank-Commander]

triggers aren't prone to errors, if done correctly. While there have been approved non-triggered resources (I think it was 1?) it was exceptionally good, this, not so much, in your triggers you should be using (triggering unit) instead of (dying unit) and you leak a location

 

[TheWickedWitch]

Yes, I saw that entry. It was the holy spell pack if I remember it right. And yes, the location leaks. Can you show me the script for removing location? Im not familiar with the custom script. I have a question though, why do you have to make it a trigger version when most parts can be done in the object editor? Is it because you are saving file size? and Triggering this would use less dummy units. I guess you dont like the concept. Thanks for looking at my work though

 

[Tank-Commander]

call RemoveLocation(location) is the custom script line for removing locations. The reason we trigger most or all our work if we can, is because it's a lot more configurable, has a lot more merit to it, and yes lower filesize, fewer dummy units (normally 1 for an entire spell or system) and generally because we like advanced things here, basic stuff has to be -perfect- to be approved

 

[TheWickedWitch]

Finally, the custom script. Thank you so much. I'm gonna fix it. Anyway, think of it that what I've submitted here is not the way I built the structure of the spell's trigger. Mainly bacause it doesn't have a trigger. What I've done here is the concept of the spell. I'll think of a new concept and hopefully do it using triggers. Can I ask one more thing? Can you show me the complete set of rules when uploading spells or other stuffs. I've read the rules, but I think there are some rules that I am not aware of. Thanks so much.

 

[Daffa]

• Unit - Create 1 Remover for (Owner of (Dying unit)) at (Position of (Dying unit)) facing (Facing of (Dying unit)) degrees

Leaks.
set a variable to it then destroy the point using Call RemoveLocation(udg_PointVariable)//Replace PointVariable with your point variable

basic stuff has to be -perfect- to be approved

Perfection

 

[TheWickedWitch]

The trigger has been updated. Thank you guys for all your help.

Why is there a word "Pending" ?? how do i remove it?

 

[Squiggy]

First off, you have to set the variable to Position of (Dying unit)
Then you do the action and THEN you remove the location.

 

[deathismyfriend]

is that the full spell ?
if u updated it in ur map plz update it on this page so everyone can help.

like everyone said dont use dying unit use triggering unit. u leak a location / point.
anything u use twice or more store it into a temp variable and use that. example: store last created unit into a temp unit variable.

 

[13oot-Me]

Looks good, but I would make the changes as deathismyfriend has said. Also, I don't remember if anyone told you to create a variable for things that are used more than once like triggering unit, so I did that too. Other than those things it works great!

Changes?

• Corruption Remove
  • Events
  • Unit - A unit Dies
  • Conditions
  • Actions
    • Set TempUnit = Triggering Unit
    • If - Conditions
      • Or - Any (Conditions) are true
        • (Unit-type of (TempUnit)) Equal to Corruption (Level 2)
        • (Unit-type of (TempUnit)) Equal to Corruption (Level 3)
        • (Unit-type of (TempUnit)) Equal to Corruption (Level 4)
        • (Unit-type of (TempUnit)) Equal to Corruption (Level 1)
    • Then - Actions
      • Unit - Create 1 Remover for (Owner of (TempUnit)) at (Position of (TempUnit) facing (Facing of (TempUnit)) degrees
      • Set RemovePoint = (Position of (Last created unit))
      • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
      • Custom script: call RemoveLocation(udg_RemovePoint)
    • Else - Actions

 

[deathismyfriend]

this is still pretty bad 13oot-me
this can be stored to a temp unit type

• (Unit-type of (TempUnit))

this leaks

• Unit - Create 1 Remover for (Owner of (TempUnit)) at (Position of (TempUnit) facing (Facing of (TempUnit)) degrees

this still leaks also.

• Set RemovePoint = (Position of (Last created unit))
• Custom script: call RemoveLocation(udg_RemovePoint)

this

• Corruption Remove
  • Events
  • Unit - A unit Dies
  • Conditions
  • Actions
    • Set TempUnit = Triggering Unit
    • If - Conditions
      • Or - Any (Conditions) are true
        • (Unit-type of (TempUnit)) Equal to Corruption (Level 2)
        • (Unit-type of (TempUnit)) Equal to Corruption (Level 3)
        • (Unit-type of (TempUnit)) Equal to Corruption (Level 4)
        • (Unit-type of (TempUnit)) Equal to Corruption (Level 1)
    • Then - Actions
      • Unit - Create 1 Remover for (Owner of (TempUnit)) at (Position of (TempUnit) facing (Facing of (TempUnit)) degrees
      • Set RemovePoint = (Position of (Last created unit))
      • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
      • Custom script: call RemoveLocation(udg_RemovePoint)
    • Else - Actions

should be like this

• Corruption Remove
  • Events
  • Unit - A unit Dies
  • Conditions
  • Actions
    • Set tempUnit = Triggering Unit
    • Set tempUnitType = (Unit-type of (tempUnit))
    • If - Conditions
      • Or - Any (Conditions) are true
        • tempUnitType Equal to Corruption (Level 2)
        • tempUnitType Equal to Corruption (Level 3)
        • tempUnitType Equal to Corruption (Level 4)
        • tempUnitType Equal to Corruption (Level 1)
    • Then - Actions
      • Set tempPoint = (Position of (tempUnit))
      • Unit - Create 1 Remover for (Owner of (tempUnit)) at tempPoint facing (Facing of (tempUnit)) degrees
      • Unit - Add a 1.00 second Generic expiration timer to (Last created unit)
      • Custom script: call RemoveLocation(udg_tempPoint)
    • Else - Actions

i also used the proper naming in the fixes

 

[Magtheridon96]

^ Even better:

(Owner of (tempUnit)) -> (Triggering player)

 

[Daffa]

U guys really argue for perfection

Why is there a word "Pending" ?? how do i remove it?

it remains until Mod approve or reject/needs fix your resources, an approved spell don't have tags and a rejected/needs fix have their respective tag on the spell.

 

[13oot-Me]

^ Even better:

(Owner of (tempUnit)) -> (Triggering player)

I thought you were only able to use 'triggering player' with player events, not unit events?

 

[Magtheridon96]

You can use it for everything except for region-enter events and maybe a few other things I don't know of.

 

[deathismyfriend]

this

• Untitled Trigger 002
  • Events
    • Unit - A unit Dies
  • Conditions
  • Actions

converts to this. notice the event player unit death. that is a player event so triggering player can be used.

function Trig_Untitled_Trigger_002_Actions takes nothing returns nothing
endfunction

//===========================================================================
function InitTrig_Untitled_Trigger_002 takes nothing returns nothing
    set gg_trg_Untitled_Trigger_002 = CreateTrigger(  )
    call TriggerRegisterAnyUnitEventBJ( gg_trg_Untitled_Trigger_002, EVENT_PLAYER_UNIT_DEATH )
    call TriggerAddAction( gg_trg_Untitled_Trigger_002, function Trig_Untitled_Trigger_002_Actions )
endfunction

 

[TheWickedWitch]

Thank you guys for helping me fix the leak. I did exactly as you instructed. By the way, how do you rate spells? Except for being triggered, what else are the criteria?

 

[deathismyfriend]

i normally dont rate them since i never see the spell in action i only look at the triggers.

this should be changed like magtheridon said

this

• (Owner of TempUnit)

should be this

• Triggering Player

 

[TheWickedWitch]

As you wish

EDIT: Done.
EDIT2: please do not rate this yet. im planning to update it. on the next update it will be a triggered version. thanks

 

[horden]

I like it