Mute (v1.3)

[Moderator]

14:18, 19th Aug 2013
PurgeandFire: Overall, the spell looks good. The only problem is in the periodic trigger. You check if the group is empty. It is not advisable to do that with periodic triggers since it'll enumerate the group all over just to check if it is empty. A better way is to have an integer to keep track of the number of units in your group. Every time you add a unit to the group, increase the counter by one. Every time you remove a unit from the group, decrease the counter by one. When the counter is 0 (no units in the group), then turn off the trigger.

Fix that, and it will be approvable!

 

[Losam]

[rainbow]Reserved[/rainbow]

 

[HaaG]

The spell seems to work fine,good job +rep.

 

[Losam]

Thank you very much for kindness. If you can, check my others resources.

 

[deathismyfriend]

change this.

• Set Mute_Target = (Picked unit)
• Set Mute_Handle = (Picked unit)

to this

• Set Mute_Target = (Picked unit)
• Set Mute_Handle = Mute_Target

anything u use twice or more store into a variable and use the variable. this is for speed and efficiency. example store this (Last created floating text) into a variable

store this (Key Mute_Handle) into a variable also.

for this do what i said above for the other one.

• -------- Target (or the affected opponent for Mute (Hero): --------
• Set Mute_Target = (Picked unit)
• -------- Load Target's Key: --------
• Set Mute_Handle = (Picked unit)

since the action happens no matter what in this trigger put it b4 or after the ITE

• Then - Actions
• -------- In case the trigger (Mute Loop) it is linked is not necessary call her again. --------
• Unit Group - Add Mute_Target to Mute_Unit_Group[1]
• Else - Actions
• Unit Group - Add Mute_Target to Mute_Unit_Group[1]
• Trigger - Turn on Mute Loop <gen>

u set this in the top of ur trigger.

• Set Mute_Handle = (Target unit of ability being cast)

u dont need to set it again at the bottom of the trigger.

change this to a non-arrayed variable. Mute_Unit_Group[1]
if u need a few groups for spells dont use arrays. dont use arrays unless needed.

 

[Losam]

All right. I will provide this spell, thank you for tips.

 

[deathismyfriend]

All right. I will provide this spell, thank you for tips.

np lol.

 

[Losam]

I do not understanding this:
since the action happens no matter what in this trigger put it b4 or after the ITE

What this: b4 and ITE?

 

[deathismyfriend]

b4 means before.
and ITE means if then else

 

[Losam]

Thank you again for kindness.
But I could not do this:

[trigger=]
Set Mute_Target = (Picked unit)
Set Mute_Handle = Mute_Target
[/trigger]

I did not find any option related.

 

[deathismyfriend]

sry i forgot u needed custom script for this. to do this u need custom script.

• Custom script: set udg_Mute_Handle = udg_Mute_Target

u can also use temp variables rather than creating more variables for the trigger.
like tempUnit / tempKey / tempHandle

store picked unit b4 the condition checking so u can use the variable in the condition block.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• ((Picked unit) belongs to an enemy of (Owner of Mute_Caster)) Equal to True
• ((Picked unit) is Magic Immune) Equal to False
• ((Picked unit) is an illusion) Equal to False
• ((Picked unit) is paused) Equal to False
• ((Picked unit) is hidden) Equal to False
• Then - Actions
• -------- --------------------------------------------- --------
• -------- Target (or the affected opponent for Mute (Hero): --------
• Set Mute_Target = (Picked unit)
• -------- Load Target's Key: --------
• Set Mute_Handle = (Picked unit)

 

[Losam]

Interesting. Can you tell me which script should I use to load custom keys? I remember of the SET udg_ get handle ... something.

 

[deathismyfriend]

not sure what u mean ?

use the custom script i said above to set the handle to the unit variable.

u can then use an integer to store the key of the handle like this.

• Set tempInt = ( key tempHandle)

u can skip both steps with another custom script.

just set the unit to the unit variable then set a temp integer to its key value like this.

• Set tempUnit = (Picked unit)
• Custom script: set udg_tempInt = GetHandleId( udg_tempUnit)

the tempInt is now the units key value so just use tempInt instead of using key of handle

 

[Losam]

not sure what u mean ?

use the custom script i said above to set the handle to the unit variable.

u can then use an integer to store the key of the handle like this.

• Set tempInt = ( key tempHandle)

u can skip both steps with another custom script.

just set the unit to the unit variable then set a temp integer to its key value like this.

• Set tempUnit = (Picked unit)
• Custom script: set udg_tempInt = GetHandleId( udg_tempUnit)

the tempInt is now the units key value so just use tempInt instead of using key of handle

Again, thanks for the tips, and no problem, we sometimes forget.

 

[deathismyfriend]

yup lol it happens to everyone.

 

[Losam]

Yeah, my spell has been up version
Sorry for my bad english