[Solved] Conversion problem

[RontoKing]

So, in my map I am mainly using chat commands.
Some of them require an integer to be typed in.
In the triggers the integers are being converted to strings so that I can use them as substrings.
The problem is that, if someone types in something that isn't an integer there the game instantly crashes on me which could be problematic in multiplayer.

So, how do I check if that substring can be converted or not before actually trying so that if it can't the program doesn't exit?

 

[Daffa]

The best way is to parse the lines first then check if the value is not an integer (it will return null when a character detected I believe).

 

[RontoKing]

How do I check if the value is not an integer? That's my problem...

 

[Arhowk]

loop through every character and make sure its either a -,0,1,2,3,4,5,6,7,8, or 9

 

[RontoKing]

Is that really the only way? :/

 

[Daffa]

Yes, since there's no other way, beside removing the commands.

 

[RontoKing]

OK, thanks, I guess.

 

[PurgeandFire]

Generally, checking if a string can be considered an integer is a two-step process:

(1) Try converting it to an integer. If it returns a number that is not 0, then it succeeded and you can use it. If it returned 0, then you must proceed to step 2.
(2) Loop through the characters and check if the characters are all 0 or a "." if you want to allow decimals. If they are something else, then it is not a number and you should ignore the command.

However, it shouldn't be causing a crash. You should post the trigger. Off the top of my head, I'm guessing you're using it as a player index. When passed an invalid player index, the game will instantly cause a crash (valid indexes are 1-16 in GUI, 0-15 in JASS). In your case, they may be passing something weird and it'll default to 0, which gets turned into Player(-1) in JASS, thus causing a crash. If you can, just ignore the commands that result in 0. If a "0" command is significant, then you'll have to do the check described in step (2) above.

 

[IcemanBo]

Set an variable Int to your substring. For example set Int = (substring 5, length of entered chat string)

Then you can compare with
Or Conditons:
Int=0
Int<0
Int>0

If it's not an integer no comparrison will match

 

[edo494]

Set an variable Int to your substring. For example set Int = (substring 5, length of entered chat string)

Then you can compare with
Or Conditons:
Int=0
Int<0
Int>0

If it's not an integer no comparrison will match

what? you cant perform string == integer in jass, and type returned by SubString is string, so Int must be string as well

 

[IcemanBo]

what? you cant perform string == integer in jass, and type returned by SubString is string, so Int must be string as well

You can convert it?

 

[edo494]

You can just very well do integer Int = S2I(SubString(string, firstCharPos, lastCharPos))
if Int == 0 then
//either 0 or is not integer
else if Int < 0 then
//negative
else if Int > 0 then
//positive
endif

 

[RontoKing]

Thanks everyone! It was a problem with player indexes like you guessed, PurgeandFire!
I made it so it only executes the action if the integer is greater than 0 and lesser than 16 and it seems to work!