Circle Impulse & Judgement MUI VI

[Moderator]

22:32, 16th Jun 2010
Hanky:
Very simple. But well, useful enough.

 

[Arisato]

Clear!

 

[TheGodEmperor]

Downloaded and tested it..
The spells are quite nice but i think the Judgement should look better cause it just looks like a really big Forked Lightning so maybe change that a little....
How? I dont really know sry....

The Second spell is REALLY nice i dont have found any problems...
It just looks great with that Water nova.

The map:
Pls fix that you can regen mana with esc, it doesnt work .. it just set the cooldown back and heal you but you dont get any mana.

 

[baassee]

Great, alot of leaks. No need to use arrayed variables as they are infact instant cast. Make a loop please to reduce the amount of code and fix the point leaks.

 

[D4RK_G4ND4LF]

fix the point leaks as baassee said
use loops instead of copy&pasting the same stupid part of code 20 times
why do you pause/unpause the caster/target?
terrain deformation lags hard on big maps with lots of doodads in multilayer
don't use unnecessary imports and give credits for ALL things you imported

edit:
omg....use a variable then lol
(for loop integer i from 0 to 6 do actions
set angle = convert integer to real(integer i) * 60.00
or something like that)

 

[Arisato]

Great, alot of leaks. No need to use arrayed variables as they are infact instant cast. Make a loop please to reduce the amount of code and fix the point leaks.

err... which leaks? please point out!

Hehehe..... sorry.... due to first custom spell with serious work.

Loop? for what?

fix the point leaks as baassee said
use loops instead of copy&pasting the same stupid part of code 20 times
why do you pause/unpause the caster/target?
terrain deformation lags hard on big maps with lots of doodads in multilayer
don't use unnecessary imports and give credits for ALL things you imported
Attached Thumbnails

ok then..............

EDIT: I aint copy pasting!!!! see the Degree! if i do loops, than the spell wont be able to do the circle

ok i'm gonna remove the custom model!

the terrains, doodad, im going to delete it

PS: Im not lagging when trying it!


Fixed
Leaks should be NO MORE!

EDIT3:

edit:
omg....use a variable then lol
(for loop integer i from 0 to 6 do actions
set angle = convert integer to real(integer i) * 60.00
or something like that)

huh?

put in trigger tags!!

looks good, and i think i understand it!

Gonna upload the V2 Version now!

 

[redscores]

You don't seem to understand a bit of what they said -.-.

 

[Arisato]

huh??

download it now V2!!

Fixed, using loops now!

 

[War_Golum]

Is too simple, I vote for rejection

 

[baassee]

Remove the arrays on the variables. It is not needed.

 

[Arisato]

Remove the arrays on the variables. It is not needed.

I just wanted to remain safe, using Arrays could have the 99.9% chance of no bugging in the spells


EDIT:
There are no more leaks,

Is too simple, I vote for rejection

Posted by War Golum

i know, thats why i want the newbies to download it so they would know what to do when they learn all of it!

 

[Thanathos]

Some tips and suggestions for improvement:

Chrone impulse

• The spell is MPI (Multi Player Instanceable), which won´t be accepted. Only fully MUI (Multi Unit Instanceable) spells are allowed.
• In case you want to stick to MPI then please save (Player number of (Owner of (Casting unit))) to an integer. That would make your code more readable.
• Your script runs instantly therefore pausing the caster and the target is obsolete. You should remove those actions.
• Use your own integer instead of Integer-A as stated above.
• You have point leaks in your loop. You need to remove CI_Point2 ad the end of the loop.

Judgment has the same flaws as Chrone Impulse, therefore i won´t bother to repeat myself. Further i´m missing proper documentation for this spell and as stated above the custom imports are more than just redundant, you may remove the fast before this gets rejected.

Please do not double post (you obviously know where the Edit-Button is) and don´t spam those smileys, its just awful.

~TNT

 

[Arisato]

Some tips and suggestions for improvement:

Chrone impulse

• The spell is MPI (Multi Player Instanceable), which won´t be accepted. Only fully MUI (Multi Unit Instanceable) spells are allowed.
• In case you want to stick to MPI then please save (Player number of (Owner of (Casting unit))) to an integer. That would make your code more readable.
• Your script runs instantly therefore pausing the caster and the target is obsolete. You should remove those actions.
• Use your own integer instead of Integer-A as stated above.
• You have point leaks in your loop. You need to remove CI_Point2 ad the end of the loop.

Judgment has the same flaws as Chrone Impulse, therefore i won´t bother to repeat myself. Further i´m missing proper documentation for this spell and as stated above the custom imports are more than just redundant, you may remove the fast before this gets rejected.

Please do not double post (you obviously know where the Edit-Button is) and don´t spam those smileys, its just awful.

~TNT

=-= look at the end of the loop!! no leaks!!


the spells are instant, so it is MUI not MPI(yes it is MPI if it HAS wait action!)

Okay, thanks for the tips, and it's not leaking, i'll use my own integer then, so it'll be nice to read by newbies on hive which is learning!


Does this leak??

Trigger

• Chrone Impulse
• Events
• Unit - A unit Starts the effect of an ability
• Conditions
• (Ability being cast) Equal to Circle Impulse
• Actions
• Set CI_Integer_Read = (Player number of (Owner of (Casting unit)))
• Set CI_Caster[CI_Integer_Read] = (Casting unit)
• Set CI_Target[CI_Integer_Read] = (Target unit of ability being cast)
• Set CI_Player[CI_Integer_Read] = (Owner of CI_Caster[(Player number of (Owner of (Casting unit)))])
• Set CI_Point = (Position of CI_Target[CI_Integer_Read])
• -------- Pause the units first! --------
• Unit - Pause CI_Caster[CI_Integer_Read]
• Unit - Pause CI_Target[CI_Integer_Read]
• -------- We aren't Damaging a thing, only the dummies do, so that's the idea , the eyecandy? look at it your self then ^^ --------
• -------- The Dummies are here AND the casting effects are all here!(Loops now!) --------
• For each (Integer A) from 1 to 7, do (Actions)
• Loop - Actions
• Set CI_Point2 = (CI_Point offset by 650.00 towards (51.42 x (Real((Integer A)))) degrees)
• Unit - Create 1 Spellcaster for CI_Player[CI_Integer_Read] at CI_Point2 facing (Position of CI_Target[CI_Integer_Read])
• Unit - Add a 1.50 second Generic expiration timer to (Last created unit)
• Unit - Add Water Impulse to (Last created unit)
• Unit - Set level of Water Impulse for (Last created unit) to (Level of Circle Impulse for CI_Caster[CI_Integer_Read])
• Unit - Order (Last created unit) to Orc Tauren Chieftain - Shockwave CI_Point
• -------- Unpause it --------
• Unit - Unpause CI_Caster[CI_Integer_Read]
• Unit - Unpause CI_Target[CI_Integer_Read]
• -------- Null it --------
• Custom script: call RemoveLocation( udg_CI_Point )
• Custom script: call RemoveLocation( udg_CI_Point2 )
• Set CI_Caster[CI_Integer_Read] = No unit
• Set CI_Target[CI_Integer_Read] = No unit

 

[Weep]

Your demo map uses icons that cause the Mac version of WC3 to freeze. Please remove or modify them.

 

[baassee]

So remove the arrays as you say, it is MUI then you dont need the arrays. (It is instant)

 

[Arisato]

So remove the arrays as you say, it is MUI then you dont need the arrays. (It is instant)

ok, i remove the arrays..

and i'll remove the custom thingies, sorry for the inconvenience o.o

EDIT: UPDATE!

 

[Septimus]

the spells are instant, so it is MUI not MPI(yes it is MPI if it HAS wait action!)

wait makes the spells neither mui and mpi.

 

[kola]

You have to remove the point used at the start of each loop at the end of the loop, not AFTER the loop, or, it will create 7 Points and u will only remove 1.

 

[Itachi009]

spells leak 6x location, when you set the location IN the loop trigger you have to remove the location IN the loop trigger, because else it will create 7 locations, but only remove 1
dunno about gui but you could set the global player to null (no player) as well

fix that

 

[ChaosKnight]

One leak :

• Set JM_Point2 = (JM_Point offset by 350.00 towards (120.00 x (Real((Integer A)))) degrees)

JM_POINT offset by 350 towards .. ...

 

[baassee]

One leak :

• Set JM_Point2 = (JM_Point offset by 350.00 towards (120.00 x (Real((Integer A)))) degrees)

JM_POINT offset by 350 towards .. ...

What, does not leak? He sets a new point. If it would leak it would have looked like "position of (something) offset by ..."

No need to null player variables?

 

[Arisato]

What, does not leak? He sets a new point. If it would leak it would have looked like "position of (something) offset by ..."

No need to null player variables?

Ill fix it tomorrow

 

[Ceday]

You don't need to null global variables.
Set *SomeUnitVariable* = No Unit
is not neccesary.

 

[Arisato]

Updated!

Look at the trigs!

EDIT: Please download,comment,rate! i really need some ideas!

 

[baassee]

Change casting unit to triggering unit, infact you dont really need this variable at all but alright keep it.

Remove the player variable as I find it pretty useless, just create the unit for the owner of triggering unit or your unit variable.

You need to preload the add ability effect as it intends to have first cast laggs.

Also please change shockwave dummy to carrion swarm as shockwave have some deformation + it laggs.

No need to set the last to variables to "No Unit"

 

[Arisato]

huh?

some people say , more variable more smooth!

PS: could you give me an IDEA to make it more eyecandied

 

[baassee]

theyre instant no need really

no idea

 

[Arisato]

approved yet??

oh yeah, terrain deformation doesn't lag with me!

it does + eyecandy!

EDIT: Yeah! Approved!! Well, i know it's simple , but for the newbies like me it's easy to implement ^^!

 

[tsiga]

Nice spells m8 5/5

 

[Arisato]

thanks!!, It's good for people to learn spells using loops!

 

[Shadowrek]

Yay no more leaks

 

[NewbieMapper]

Huh,whats with war_golum,this spell is very cool!!!

 

[Arisato]

Thanks guys for helping , this was my first spell or i should say first step towards MUI

 

[Oljin]

already used your spells long time ago in my RPG game (The Sword of Narzul) and now again my new map (The Black Clans War, AoS / MOBA). Great work, nicely done. nothing to complain - works perfectly.