[JASS] Cell Based Weather System

[Zeatherann]

So in the current map I'm making Infection The terrain is given a random heightmap, which certain tiles are placed onto it based on the elevation. This weather takes the average of the elevation in a cell (512x512) of terrain and picks a weather type based on the value. The below function is what creates the weather. It says it is working and picking the correct weather types, but it fails to actually create the weather (in game no weather is visible).

I generate weather after terrain.

function CreateWeather takes nothing returns nothing
    local real X=-udg_WorldSize
    local real Y=0
    local integer Index=0
    local integer Wait=0
    local integer ID=-1
    local integer Weather=udg_WeatherType[0]
    local integer Loop=0
    loop
        exitwhen X>=udg_WorldSize
        set Y=-udg_WorldSize
        loop
            exitwhen Y>=udg_WorldSize
            set ID=GetTerrainType(X+256,Y+256)
            set Loop=0
            loop
                exitwhen Loop>10
                if ID==udg_TileTypes[Loop]then
                    set Weather=udg_WeatherType[Loop]
                endif
                set Loop=Loop+1
            endloop
            call RemoveRect(udg_WeatherRects[Index])
            set udg_WeatherRects[Index]=null
            set udg_WeatherRects[Index]=Rect(X,Y,X+480,Y+480)
            call RemoveWeatherEffect(udg_Weathers[Index])
            set udg_Weathers[Index]=null
            set udg_Weathers[Index]=AddWeatherEffect(udg_WeatherRects[Index],Weather)
            call EnableWeatherEffect(udg_Weathers[Index],true)
            //Code
            set Index=Index+1
            set Wait=Wait+1
            if Wait>=10then
                set Wait=0
                call DisplayTextToPlayer(Player(0),0,0,"Weathering...")
                call TriggerSleepAction(0.25)
            endif
            set Y=Y+512
        endloop
        set X=X+512
    endloop
endfunction

PS: Assume all global variables are correctly set up.

 

[Halo7568]

Have not looked at your trigger, but came to drop some information regardless: in your game video settings, if the particle details are set to low, you might not see some weather effects.

 

[Zeatherann]

I realize this; I can view weather just fine and that setting is set to high. Thank you though, I've made stupid mistakes like that before.

 

[Halo7568]

Well I can tell you it might start working the first time at least for whatever reason if you make this change:

if (udg_Weathers[Index] != null) then
call RemoveWeatherEffect(udg_Weathers[Index])
endif

Well that is the only change I had to make copying the function over to a blank map with all the weather types and terrain types set to one value each.

 

[Dr Super Good]

I remember weather visuals being notoriously difficult to stack. Try making the cells bigger so you create fewer of them as there might be hard limits to the number of weather effects the engine can have active.

 

[Zeatherann]

True I might be reaching the limits of the engine, but not even one is showing up, I'll try the null check too.

PS: None of the cells overlap on the grid.

null check solved it, dunno why though.