[Trigger] Can you find me the leaks

[adishaireen]

Guys, i make this spell 2-3 days ago. but it is rejected. The moderator said that this spell has many leaks. can you tell me where is the leaks??The spell name is Flash Sword w/ Knockback. this is the trigger:

[trigger=Flash Sword Ability]
Flash Sword Ability
Events
Unit - A unit Is attacked
Conditions
(Level of Flash Sword for (Attacking unit)) Greater than 0
Actions
Set Caster = (Attacking unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Random integer number between 1 and 4) Equal to 1
Then - Actions
Set Target = (Attacked unit)
Set Angle = (Facing of Caster)
Animation - Play Caster's Attack Slam animation
Unit - Cause Caster to damage Target, dealing 900.00 damage of attack type Hero and damage type Lightning
Special Effect - Create a special effect at (Position of Target) using Abilities\Weapons\Bolt\BoltImpact.mdl
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at (Position of Target) using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Special Effect - Destroy (Last created special effect)
Unit - Turn collision for Target Off
Trigger - Turn off (This trigger)
Trigger - Turn on Flash Sword Knockback <gen>
If ((Level of Flash Sword for Caster) Greater than 0) then do (Wait 0.95 seconds) else do (Do nothing)
Trigger - Turn off Flash Sword Knockback <gen>
Unit - Turn collision for Target On
Trigger - Turn on (This trigger)
Else - Actions[/trigger]

[trigger=Flash Sword Knockback]
Flash Sword Knockback
Events
Time - Every 0.03 seconds of game time
Conditions
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain pathing at ((Position of Target) offset by 10.00 towards Angle degrees) of type Walkability is off) Equal to False
Then - Actions
Set Targt_Pos = (Position of Target)
Unit - Cause Caster to damage Target, dealing 10.00 damage of attack type Spells and damage type Lightning
Unit - Move Target instantly to (Targt_Pos offset by 5.00 towards Angle degrees)
Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\MirrorImage\MirrorImageDeathCaster.mdl
Special Effect - Destroy (Last created special effect)
Destructible - Pick every destructible within 105.00 of Targt_Pos and do (Destructible - Kill (Picked destructible))
Else - Actions
Custom script: call RemoveLocation(udg_Targt_Pos)[/trigger]

 

[Adiktuz]

All of this leaks:

(Position of Target)

this too

Targt_Pos offset by 5.00 towards Angle degrees

you should really look up on the Leak tutorial on the tuts section...

and oh, your spell is not MUI...

 

[Maker]

[trigger=Flash Sword Ability]
Flash Sword Ability
Events
Unit - A unit Is attacked
Conditions
(Level of Flash Sword for (Attacking unit)) Greater than 0
Actions
Set Caster = (Attacking unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Random integer number between 1 and 4) Equal to 1
Then - Actions
Set Target = (Attacked unit)
Set Angle = (Facing of Caster)
Animation - Play Caster's Attack Slam animation
Unit - Cause Caster to damage Target, dealing 900.00 damage of attack type Hero and damage type Lightning
Special Effect - Create a special effect at (Position of Target) using Abilities\Weapons\Bolt\BoltImpact.mdl
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at (Position of Target) using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Special Effect - Destroy (Last created special effect)
Unit - Turn collision for Target Off
Trigger - Turn off (This trigger) // Don't do this
Trigger - Turn on Flash Sword Knockback <gen>
If ((Level of Flash Sword for Caster) Greater than 0) then do (Wait 0.95 seconds) else do (Do nothing) // Remove this
Trigger - Turn off Flash Sword Knockback <gen> // Don't do this here
Unit - Turn collision for Target On
Trigger - Turn on (This trigger) // Remove this
Else - Actions[/trigger]

[trigger=Flash Sword Knockback]
Flash Sword Knockback
Events
Time - Every 0.03 seconds of game time
Conditions
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain pathing at ((Position of Target) offset by 10.00 towards Angle degrees) of type Walkability is off) Equal to False // Leaks two points
Then - Actions
Set Targt_Pos = (Position of Target)
Unit - Cause Caster to damage Target, dealing 10.00 damage of attack type Spells and damage type Lightning
Unit - Move Target instantly to (Targt_Pos offset by 5.00 towards Angle degrees)
Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\MirrorImage\MirrorImageDeathCaster.mdl
Special Effect - Destroy (Last created special effect)
Destructible - Pick every destructible within 105.00 of Targt_Pos and do (Destructible - Kill (Picked destructible))
Custom script: call RemoveLocation(udg_Targt_Pos)
Else - Actions
[/trigger]

Don't ever turn on/off the first trigger.
Turn off the looping trigger in the looping trigger.
I moved the call RemoveLocation in to the correct place.

 

[adishaireen]

like this???

[TRIGGER=Flash Sword Ability]
Flash Sword Ability
Events
Unit - A unit Is attacked
Conditions
(Level of Flash Sword for (Attacking unit)) Greater than 0
Actions
Set Caster = (Attacking unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Random integer number between 1 and 4) Equal to 1
Then - Actions
Set Target = (Attacked unit)
Set Angle = (Facing of Caster)
Animation - Play Caster's Attack Slam animation
Unit - Cause Caster to damage Target, dealing 900.00 damage of attack type Hero and damage type Lightning
Special Effect - Create a special effect at (Position of Target) using Abilities\Weapons\Bolt\BoltImpact.mdl
Special Effect - Destroy (Last created special effect)
Special Effect - Create a special effect at (Position of Target) using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Special Effect - Destroy (Last created special effect)
Unit - Turn collision for Target Off
Trigger - Turn on Flash Sword Knockback <gen>
If ((Level of Flash Sword for Caster) Greater than 0) then do (Wait 0.95 seconds) else do (Do nothing)
Trigger - Turn off Flash Sword Knockback <gen>
Unit - Turn collision for Target On
Else - Actions[/TRIGGER]

[TRIGGER=Flash Sword Knockback]
Flash Sword Knockback
Events
Time - Every 0.03 seconds of game time
Conditions
Actions
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain pathing at ((Position of Target) offset by 10.00 towards Angle degrees) of type Walkability is off) Equal to False
Then - Actions
Set Targt_Pos = (Position of Target)
Unit - Cause Caster to damage Target, dealing 10.00 damage of attack type Spells and damage type Lightning
Unit - Move Target instantly to (Targt_Pos offset by 5.00 towards Angle degrees)
Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\MirrorImage\MirrorImageDeathCaster.mdl
Special Effect - Destroy (Last created special effect)
Destructible - Pick every destructible within 105.00 of Targt_Pos and do (Destructible - Kill (Picked destructible))
Custom script: call RemoveLocation(udg_Targt_Pos)
Else - Actions[/TRIGGER]

 

[Adiktuz]

you still leak the projection point on the loop... and (Position of Target) at the first trigger...

 

[adishaireen]

you still leak the projection point on the loop... and (Position of Target) at the first trigger...

i've fix it like this:

[trigger=]
Flash Sword Ability
Events
Unit - A unit Is attacked
Conditions
(Level of Flash Sword for (Attacking unit)) Greater than 0
Actions
Set Caster = (Attacking unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Random integer number between 1 and 4) Equal to 1
Then - Actions
Set Target = (Attacked unit)
Set Angle = (Facing of Caster)
Animation - Play Caster's Attack Slam animation
Unit - Cause Caster to damage Target, dealing 900.00 damage of attack type Hero and damage type Lightning
Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Special Effect - Destroy (Last created special effect)
Unit - Turn collision for Target Off
Trigger - Turn on Flash Sword Knockback <gen>
If ((Level of Flash Sword for Caster) Greater than 0) then do (Wait 0.95 seconds) else do (Do nothing)
Trigger - Turn off Flash Sword Knockback <gen>
Unit - Turn collision for Target On
Else - Actions
[/trigger]

[trigger=]
Flash Sword Knockback
Events
Time - Every 0.03 seconds of game time
Conditions
Actions
Set Targt_Pos = (Position of Target)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain pathing at (Targt_Pos offset by 10.00 towards Angle degrees) of type Walkability is off) Equal to False
Then - Actions
Unit - Cause Caster to damage Target, dealing 10.00 damage of attack type Spells and damage type Lightning
Unit - Move Target instantly to (Targt_Pos offset by 5.00 towards Angle degrees)
Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\MirrorImage\MirrorImageDeathCaster.mdl
Special Effect - Destroy (Last created special effect)
Destructible - Pick every destructible within 105.00 of Targt_Pos and do (Destructible - Kill (Picked destructible))
Custom script: call RemoveLocation(udg_Targt_Pos)
Else - Actions
[/trigger]

 

[Adiktuz]

this has leaks:

Unit - Move Target instantly to (Targt_Pos offset by 5.00 towards Angle degrees)

you need to save the (Targt_Pos offset by 5.00 towards Angle) degrees to a point variable first then remove it via RemoveLocation since Polar Projection creates a new point...

 

[adishaireen]

this will be good...

[trigger=]
Flash Sword Knockback
Events
Time - Every 0.03 seconds of game time
Conditions
Actions
Set Targt_Pos = (Position of Target)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain pathing at (Targt_Pos offset by 10.00 towards Angle degrees) of type Walkability is off) Equal to False
Then - Actions
Set Pos_Tar_Offsts = (Targt_Pos offset by 5.00 towards Angle degrees)
Unit - Cause Caster to damage Target, dealing 10.00 damage of attack type Spells and damage type Lightning
Unit - Move Target instantly to Pos_Tar_Offsts
Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\MirrorImage\MirrorImageDeathCaster.mdl
Special Effect - Destroy (Last created special effect)
Destructible - Pick every destructible within 105.00 of Targt_Pos and do (Destructible - Kill (Picked destructible))
Custom script: call RemoveLocation(udg_Targt_Pos)
Else - Actions
[/trigger]

 

[Adiktuz]

you forgot to add a call RemoveLocation(udg_Pos_Tar_Offsts)

 

[Bribe]

The locations are removed improperly.

• Flash Sword Knockback
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • Set Targt_Pos = (Position of Target)
    • Set Pos_Tar_Offsts = (Targt_Pos offset by 5.00 towards Angle degrees)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Terrain pathing at Pos_Tar_Offsts of type Walkability is off) Equal to False
      • Then - Actions
        • Unit - Cause Caster to damage Target, dealing 10.00 damage of attack type Spells and damage type Lightning
        • Unit - Move Target instantly to Pos_Tar_Offsts
        • Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\MirrorImage\MirrorImageDeathCaster.mdl
        • Special Effect - Destroy (Last created special effect)
        • Destructible - Pick every destructible within 105.00 of Targt_Pos and do (Destructible - Kill (Picked destructible))
      • Else - Actions
    • Custom script: call RemoveLocation(udg_Targt_Pos)
    • Custom script: call RemoveLocation(udg_Targt_Pos_Offsts)

Edit: fixed yet another leak in this edit.

 

[adishaireen]

thanks...

the trigger is like this.....

[trigger=]
Flash Sword Knockback
Events
Time - Every 0.03 seconds of game time
Conditions
Actions
Set Targt_Pos = (Position of Target)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain pathing at (Targt_Pos offset by 10.00 towards Angle degrees) of type Walkability is off) Equal to False
Then - Actions
Set Pos_Tar_Offsts = (Targt_Pos offset by 5.00 towards Angle degrees)
Unit - Cause Caster to damage Target, dealing 10.00 damage of attack type Spells and damage type Lightning
Unit - Move Target instantly to Pos_Tar_Offsts
Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\MirrorImage\MirrorImageDeathCaster.mdl
Special Effect - Destroy (Last created special effect)
Destructible - Pick every destructible within 105.00 of Targt_Pos and do (Destructible - Kill (Picked destructible))
Custom script: call RemoveLocation(udg_Targt_Pos)
Else - Actions
Custom script: call RemoveLocation(udg_Pos_Tar_Offsts)
[/trigger]

 

[Bribe]

I updated my post to fix another leak I saw in there.

The leaks for this part are fixed (for now... just wait until you add more). Perhaps it's time to look at how to make this MUI now.

 

[defskull]

Haha, after all the hardwork making it "leakless", it's time for MUI
Ahahahahaa

 

[adishaireen]

this is good thing...

[trigger=]
Flash Sword Knockback
Events
Time - Every 0.03 seconds of game time
Conditions
Actions
Set Targt_Pos = (Position of Target)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain pathing at (Targt_Pos offset by 10.00 towards Angle degrees) of type Walkability is off) Equal to False
Then - Actions
Set Pos_Tar_Offsts = (Targt_Pos offset by 5.00 towards Angle degrees)
Unit - Cause Caster to damage Target, dealing 10.00 damage of attack type Spells and damage type Lightning
Unit - Move Target instantly to Pos_Tar_Offsts
Special Effect - Create a special effect attached to the origin of Target using Abilities\Spells\Orc\MirrorImage\MirrorImageDeathCaster.mdl
Special Effect - Destroy (Last created special effect)
Destructible - Pick every destructible within 105.00 of Targt_Pos and do (Destructible - Kill (Picked destructible))
Else - Actions
Custom script: call RemoveLocation(udg_Targt_Pos)
Custom script: call RemoveLocation(udg_Pos_Tar_Offsts)
[/trigger]

 

[Adiktuz]

Bribe's is better since your new trigger would leak the location used on the condition part...

 

[Bribe]

Haha, after all the hardwork making it "leakless", it's time for MUI
Ahahahahaa

You have to change the subject now and then. "No project is ever finished", so he will need some leak fixing, some MUI tutorials, something else, more leak fixing, etc., eventually he will get the hang of it if this is something he really wants to do.

 

[adishaireen]

thanks 4 you guys...

and how to change subject???

and plz un-reject my spell

 

[Bribe]

It will not be "un-rejected" as it is not MUI.

 

[adishaireen]

so, you mean i need to re-upload my spell??

 

[Adiktuz]

nope, he means that your spell is still unacceptable... you just managed to make it leakless but it is far from being MUI (multi-unit instanceable) which means that multiple units can use it at almost the same without bugs... and with your current trigger set-up, it would bug if more than one unit uses it...

 

[adishaireen]

so...what i'm gonna do???

 

[Adiktuz]

try to look at tutorials at the tuts section for MUI... and for this kind of spells, you would need a good indexing...

 

[adishaireen]

hey, where can i find the indexing tutorials???

the exact website

 

[Adiktuz]

on the TUTORIALS section of The Hive...

 

[adishaireen]

websites???

 

[Bribe]

Are you taking a piss? "The Hive" does not ring any bells of a specific web site?

 

[Adiktuz]

have even tried to click every single link on the top portion of The Hive?

 

[adishaireen]

yeah...but i've found a knockback tutorial...check that out in:

http://www.hiveworkshop.com/forums/...279/multi-instancible-gui-spell-making-34393/

 

[adishaireen]

hey, i have finished my spell with index....like this:

[trigger=]
Flash Sword Ability
Events
Unit - A unit Is attacked
Conditions
(Level of Flash Sword for (Attacking unit)) Greater than 0
Actions
Set Caster_n_Target[1] = (Attacking unit)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Random integer number between 1 and 4) Equal to 1
Then - Actions
Set Angle = (Facing of Caster_n_Target[1])
Set Caster_n_Target[2] = (Attacked unit)
Animation - Play Caster_n_Target[1]'s attack walk stand spin animation
Unit - Cause Caster_n_Target[1] to damage Caster_n_Target[2], dealing 900.00 damage of attack type Hero and damage type Lightning
Special Effect - Create a special effect attached to the origin of Caster_n_Target[2] using Abilities\Spells\Other\Monsoon\MonsoonBoltTarget.mdl
Special Effect - Destroy (Last created special effect)
Unit - Turn collision for Caster_n_Target[2] Off
Trigger - Turn on Flash Sword Knockback <gen>
Special Effect - Create a special effect attached to the weapon of Caster_n_Target[1] using Abilities\Weapons\Bolt\BoltImpact.mdl
If ((Level of Flash Sword for Caster_n_Target[1]) Equal to 1) then do (Wait 0.95 seconds) else do (Do nothing)
Trigger - Turn off Flash Sword Knockback <gen>
Unit - Turn collision for Caster_n_Target[2] On
Special Effect - Destroy (Last created special effect)
Else - Actions
[/trigger]

[trigger=]
Flash Sword Knockback
Events
Time - Every 0.03 seconds of game time
Conditions
Actions
Set Point[1] = (Position of Caster_n_Target[2])
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
(Terrain pathing at (Point[1] offset by 500.00 towards Angle degrees) of type Walkability is off) Equal to False
Then - Actions
Set Point[2] = (Point[1] offset by 5.00 towards Angle degrees)
Unit - Cause Caster_n_Target[1] to damage Caster_n_Target[2], dealing 10.00 damage of attack type Spells and damage type Lightning
Unit - Move Caster_n_Target[2] instantly to Point[2]
Special Effect - Create a special effect attached to the origin of Caster_n_Target[2] using Abilities\Spells\Orc\MirrorImage\MirrorImageDeathCaster.mdl
Special Effect - Destroy (Last created special effect)
Destructible - Pick every destructible within 105.00 of Point[1] and do (Destructible - Kill (Picked destructible))
Else - Actions
Custom script: call RemoveLocation(udg_Point[2])
Custom script: call RemoveLocation(udg_Point[1])
[/trigger]

 

[Adiktuz]

Huh? its far from being MUI...

look at other spells on the spells section and look on how they done indexing...

 

[adishaireen]

wait, is passive skill same as MUI??

 

[Adiktuz]

it depends... MUI means that the spell can be used by more than one unit at almost the same time without colliding with each other (in simpler terms, without bugging)...

for example, in your current set-up, if two units activate the effect, the first one will end faster since the variables get overridden by the new caster...