[Trigger] can this leak?

[Caleb]

i have trigger that look like this:

trigger1
event:map initialization
action:Set lightning_bzz = bfg_fire <gen>

trigger2
event:time - every 1 second of game time
action: Sound - Play lightning_bzz at 100.00% volume, attached to (Last created unit)

is there any leak with my trigger?

 

[Hijax]

well.... i dont see any, at least. but im not very good at detecting leaks.
edit: why not just make it
every 1 second of game time
play bfg_fire <gen> at 100.00% volume, attached to last created uni?

why store the sound in a variable first?

 

[Slaydon]

yes, you must Destroy the sound

• PLay Sound
• Destroy Sound

 

[Caleb]

well.... i dont see any, at least. but im not very good at detecting leaks.
edit: why not just make it
every 1 second of game time
play bfg_fire <gen> at 100.00% volume, attached to last created uni?

why store the sound in a variable first?

well i thought the trigger will not cause leak if i use variable.

 

[Hijax]

yes, you must Destroy the sound

• PLay Sound
• Destroy Sound

wouldnt that mean he cant acess the sound the next second? sorry if i sound noobish, im not very experienced in this stuff about removing leaks.

 

[Slaydon]

I dont think so, just test it

 

[Saia_Djinn]

Also playing a sound every second is highly imperformant rather go for a soundloop ( dont know if this possible but dont all sounds have a loop argument) so u can go for something like if sound finished then play sound (if its possible =d)