• Listen to a special audio message from Bill Roper to the Hive Workshop community (Bill is a former Vice President of Blizzard Entertainment, Producer, Designer, Musician, Voice Actor) 🔗Click here to hear his message!
  • Read Evilhog's interview with Gregory Alper, the original composer of the music for WarCraft: Orcs & Humans 🔗Click here to read the full interview.
  • Create a faction for Warcraft 3 and enter Hive's 19th Techtree Contest: Co-Op Commanders! Click here to enter!
  • Create a void inspired texture for Warcraft 3 and enter Hive's 34th Texturing Contest: Void! Click here to enter!
  • The Hive's 21st Texturing Contest: Upgrade is now concluded, time to vote for your favourite set of icons! Click here to vote!

Can exiting out of loop prematurely cause leaks in group enumeration?

Status
Not open for further replies.
Level 3
Joined
Apr 16, 2016
Messages
28
If the title didn't make sense, can the below snippet cause leaks?

Code:
private function BellerophonNB_DeathOrbCheck takes nothing returns nothing
        local unit enumUnit
        call GroupEnumUnitsInRect(ENUM_GROUP, WorldBounds.world, null)
        loop
            set enumUnit = FirstOfGroup(ENUM_GROUP)
            exitwhen enumUnit == null or GetUnitTypeId(enumUnit) == DEATH_ORB_UNIT_ID
            call GroupRemoveUnit(ENUM_GROUP, enumUnit)
        endloop
        
        if enumUnit == null then
            call ReleaseTimer(GetExpiredTimer())
        endif

        set enumUnit = null
endfunction
 
Status
Not open for further replies.
Top