Bomb Throw v1.01

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

Moderator: Pharaoh_ Date: 19:11, 22nd Apr 2012 • Maker's suggested changes are more than required. Picking units in region doesn't really reflect the way most spells work (aoe-wise). • Custom values should not be used, as they can collide with other indexing templates, such as Bribe's or Hanky's and many users started manipulating them lately. • Use variables to store (Last created unit) and (Picked unit), to avoid repetition of function calls and reference those variables instead. • Use Maker's link to check if the enum destructable is a tree; I don't fancy GUI submissions making use of vJass libraries. Why force a user to use JNGP just for that? • The special effects' paths should be configurable variables in the Map Initialization, not everytime the spell is cast. You are not using variables for every special effect path the spell uses. • Check if group is empty, when the instance is supposed to end, not every 0.03 seconds. • Run the values required to trigger Paladon's Jump system in the main trigger, don't use another spell cast (Bomb Jump) to run them.

Older Reviews

Required changes

• Add importing instructions into the map file

Suggested changes

• Calculate the dummy's new size into a variable and use the variable
  instead of calculating the value three times
• Don't use custom values as it might collide with other systems
  like unit indexers
• Instead of using a region, pick units in range when you damage units
• Use proper tree detection
• You don't need Remove Explosion Caster trigger
  Apply an expiration timer on the caster instead
• The icon should be active verision, not passive
• The dummy with locust does not have proper death type, it gives vision,
  has structures built, upgrades used...

Useful Links

• Destroy only trees

 

[Adiktuz]

Remove the shadow from the bomb will you? it looks distracting...

and maybe use unit variables rather than spamming TriggeringUnit, Picked unit and such...

Pretty neat but I would prefer if the second explosion is also triggered rather than a thunder clap based ability...

 

[rcshaggy]

Somebody set up the bomb, because I have exploding fever!!! LOL...

 

[Tank-Commander]

Needs a /lot/ more configurables if you ask me, pretty much all of those constants could be variables.

Also you shouldn't be using custom values, use variables with either dynamic indexing or hashtables.

You can select the bomb dummy

You really /do not/ need to be using a jump system for this. It's not very difficult to create a parabola for your bombs without the help of a jump system
Use this to create parabolas:
((4*MaxHeight)/MaxDistance)*(MaxDistance-CurrentDistance*(CurrentDistance/MaxDistance) = Current Fly height

Bombs can destroy eachother - thus stopping the other from "detonating" (this would be fixed if you made the bomb a locust unit, and would also fix the selection unit

Also you should remove the effect of the caster firing that little fireball before the bomb is launched (imo)

Also you need to use a Tree detection system to destroy trees rather than two certain types in the map. Again to do this do not use a dedicated system, it's simple enough to do without one. Also Paladon's system /does not/ do it properly - you need to detect trees alone and not just any kind of destructible, otherwise it'll destroy things like bridges

You can find tutorials on how to do tree detection in the triggers & scripts section in the forums, use the search. Alternatively look at other spells/systems which /do/ have the detection and use a similar thing to those.

 

[Adiktuz]

or better yet, just check if the dest is invulnerable or not...

 

[Tank-Commander]

Well typically in my experience a lot of people don't make bridges invulnerable, besides, if the destructible was invulnerable surely it wouldn't die anyway?

 

[Adiktuz]

well, yeah...

 

[coolyoshi1]

i have finals comin up so i cant fix this spell now but ill do it in a few weeks.
thanks for feedback!

 

[timothyhuth]

A bomb model you can download at wc3forum, a trigger that changes animation of created unit's height to 0 at speed 500. An explosion at -wait tell current height of bomb <= 10.
Congratulations..? Btw, that bomb is huge.. Why?