- Joined
- May 9, 2014
- Messages
- 1,824
Notes:
- The spell triggers could use dynamic indexing.
- Hero_ancient points to a static unit. Care to explain?
- Implementation leaks a lot of locations.
- The spell uses a wait on the effect of the spell, which is disliked by most.
- The spell has some performance overhead, which could affect its approval rating.
Reparations:
- As said, the spell could use dynamic indexing.
- Have a temporary variable point to the location of the object and remove it.
- To remove a location, simply type using Custom Script:
-
-
Custom Script: call RemoveLocation(yourLoc)
-
- To destroy a group, simply declare the following function:
-
-
Custom Script: call DestroyGroup(yourGroup)
-
- Include another real variable that acts as the counter for the duration of the spell.
- This will guarantee accuracy in the measurement of time, which the wait does not generally provide.
- Try to reduce function calls in the triggers by storing them to temporary variables, or using them minimally.
- Function calls are those which are in parentheses, such as
-
(Picked unit)
-
- Function calls are those which are in parentheses, such as
- There should be a configuration trigger, which does the initialization for the user.
Last edited: