B-UP's Spell Pack v1.3a

[Moderator]

01:41, 31st Dec 2012
Magtheridon96: Approved.
Wonderful. You could add much more comments though.

 

[defskull]

What happens if we don't like it ?
Just asking, haha

 

[BUP]

Just leave it as it is,,
I think this will take time to be moderated cuz there's a lot of pending resources for him

 

[hijacky]

Spell Pack!! Whooo!!
That's what i've been looking for a while

 

[CoLd Bon3]

Amazingly awesome! Now, i am a person who looks at the overall look of the spell(s) in-game, i don't look at the code a lot.

FLY SPELL -> It is absolutely awesome, i really liked it! Nothing bad to say. Except that the flying height that the unit goes to is really high (when he attacks, his blade doesn't touch the attacked unit). But that is configurable, so it's OK!

STRIKE -> This is also really good. However, if i use it in my map, i would change the configurables a little bit (everyone has a different taste). The only bug i encountered is that sometimes, the unit's animation doesn't play (when he has to slam). You can try pausing the casting unit while he is performing his animation and unpause it after. /// EDIT : You could add a configurable that defines if the spell has a minimum range in which it can be casted. Because some of it's users (War3 coders i mean) may not want their hero to cast Strike while in melee range (now you can). And if the user wants it to be like how it's now - he simply puts that minimum range to 0.

EMBER SLASHES -> No criticism here. The effects are a little bit disturbing (because there are too much particles) but it can be configured, so it's OK! /// EDIT : A configurable can be added here too. One that defines how much times the caster can slash. Because when there are a lot of units in it's AoE, it is pretty OP. And you know, this configurable says if the caster can slash 3 units, less or more. If the user wants it to be like it's now, he could simply put this configurable to 999. Or perhaps you can create a second configurable that is a boolean and defines if the number of slashes should be checked AT ALL. So the user can change this variable to false, instead the other one to 999 (because in his map, the AoE might be 5000 and there could be more than 999 units in it with no prob.). Buuut the first configurable only should do the job. (the second one would make it look more PRO )

THUNDERSTORM -> All the things i don't like can be configured here as well. Only thing i can say is that you can play an animation while the unit is spinning. Because if you look at it, you see a Blademaster just chillin' there with his stand animation and doing damage... /// EDIT : Another idea for configurable here too. One that defines if Thunderstorm can be aborted by the caster (a boolean). If it's true, then when the unit casts the spell, replace the Thunderstorm with a dummy spell (which has description and stuff). And when the dummy spell is casted while Thunderstorm's effect rages over the battlefield, the Thunderstorm ends and the abilities are reversed (removing the dummy ability and adding the real one).

------------------------------ EDIT ------------------------------

TIDAL CRUSH -> Noting bad to say here. Effects are awesome, same for the idea of the spell and the coding. However, two configurables can be added here too . The first one could define if the caster can move trough trees and cliffs (now he can). And the second could define if enemies can move trough trees and cliffs (now they can when they are moved trough the shield pushing thingy).

DIMENSIONAL DISPLACEMENT -> As Tidal Crush, everything is awesome here too. However, i have an issue with the lightning effect between the glyph and the target - it starts at the bottom of the glyph instead of it's center but it's not a big deal (there was a Jass custom script for this... i think Pharaoh_ showed it to me, create a thread in the Triggers & Scripts section in the forum and i am sure that many people will tell you it). And also, there is something like a blue diamond above the target after the spell ends. What the hell is it? I mean, it's not mentioned in the description and stuff and i am a little bit confused.
-------------------------------------------------------------------------------------------------------------------------------------------------------

Overall, i like all the spells. When i downloaded the pack, i expected something not that good. Great job! I also think that the code is right too. You seem to clear a lot of leaks. You also made almost everything configurable in the spells which is just awesome.

Tremendous work! 5/5 and +rep

Rating not changed!
Remember that those are only suggestions. You are not forced to do as i say. You make the decision!
You may think i am an asshole for asking for more configurables, even when you have dozens of them...

 

[BUP]

Thanks for the great review.
I make spells but I'm not good at making into an awesome piece,so I let almost everything configurable.
I will make the damage type configurable and add some documentation in the next update

 

[Maker]

Why can ground units hit me when I'm flying very high in the air?
The fly spell doesn't need a looping trigger.

 

[CoLd Bon3]

Why can ground units hit me when I'm flying very high in the air?

@BUP, you can prevent ground units from attacking the caster by adding the Crow Form ability to him. It doesn't appear in the hero pannel (bottom right when you have selected the hero). Just like the Locust skill.
The Crow Form changes the unit's movement type to "Fly", thus ground units can't attack it.

 

[Wrda]

@BUP, you can prevent ground units from attacking the caster by adding the Crow Form ability to him. It doesn't appear in the hero pannel (bottom right when you have selected the hero). Just like the Locust skill.
The Crow Form changes the unit's movement type to "Fly", thus ground units can't attack it.

Giving the caster the crow form ability doesn't pervent units from attacking the ground, only gives the ability to fly.

 

[BUP]

Giving the caster the crow form ability doesn't pervent units from attacking the ground, only gives the ability to fly.

Damn right!!
I was busy replying to the Breakdancer.
And I've already added the Crow Form ability to the caster to change the flying height

Why can ground units hit me when I'm flying very high in the air?

I added this trigger now.
I made the ranged attackers to be able to attack the caster

• Fly Attack Prevent
  • Events
    • Unit - A unit Is attacked
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Attacked unit) has buff Fly_Buff) Equal to True
        • ((Attacking unit) is A melee attacker) Equal to True
      • Then - Actions
        • Unit - Order (Attacking unit) to Stop
      • Else - Actions

 

[Wrda]

Anyway BUP have you already fixed the ground units attacking the caster when flying?
Edit:

• Fly Attack Prevent
• Events
• Unit - A unit Is attacked
• Conditions
• Actions
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• ((Attacked unit) has buff Fly_Buff) Equal to True
• ((Attacking unit) is A melee attacker) Equal to True
• Then - Actions
• Unit - Order (Attacking unit) to Stop
• Else - Actions

Unfortunately, there are people who make ranged units only able to attack ground and melee units who only attack air. It looks stupid (Like HLWR) it seems to don't have a way to fix o.o

 

[Wrda]

Yes i looked.

Edit:INSANE SPELLS lol^^ just tested them and saw a bit of the triggers, seems leakless and great coded gj 5/5 + rep

 

[Ofel]

Just like your user title before...

Incoming Spell Pack, right ?? Now became Spell Pack Released...

Why don't still before ??

5/5 I like it...

 

[BUP]

5/5 I like it...

Thanks (but no +rep?)

Why don't still before ??

What does that mean?

 

[Wolf_Wing]

But the thunder Storm have bug if unit cast it near the out of map the caster its stop and taddaaa the caster out of map ;-D.
any way its good spell pack 5/5 for you ;->

 

[BUP]

But the thunder Storm have bug if unit cast it near the out of map the caster its stop and taddaaa the caster out of map ;-D.
any way its good spell pack 5/5 for you ;->

You are always testing the spells near the boundary...
You told me like this in the "Escape Leap" too...
That's a player made bug(I think)

EDIT:Spell Pack Updated.The Bug seems to be not occurring any more

 

[CoLd Bon3]

Am... in the 1.1 version, the Thunderstorm spell hits dead units as well. The lightning bolts strike the corpses too. I don't know if you minded it this way... i'm just saying.

 

[BUP]

@Cold Bon3
You can check pre-1.2 version in my previous post's attachment
It contains a new spell

 

[BUP]

^^updated^^

 

[Elprede]

You are always testing the spells near the boundary...
You told me like this in the "Escape Leap" too...
That's a player made bug(I think)

EDIT:Spell Pack Updated.The Bug seems to be not occurring any more

This is not a bug that users create. Yes, users can produce this bug, if they use the spells near boundaries. Think about small maps with an area of 32 x 32, though. You should be sure that none of your future spells create this bug because Wc3 can crash with units outside of playable map boundaries.

 

[BUP]

Updated

 

[doomhammer99]

You're finally improved BUP.

COOl Spells

 

[CoLd Bon3]

BUP... you don't need those "Cleaner" triggers. Giving a generic expiration timer to the dummies is enough.

I tested with creating 12000 units and adding expiration timer. I saw no major leaks anyway. If there was a leak it was very small. Don't worry about it.

I took 4 data points, at 4k, 6k, 8k and 10k. After pausing the test for a while and checking the memory reseved, it was exactly 94352 K at all data points.

Btw, you said that you will take a break for several days...

 

[Ofel]

What does that mean?

I mean you must still make spell pack....

 

[BUP]

Spell Pack Will be updated soon!!