Attribute Purchase System v1.0

[Moderator]

12th Dec 2015
IcemanBo: For too long time as NeedsFix. Rejected.

23th Jul 2011
Bribe:

Unnacceptable JASS names, these need to be prefixed.
This also should not be custom script as there is nothing
special about it:

function Trig_Make_a_Hero_Actions takes nothing returns nothing
set udg_Hero[0] = CreateUnit(Player(0),'Hpal',GetRectCenterX(gg_rct_Spawn),GetRectCenterY(gg_rct_Spawn), 260.)
call SetPlayerState(Player(0), PLAYER_STATE_RESOURCE_GOLD, 1000)
endfunction

//===========================================================================
function InitTrig_Make_a_Hero takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterTimerEventSingle(t, 0.00)
    call TriggerAddAction( t, function Trig_Make_a_Hero_Actions )
    set t = null
endfunction

 

[Magtheridon96]

Can you please post the code? (It's a requirement)

edit
I checked out the code.
You need to learn to align it better
I aligned it for you:

function Trig_Buy_Strength_Actions takes nothing returns nothing
    local integer gold //This is for subtracting and keeping track of the user's gold
    local integer str // This is for modifying the attribute.

    loop
        exitwhen GetPlayerState(GetTriggerPlayer(), PLAYER_STATE_RESOURCE_GOLD) < 250 //You can change 250 to whatever you want each charge to cost.
        set gold = GetPlayerState(GetTriggerPlayer(), PLAYER_STATE_RESOURCE_GOLD) //Leave this line alone. Sets gold to their gold
        call SetPlayerState(GetTriggerPlayer(), PLAYER_STATE_RESOURCE_GOLD, (gold - 250)) //Change the 250 to what you changed the other 250 to. This will subtract the gold
        set str = (GetHeroStr(udg_Hero[GetPlayerId(GetTriggerPlayer())], false) + 10) // This line needs some editing. Change "udg_Hero" hero to whatever your hero variable in your map is (You need one). Change + 10 to whatever increment you want each purchase to be.
        call SetHeroStr(udg_Hero[GetPlayerId(GetTriggerPlayer())], str, true) // Leave this line alone. It sets their attribute to what it should be after purchase.
    endloop
endfunction

//===========================================================================
function InitTrig_Buy_Strength takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterPlayerChatEvent( t, Player(0), "-bs", true)
    call TriggerAddAction( t, function Trig_Buy_Strength_Actions )
    set t = null
endfunction

function Trig_Buy_Agility_Actions takes nothing returns nothing
    local integer gold //This is for subtracting and keeping track of the user's gold
    local integer agi // This is for modifying the attribute.
    
    loop
        exitwhen GetPlayerState(GetTriggerPlayer(), PLAYER_STATE_RESOURCE_GOLD) < 250 //You can change 250 to whatever you want each charge to cost.
        set gold = GetPlayerState(GetTriggerPlayer(), PLAYER_STATE_RESOURCE_GOLD) //Leave this line alone. Sets gold to their gold
        call SetPlayerState(GetTriggerPlayer(), PLAYER_STATE_RESOURCE_GOLD, (gold - 250)) //Change the 250 to what you changed the other 250 to. This will subtract the gold
        set agi = (GetHeroAgi(udg_Hero[GetPlayerId(GetTriggerPlayer())], false) + 10) // This line needs some editing. Change "udg_Hero" hero to whatever your hero variable in your map is (You need one). Change + 10 to whatever increment you want each purchase to be.
        call SetHeroAgi(udg_Hero[GetPlayerId(GetTriggerPlayer())], agi, true) // Leave this line alone. It sets their attribute to what it should be after purchase.
    endloop
endfunction

//===========================================================================
function InitTrig_Buy_Agility takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterPlayerChatEvent( t, Player(0), "-ba", true)
    call TriggerAddAction( t, function Trig_Buy_Agility_Actions )
    set t = null
endfunction

function Trig_Buy_Intellect_Actions takes nothing returns nothing
    local integer gold //This is for subtracting and keeping track of the user's gold
    local integer int // This is for modifying the attribute.

    loop
        exitwhen GetPlayerState(GetTriggerPlayer(), PLAYER_STATE_RESOURCE_GOLD) < 250 //You can change 250 to whatever you want each charge to cost.
        set gold = GetPlayerState(GetTriggerPlayer(), PLAYER_STATE_RESOURCE_GOLD) //Leave this line alone. Sets gold to their gold
        call SetPlayerState(GetTriggerPlayer(), PLAYER_STATE_RESOURCE_GOLD, (gold - 250)) //Change the 250 to what you changed the other 250 to. This will subtract the gold
        set int = (GetHeroInt(udg_Hero[GetPlayerId(GetTriggerPlayer())], false) + 10) // This line needs some editing. Change "udg_Hero" hero to whatever your hero variable in your map is (You need one). Change + 10 to whatever increment you want each purchase to be.
        call SetHeroInt(udg_Hero[GetPlayerId(GetTriggerPlayer())], int, true) // Leave this line alone. It sets their attribute to what it should be after purchase.
    endloop
endfunction

//===========================================================================
function InitTrig_Buy_Intellect takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterPlayerChatEvent( t, Player(0), "-bi", true)
    call TriggerAddAction( t, function Trig_Buy_Intellect_Actions )
    set t = null
endfunction

Tips:
1- You need to make things easily configurable (use globals) or if you want it to stay Jass and not vJass, you could use functions like:

function GetStrengthCost takes nothing returns integer
    return 250
endfunction

(This applies to all 3 triggers)
2- You shouldn't repeat function calls. Use local variables instead.
For example, you should create a local player and set him to GetTriggerPlayer(). Then use that variable instead. (This applies to all 3 triggers)
3- Move the exitwhen line below the "set gold = ..." line. That way, you could just use exitwhen gold < GetStrengthCost() (This applies to all 3 triggers)
4- You don't need to do "set int = ...." or "set str = ..." or "set agi = ..." since you're only using that variable once..
5- Instead of constantly setting the player state to be less by 250 and increasing the hero's strength/intelligence/agility by 10, you could divide the players gold by the cost and increase the units strength by the integer you retreived from the previous equation and the bonus per purchase.
6- Your system isn't MPI

Here:
This would be much better:

function GetStrengthCost takes nothing returns integer
    return 250
endfunction

function GetStrengthBonus takes nothing returns integer
    return 10
endfunction

function GetPlayerHero takes integer i returns unit
    return udg_Hero[i]
endfunction

function Trig_Buy_Strength_Actions takes nothing returns nothing
    local player p = GetTriggerPlayer()
    local integer gold = GetPlayerState(p,PLAYER_STATE_RESOURCE_GOLD)
    local integer cost = GetStrengthCost()
    
    call SetHeroStr(GetPlayerHero(GetPlayerId(p)),GetHeroStr(GetPlayerHero(GetPlayerId(p)),false)+GetStrengthBonus()*(gold/cost))
    call SetPlayerState(p,PLAYER_STATE_RESOURCE_GOLD,gold-(gold/cost)*cost)
    
    set p = null
endfunction

function InitTrig_Buy_Strength takes nothing returns nothing
    local trigger t = CreateTrigger()
    local integer i = 0
    loop
        exitwhen i>11
        call TriggerRegisterPlayerChatEvent(t,Player(i),"-bs",true)
        set i=i+1
    endloop
    call TriggerAddAction(t,function Trig_Buy_Strength_Actions)
    set t = null
endfunction

You should do something similar for the other triggers too...

 

[khamarr3524]

Done, I apologize. New to submissions.

 

[Magtheridon96]

Yeah it's alright
Just don't forget to read my suggestions

 

[khamarr3524]

Your script is lacking in the fact that it Doesn't get the players current agility and only sets it to the scripts current running of agility. I see how your script is more optimum in the fact that it uses more functions to index variables, and I'll be sure to update it to be like this soon, but for now I'll leave it as it is because I do not have time right now, I have to leave the house for now. Thank you for helping me, I've just started learning jass 3 days ago.

 

[Magtheridon96]

Your script is lacking in the fact that it Doesn't get the players current agility and only sets it to the scripts current running of agility

oops.. fixed it

 

[Nestharus]

You need to update the code in the post to reflect your latest changes.


Also, you should support buying an amount of a stat, for example 300 strength.


You should also make the commands configurable-
bs, ba, and bi aren't typically used. Normally str, agi, and int are used ^)^.


So, if a number is present in the string, buy either that charge or as much as can be bought. If no number is present, buy as much as can be bought.


Also, it wouldn't be too hard to make this MUI. You could buy the stats for the current selected units no? : )


For example, for every hero that's selected, you spread the stats out. If buying 300 and 6 heroes are selected, that's 50 for each hero. I think that's a better approach though I don't think anybody's done that yet =).

 

[khamarr3524]

I'll definately sit down and make this system for optimum and also more usable, I simply used this for my map and thought it would be useful. Perhaps some customizable script using booleans to disable functions like you were saying Nestharus. I'll definately revise it and make it alot better, but for now i think the current version is good enough to be used and modified as a base, with credit given of course for the base of it.
Edit: I used BA,BS,and BI because I saw it in some map, Idr. It might have been Heaven Vs Hell. Idr.

 

[Magtheridon96]

You could make the strings configurable.
Also, you don't need to have 3 triggers, you could use one function that takes an index corresponding to an attribute

You need to update the code in the post to reflect your latest changes.

But he didn't update it yet ^)^

 

[Ketsuno Anson]

I wonder what if an unit with no stat purchases it :x

 

[Nestharus]

Nothing, gold gets lost..

that's why it should only work if the unit is a hero.

 

[mckill2009]

I think its better to Click select a hero then save the hero like udg_Hero, so that you can avoid this long line >>> udg_Hero[GetPlayerId(GetTriggerPlayer())]...and I think the loop is not needed...conditions will do...
anyway this is an OK idea...

 

[Marsal]

This can be easily done in GUI and in one simple trigger...

 

[Bannar]

This is really simple system, easy do-able in GUI and i don't see many niches for it, yet it can be usefull for Xhero siege like maps.

 

[Dr Super Good]

You have a lot of procedural coupling...

 

[Magtheridon96]

that's why it should only work if the unit is a hero

What if we WANT the player to randomly lose gold?