Moderator
M
Moderator
12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.
09:56, 12th Aug 2011
Bribe:
Your AV_CONSTANTS should be normal variables. Don't abuse hashtables just to have fewer global variables. If they are constant, use constant functions to return integers/reals and strings then use variables to store things like unit groups, locations, etc.
What you're doing now using hashtables like this is like taking a bus to cross the street.
You should also combine your two triggers into one to make this easier to import. JASS lets you do that. And don't use TriggerRegisterTimerEvent, use actual timers for this. It looks like you're too new to JASS to really realize how much you can do with it.
I recommend sticking with GUI if you're more comfortable with GUI, practicing in JASS, because this is far from approvable in its current state.
IcemanBo: Too long as NeedsFix. Rejected.
09:56, 12th Aug 2011
Bribe:
Your AV_CONSTANTS should be normal variables. Don't abuse hashtables just to have fewer global variables. If they are constant, use constant functions to return integers/reals and strings then use variables to store things like unit groups, locations, etc.
What you're doing now using hashtables like this is like taking a bus to cross the street.
You should also combine your two triggers into one to make this easier to import. JASS lets you do that. And don't use TriggerRegisterTimerEvent, use actual timers for this. It looks like you're too new to JASS to really realize how much you can do with it.
I recommend sticking with GUI if you're more comfortable with GUI, practicing in JASS, because this is far from approvable in its current state.