Alternative Damagesystem v1.0

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

12:10, 21st Sep 2014
TriggerHappy:

You need to replace your DDS with one that works properly. It seems like you're only checking the damage event which as far as I know isn't accurate and neither is your detection of units entering maps.

 

[edo494]

sorry to be harsh, but unless you hook this to DDS you will not succeed in getting this approved, because your method may crash the map if the maps uses many many units that are created throughout the game. Also your function GetResistence should be at the top because it is configurable, which should be sticked to the top of your code. People dont want to crawl over your code just to find something that is meant to be configurable

 

[Crixx]

hm :/ ok thats not good...

I only decided to upload this because I use this in my current project.

So may I ask how much "many many" units are so around which size?

 

[edo494]

it will keep decreasing the performance of the map because as unit spawn in the game the trigger will keep adding and adding them until eventually the game will crash because you can only have so many units registered onto one trigger.

The problem with damage detection is the fact that when unit dies and gets removed from the game it will not get removed from the triggers it is registered into

 

[Crixx]

the only alternative i come think of is for each unit an extra trigger and then destroying it but is this ok? i mean will it leak or something?

Edit: I've just have changed the DDS trigger.

function Trig_Damagedetection_Actions takes nothing returns nothing
    if(GetEventDamage() >= 1.) then
        call OnUnitDmg(GetEventDamageSource(), GetTriggerUnit(), GetEventDamage(), DMG_Physical)
        if(GetWidgetLife(GetTriggerUnit()) < GetEventDamage()) then
            call OnUnitDeath(GetEventDamageSource(), GetTriggerUnit())
            call DestroyTrigger(GetTriggeringTrigger())
        endif
    endif
endfunction

function Trig_Damagedetection_AddUnit takes nothing returns nothing
    local trigger t = CreateTrigger()
	call TriggerRegisterUnitEvent(t, GetEnumUnit() , EVENT_UNIT_DAMAGED)
    call TriggerAddAction(t, function Trig_Damagedetection_Actions)  
endfunction

function Trig_Damagedetection_UnitEnter takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterUnitEvent(t, GetTriggerUnit() , EVENT_UNIT_DAMAGED) 
    call TriggerAddAction(t, function Trig_Damagedetection_Actions)   
endfunction  

function InitTrig_System_Damagedetection takes nothing returns nothing
    local group g = CreateGroup()
    
    set gg_trg_System_Damagedetection = CreateTrigger()
    call TriggerRegisterEnterRectSimple(gg_trg_System_Damagedetection, GetWorldBounds())  
    call TriggerAddAction(gg_trg_System_Damagedetection, function Trig_Damagedetection_UnitEnter)  
    
    call GroupEnumUnitsInRect(g, GetWorldBounds(), null)
    call ForGroup(g, function Trig_Damagedetection_AddUnit)
    call DestroyGroup(g)
endfunction

Would it work better now? I mean every trigger is destroyed after use and also triggers don't leak as far as I know.

 

[Arhowk]

its still not as efficient as, say, Nes's, that only uses one trigger and only leaks a maximum of 50-100 events

the way its done is by keeping a list of units and after say 50 units are removed, than remove the previous trigger and recreate it with the list of units

 

[zv27]

the only alternative i come think of is for each unit an extra trigger and then destroying it but is this ok? i mean will it leak or something?

Edit: I've just have changed the DDS trigger.

function Trig_Damagedetection_Actions takes nothing returns nothing
    if(GetEventDamage() >= 1.) then
        call OnUnitDmg(GetEventDamageSource(), GetTriggerUnit(), GetEventDamage(), DMG_Physical)
        if(GetWidgetLife(GetTriggerUnit()) < GetEventDamage()) then
            call OnUnitDeath(GetEventDamageSource(), GetTriggerUnit())
            call DestroyTrigger(GetTriggeringTrigger())
        endif
    endif
endfunction

function Trig_Damagedetection_AddUnit takes nothing returns nothing
    local trigger t = CreateTrigger()
	call TriggerRegisterUnitEvent(t, GetEnumUnit() , EVENT_UNIT_DAMAGED)
    call TriggerAddAction(t, function Trig_Damagedetection_Actions)  
endfunction

function Trig_Damagedetection_UnitEnter takes nothing returns nothing
    local trigger t = CreateTrigger()
    call TriggerRegisterUnitEvent(t, GetTriggerUnit() , EVENT_UNIT_DAMAGED) 
    call TriggerAddAction(t, function Trig_Damagedetection_Actions)   
endfunction  

function InitTrig_System_Damagedetection takes nothing returns nothing
    local group g = CreateGroup()
    
    set gg_trg_System_Damagedetection = CreateTrigger()
    call TriggerRegisterEnterRectSimple(gg_trg_System_Damagedetection, GetWorldBounds())  
    call TriggerAddAction(gg_trg_System_Damagedetection, function Trig_Damagedetection_UnitEnter)  
    
    call GroupEnumUnitsInRect(g, GetWorldBounds(), null)
    call ForGroup(g, function Trig_Damagedetection_AddUnit)
    call DestroyGroup(g)
endfunction

Would it work better now? I mean every trigger is destroyed after use and also triggers don't leak as far as I know.

    function Trig_Damagedetection_AddUnit takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterUnitEvent(t, GetEnumUnit() , EVENT_UNIT_DAMAGED)
        call TriggerAddAction(t, function Trig_Damagedetection_Actions)  
    endfunction

    function Trig_Damagedetection_UnitEnter takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterUnitEvent(t, GetTriggerUnit() , EVENT_UNIT_DAMAGED)
        call TriggerAddAction(t, function Trig_Damagedetection_Actions)  
    endfunction

    //------------------->>>>>>>>>
    // For complete details see the whole "main code"


    function Trig_Damagedetection_AddUnit takes nothing returns nothing
        local unit u = GetEnumUnit()
       // You can add some conditions here.Depending on the needs of
       // if (something) then
            call TriggerRegisterUnitEvent( udg_YourTrigger, u, EVENT_UNIT_DAMAGED )
       // endif
        set u = null
    endfunction
   
    function Trig_Damagedetection_UnitEnter takes nothing returns nothing
        local unit u = GetTriggerUnit()
        // You can add some conditions here.Depending on the needs of
        // if (something) then
            call TriggerRegisterUnitEvent( udg_YourTrigger, u, EVENT_UNIT_DAMAGED )
        // endif
        set u = null
    endfunction

    set gg_trg_System_Damagedetection = CreateTrigger()
    call TriggerRegisterEnterRectSimple(gg_trg_System_Damagedetection, GetWorldBounds())  
    call TriggerAddAction(gg_trg_System_Damagedetection, function Trig_Damagedetection_UnitEnter)

->

     local code e = function Trig_Damagedetection_UnitEnter
     local region r = CreateRegion()
     local trigger t = CreateTrigger()
     call RegionAddRect( r, bj_mapInitialPlayableArea )
     call TriggerRegisterEnterRegion( t, r,  null )
     call TriggerAddCondition( t, Filter( e ) )
     set r = null
     set t = null
     set e = null

    local group g = CreateGroup()
    call GroupEnumUnitsInRect(g, GetWorldBounds(), null)
    call ForGroup(g, function Trig_Damagedetection_AddUnit)
    call DestroyGroup(g)

->

     local code mi = function Trig_Damagedetection_AddUnit
     call GroupEnumUnitsInRect( bj_lastCreatedGroup, bj_mapInitialPlayableArea,  null )
     call ForGroup( bj_lastCreatedGroup, mi ) 
     set mi = null

***********
The main code
***********

    //Function names are arbitrary so fuck them

    //*----------------------------------------------------------------------------------
    //*
    //*                          Functions for color text and more things
    //*                          With this function, your main code will be much shorter                       
    //*
    //*----------------------------------------------------------------------------------
    function CreateTextTagUnitEx takes unit u, string s, real size, real offset, real speed, real angle, integer red, integer blu, integer gre, integer trans, real life, real fade, boolean show, boolean permanent, boolean suspend returns texttag
        local texttag tt = CreateTextTag()
        local real vel=(speed*.071)/128
        local real xvel=vel*Cos( angle * .01745 )
        local real yvel=vel*Sin( angle * .01745 )
        call SetTextTagText(tt,s,(size*0.023)/10)
        call SetTextTagPos(tt,GetUnitX(u),GetUnitY(u),offset)
        call SetTextTagColor(tt,red,blu,gre,255-trans)
        call SetTextTagVisibility(tt,show)
        call SetTextTagPermanent(tt,permanent)
        call SetTextTagSuspended(tt,suspend)
        call SetTextTagVelocity(tt,xvel,yvel)
        if permanent!=true then
            call SetTextTagLifespan(tt,life)
            call SetTextTagFadepoint(tt,fade)
        endif
        return tt
    endfunction

    function YourCode takes nothing returns nothing
        // This is the main function
        // Magic happens here
        // Here we are going to register some things
        // e.g
        set DMGSource = GetEventDamageSource()
        set DMGTarget = GetTriggerUnit()
        set DMGAmount = GetEventDamage()
        set udg_EnableSystem = 1.
        set udg_EnableSystem = 0.
        // etc.
    endfunction

    function ClearTrigger takes nothing returns nothing
        local unit u = GetEnumUnit()
        if GetWidgetLife( u ) >= .406 then
            call TriggerRegisterUnitEvent( udg_YourTrigger, u, EVENT_UNIT_DAMAGED )
        endif
        set u = null
    endfunction

    function FlushMemory takes nothing returns nothing
        local code c = function YourCode
        local code ct = function ClearTrigger
        call GroupEnumUnitsInRect( bj_lastCreatedGroup, bj_mapInitialPlayableArea,  null )
        call ResetTrigger( udg_YourTrigger )
        call DestroyTrigger( udg_YourTrigger )
        set udg_YourTrigger = null
        set udg_YourTrigger = CreateTrigger()
        call TriggerAddCondition( udg_YourTrigger, Filter( c ) )
        call ForGroup( bj_lastCreatedGroup, ct )
        set c = null
        set ct = null
    endfunction

    function MapInit takes nothing returns nothing 
        local unit u = GetEnumUnit() 
       // You can add some conditions here.Depending on the needs of
       // if (something) then
            call TriggerRegisterUnitEvent( udg_YourTrigger, u, EVENT_UNIT_DAMAGED )
       // endif
        set u = null
    endfunction
    
    function UnitEntersMap takes nothing returns nothing
        local unit u = GetTriggerUnit()
        // You can add some conditions here.Depending on the needs of
        // if (something) then
            call TriggerRegisterUnitEvent( udg_YourTrigger, u, EVENT_UNIT_DAMAGED )
        // endif
        set u = null
    endfunction

    //This goes on map init

    function Register takes nothing returns nothing
        local code c = function YourCode
        local code e = function UnitEntersMap
        local code m = function FlushMemory
        local code mi = function MapInit
        local region r = CreateRegion()
        local trigger t = CreateTrigger()
        local trigger cm = CreateTrigger()
        set udg_YourTrigger = CreateTrigger()
        set udg_EnableSystem = 0.
        // registering units which are already on the map
        call TriggerAddCondition( udg_YourTrigger, Filter( c ) )
        call GroupEnumUnitsInRect( bj_lastCreatedGroup, bj_mapInitialPlayableArea,  null )
        call ForGroup( bj_lastCreatedGroup, mi ) 
        // registering units which are currently entered
        call RegionAddRect( r, bj_mapInitialPlayableArea )
        call TriggerRegisterEnterRegion( t, r,  null )
        call TriggerAddCondition( t, Filter( e ) )                                            
        // This function resets the memory
        // The value of 30 should be configured but this is just fucking example
        //40.50.60. and so on...
        call TriggerRegisterTimerEvent( cm, 30., true )
        call TriggerAddCondition( cm, Filter( m ) )
        set c = null
        set e = null
        set m = null
        set r = null
        set t = null
        set cm = null
        set mi = null
    endfunction


     //This goes on map init

    function DamageActions takes nothing returns boolean
        // Example
        if DMGAmount > 0. then
            call DisplayTextToPlayer( GetLocalPlayer(), 0, 0, R2S( DMGAmount ) )
        endif
        return false
    endfunction

    function RegisterDmageEvent takes nothing returns nothing
        local trigger t = CreateTrigger()
        local code c = function DamageActions
        call TriggerRegisterVariableEvent( t, "EnableSystem", EQUAL, 1.0 )
        call TriggerClearConditions( t )
        call TriggerAddCondition( t, Filter( c ) )
        set t = null
        set c = null
    endfunction

 

[Arhowk]

...

huhwhat? the only changes you made were making code variables and passing them in which is incredibly inefficient. why would u even do that.

bj_lastCreatedGroup won't work btw

 

[zv27]

huhwhat? the only changes you made were making code variables and passing them in which is incredibly inefficient. why would u even do that.

bj_lastCreatedGroup won't work btw

bj_lastCreatedGroup won't work btw ????????

The most ridiculous thing I've heard lately

You're crazy, man muhahahahahhahahahhahahahah

Before you say something stupid,first think carefully muhahahahha bj_lastCreatedGroup won't work omg Fuck, I'll die of laughter muhahahah

 

[Xonok]

Yes, it won't work.

 

[zv27]

Yes, it won't work.

false

It is possible that only works in my version of the editor
muhahahah

    // Blizzard.j ( define Jass2 functions that need to be in every map script )
    // Last X'd vars
    unit               bj_lastCreatedUnit          = null
    item               bj_lastCreatedItem          = null
    item               bj_lastRemovedItem          = null
    unit               bj_lastHauntedGoldMine      = null
    destructable       bj_lastCreatedDestructable  = null
   // **********************************************
    group              bj_lastCreatedGroup         = CreateGroup()
   //**********************************************

 

[Xonok]

I am not here to talk to an idiot.
I said that it won't work, just as Arhowk did and you're being stupid to ridicule us for that.

It won't work because in your whole code you NEVER EVER use a function that assigns anything to bj_lastCreatedGroup. This bj variable is only ever used in GUI functions, as it is utterly pointless in JASS.

tl;dr - This will be extremely buggy for anyone that extensively uses GUI, because it makes no sense.

 

[zv27]

I am not here to talk to an idiot.
I said that it won't work, just as Arhowk did and you're being stupid to ridicule us for that.

It won't work because in your whole code you NEVER EVER use a function that assigns anything to bj_lastCreatedGroup. This bj variable is only ever used in GUI functions, as it is utterly pointless in JASS.

tl;dr - This will be extremely buggy for anyone that extensively uses GUI, because it makes no sense.

I can not believe,another idiot
After all, think what you want and be stupid all your life
I'm sorry I can not get down to your level[level of intelligence]
As for me, the discussion is finished

 

[Xonok]

A person often projects his own faults onto others. I'll let other "idiots" disprove you. Maybe eventually you'll know the difference between valid criticism and trolling.

 

[Nestharus]

The reason why a new DDS would be approved is because it would have a different design philosophy or some other pro/con that could not be measured against a current DDS.

Why this one over the others? It doesn't support third party resources, it's difficult to maintain, it's hard to configure, and it has poor trigger recycling. Please let everyone know what the pros are that outweigh the costs. I, for one, don't see them. You say that you use this for your map? Keep it that way; it's ill suited to be a public resource.

 

[Arhowk]

I can not believe,another idiot
After all, think what you want and be stupid all your life
I'm sorry I can not get down to your level[level of intelligence]
As for me, the discussion is finished

Please don't flame, this is just a hobby site. If you truly believe your claims are true, post proof that assigns values to bj_lastCreatedGroup.

The reason why a new DDS would be approved is because it would have a different design philosophy or some other pro/con that could not be measured against a current DDS.

Why this one over the others? It doesn't support third party resources, it's difficult to maintain, it's hard to configure, and it has poor trigger recycling. Please let everyone know what the pros are that outweigh the costs. I, for one, don't see them. You say that you use this for your map? Keep it that way; it's ill suited to be a public resource.

To translate....

The Hive doesn't like keeping duplicate resources and this resource is a duplicate of quite a few others that does the same exact thing less efficiently. If you want this to be approved, you either have to do it more efficiently than Bribes / LFH or do it differently that would make it worth using.

 

[rarigate]

The reason why a new DDS would be approved is because it would have a different design philosophy or some other pro/con that could not be measured against a current DDS.

Why this one over the others? It doesn't support third party resources, it's difficult to maintain, it's hard to configure, and it has poor trigger recycling. Please let everyone know what the pros are that outweigh the costs. I, for one, don't see them. You say that you use this for your map? Keep it that way; it's ill suited to be a public resource.

Don't be silly, this one is an alternate only :/

 

[Crixx]

Hm, as I said I only uploaded this cuz it could have been useful for someone.
Sure it isn't easy to configure and it doesn't look diffrent like other dds/damage output before. It is for me just a tool to determine damage in a better way for example magic(reduced by resistence in my map), physical(armor reduced) and true damage(completly ignore any reduction). But that you told me that it's inefficient is something I#m thankful for.

Now that you say it wouldn't get approved, should I delete it?

Edit: If it's better to configure/approve I could also make more constants that can be changed for example the effects.

 

[Xonok]

I think the fundamental problem with this system is that is is both a damage handler and a damage detection system.
This forces people to use a subpar damage detection/modification(yours) in order to more comfortably do something that they could do with the existing damage detection systems.

If you made it run off of lfh's damage detection, for instance, then it would be a very useful system.

 

[Crixx]

If you made it run off of lfh's damage detection, for instance, then it would be a very useful system.

Ok, I don't really understand :/

Should I remove the dds trigger? I don't know if I mentioned this but it's simple to capture the basic attacks so that for example when a unit dies you get the credit( gold and exp) for it.

I'll update this definetly with better configureability later(maybe tommorow or today in the evening).

 

[Xonok]

The thing is that DamageEngine by lfh supports more and is better to configure. Try it out.

Features that it has:
*Automatic damage type detection
*Properly modify damage taken, even when health is full.
*Prevent units from dying when they're not supposed to(damage reduction).
*Easy to configure through adding damage handlers.
*Easy damage modification(only have to change 1 variable and everything will work)

The problem with your system is that it tries to do everything, but in the end doesn't do it as well as other resources.

*Damage detection and modification should be a separate resource.
*Bounty should be separate.
*Also, if a person is able to trigger all his spells(detecting basics attacks requires them to do so with this system), then he is also likely able to create his own damage type system with ease.
*The system shouldn't automatically create blood effects, because it has nothing to do with damage detection/modification and is easy to add in any proper damage system anyway.

 

[Crixx]

It can't be helped then.

I'm only a hobby programmer. If have giant ideas but the time is limited. And the fact that I always do my projects alone doesn't make it better. I didn't learned Java or C#, C++, and C through a book or teacher or something. I told me everything myself. Jass is no exception. I' currently trying to do something equal to League of Legends or DotA. It already took it's time but it doesn't seem to proceed. And before I cancel the project I decided to at least share the Damagesystem. Is inefficient and there are better ones. What a suprise. Maybe later I have more ambition to finish the project or to better the system.

But thanks for the replys.

Edit: "I didn't learned Java or C#, C++, and C through a book or teacher or something. I told me everything myself." This should mean that I just learned through GUI and such^^ so by converting GUI to Jass

 

[Xonok]

I am willing to help you learn. Send me a PM if you're interested.

 

[edo494]

this is "good" home-brewed source, especially when you are intrested in inspecting how the DDS works, but there are some quality constraits put on public resources.

 

[Crixx]

Is this a compliment?

 

[edo494]

not compliment, but I dont want you to feel that your system is bad or anything. Its good for your own use if you feel its good(obviously), but you know, there is certain bar that must be met before it can be publically usable without constraits on potential crashes etc

 

[Crixx]

to be honest i have much much more settings in the original system, which is also coupled to the xe-system(custom missilses and such). In my map are really a lot of units created and i was wondering wheres the leak. so if it is still leaking i know where to ask^^ but i didn't created the system when its no use so youre right ^^ dont even know if my whole code is leakless. also i have some problems with my buffs but thats the wrong thread for this^^