Alien spell pack 2.2

[Moderator]

19 Dec 2011
Bribe: You did move the line "if group is empty" line below the "remove unit from group" line, however what I meant was to add it in the same block so it is indented the same as "remove unit from unit group".

I'm going to approve this with a 3/5 for now (decent spellpack).

 

[Maker]

All looping triggers must be turned off. Number of units in group condition leaks. Trigger 3 for Acid blood is not needed, just give the unit an expiration timer when you create it.

 

[dangles20]

Updated.

 

[Magtheridon96]

• Acid blood settings
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • ((Attacking unit) has buff Acid blood ) Equal to False
    • ((Triggering unit) has buff Acid blood ) Equal to True
    • ((Attacking unit) is in AB_Unitgroup) Equal to False
  • Actions
    • Set AB_Percentage = (Random integer number between 1 and 100)
    • -------- Sets the level of Acid blood for the attacked unit --------
    • Set AB_Level = (Level of Acid blood for (Triggering unit))
    • -------- Sets how many seconds the spell lasts for --------
    • Set AB_Duration = (AB_Level x 2)
    • -------- Sets the percent chance the skill has to activate --------
    • Set AB_Percent_chance = (AB_Level x 10)
    • -------- Sets how much damage the spell inflicts each second --------
    • Set AB_Damage = (AB_Level x 5)
    • -------- End of settings --------
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • AB_Percentage Less than or equal to AB_Percent_chance
      • Then - Actions
        • Hashtable - Save AB_Damage as 3 of (Key (Attacking unit)) in AB_Hash
        • Hashtable - Save AB_Duration as 0 of (Key (Attacking unit)) in AB_Hash
        • Hashtable - Save AB_Level as 1 of (Key (Attacking unit)) in AB_Hash
        • Hashtable - Save Handle Of(Owner of (Triggering unit)) as 2 of (Key (Attacking unit)) in AB_Hash
        • Unit Group - Add (Attacking unit) to AB_Unitgroup
        • Trigger - Turn on Acid blood function <gen>
      • Else - Actions

Since you're using (Attacking unit) and Key(Attacking unit) more than once, it would be more efficient if you store them in variables.

• Set AttackingU = (Attacking unit)
• Custom script: set udg_Attacking_key = GetHandleId(udg_AttackingU)

Oh and use (Triggering player) instead of (Owner of (Triggering unit))

 

[dangles20]

Updating.

Edit:

Since you're using (Attacking unit) and Key(Attacking unit) more than once, it would be more efficient if you store them in variables.

• Set AttackingU = (Attacking unit)
• Custom script: set udg_Attacking_key = GetHandleId(udg_AttackingU)

when using this custom script i get the error type mismatch in assignment

 

[Pharaoh_]

Use an integer variable and then set it like this:

• Set AB_Key = (Key (Picked unit))

 

[dangles20]

Updated, thanks for all the helpful advice.

Edit: i just realized why the custom scripts wasnt working i was settings the variable as a handle not a integer but im gonna leave it as it is now.

 

[von_Oberstain]

please get this as a constructive critique - i basically want to use these spells at some stage in project i'm working on

unfortunately, due to large number of units and great potential of number of same spells being cast in short period of time, any 'every 0.03 sec' loop is unacceptable for me.

now, to the point (all based on avoiding the loops):
1) acid blood - why not using 'faerie fire' or 'inner fire' or whatever timed spell with specified duration, instead having a loop
2) infect - kinda similar to 'parasite' ability - can't you use it to avoid loop?

other two - again, are they possible without short-timed loop?

(basically, i could do it on my own and still give you all credits in map, but you had very nice idea, and i would prefer to use then in original form)

also, expanding of your spellpack will be greatly appreciated.

keep up the good work

 

[dangles20]

never thought about it i might be able to remove the loops, as for expanding I'm currently working on my next 2 spells. For infect however i may need to keep the loop if the floating text is to be updated for each unit.

 

[von_Oberstain]

more spells coming? good news indeed!

 

[dangles20]

I will no longer work on this spell pack for now, I may however come back to it some time in the future. If you want to remake it using your idea with the same function then you can use it in your map or maps without giving any credit.