[JASS] AddingUnitToStock bug...

[DoOs_101]

Hey I have the following code that repicks a player's hero...

function RemoveHeroIcon takes player who returns nothing
local player p = who
local integer i = GetConvertedPlayerId(p)
if(i <= 5) then
call MultiboardSetItemIconBJ( udg_Multiboard, 1, ( i + 2 ), "" )
else
call MultiboardSetItemIconBJ( udg_Multiboard, 1, ( i + 3 ), "" )
endif
set p = null
endfunction

function Repick takes player who returns nothing
local player p = who
local integer i = GetConvertedPlayerId(p)
local location l = GetUnitLoc(udg_heroselector[i])
call RemoveHeroIcon(p)
call DisplayTextToForce(GetPlayersAll(), GetPlayerNameColoured(p) +" has repicked |c001398F4" + GetHeroProperName(udg_dead[i]) + ".")
call SetUnitOwner(udg_heroselector[i], p, true)
call AddUnitToStockBJ(GetUnitTypeId(udg_dead[i]), GetUnitBelongsToTavern(udg_dead[i]), 1, 1) 
call PanCameraToTimedLocForPlayer(p,l,0)
call RemoveUnit(udg_dead[i])
set udg_dead[i] = null 
call RemoveLocation(l)
set p = null
set l = null
endfunction

Everything works fine except for one thing... whenever the unit is added to the tavern one other unit disappears from the stock and it keeps happening everytime this repick action gets called... I don't know how to fix this...

Anyone got a shot?

 

[GhostWolf]

I don't know why that bug occurs, but you do know you can do this this way, right ?

function RemoveHeroIcon takes player who returns nothing
local integer i = GetConvertedPlayerId(who)
if(i <= 5) then
call MultiboardSetItemIconBJ( udg_Multiboard, 1, ( i + 2 ), "" )
else
call MultiboardSetItemIconBJ( udg_Multiboard, 1, ( i + 3 ), "" )
endif
endfunction
function Repick takes player who returns nothing
local integer i = GetConvertedPlayerId(who)
local location l = GetUnitLoc(udg_heroselector[i])
call RemoveHeroIcon(who)
call DisplayTextToForce(GetPlayersAll(), GetPlayerNameColoured(who) +" has repicked |c001398F4" + GetHeroProperName(udg_dead[i]) + ".")
call SetUnitOwner(udg_heroselector[i], who, true)
call AddUnitToStockBJ(GetUnitTypeId(udg_dead[i]), GetUnitBelongsToTavern(udg_dead[i]), 1, 1) 
call PanCameraToTimedLocForPlayer(who,l,0)
call RemoveUnit(udg_dead[i])
set udg_dead[i] = null 
call RemoveLocation(l)
set l = null
endfunction

Since you already took the player, you don't need to declare him.

 

[DoOs_101]

RemoveHeroIcon is used for other purposes

 

[GhostWolf]

I meant about assigning the player "who" to a local player variable, you don't need to do that.