adding charges on a item each hit

[aitz-]

Hello,

I'm trying to do a trigger wich is :

A hero manipulates an item, manipulated item = collect darkness, on every hits on an ennemi building or unit it adds +1 charge on the item, every 666 charges the gold income/sec is improved by 1 for the player who has the hero manipualting this item, If owner of hero manipulating item writes -free it removes the item , creates a spell instead for the hero, the spell will replace the item and will have the same function like the item.

Is that possible?

also I tried doing it but there is no "add charges on an item" only "set remaining charges"

and is there a Damage Engine required for a such item?

 

[Bribe]

Yes, this will need DamageEngine. I'm not fond of using charges simply to store a number, but you can use its custom value.

• Attack with item
  • Events
    • Game - DamageEvent becomes Equal to 1.00
  • Conditions
    • IsDamageSpell Equal to False
    • DamageEventTarget is A structure Equal tk True
    • DamageEventSource has item <your item> Equal to True
  • Actions
    • Item - Set the custom value of <your item> to ((Custom value of <your item>) + 1)
    • If (Multiple conditions)
      • If - Conditions
        • (Custom value of <your item>) Equal to 666
      • Then - Actions
        • -------- You can add that function regarding gold increase here --------
        • Item - Set the custom value of <your item> to 0
      • Else - Actions

 

[aitz-]

It's not working, did the same trigger but it's not adding charges on the item.

• Collect darkness
  • Event
    • Game - DamageEvent becomes Equal to 1.00
  • Conditions
    • IsDamageSpell Equal to* FALSE
    • (DamageEventTarget is A building) Equal to* TRUE
    • (DamageEventSource has an item of type Collect Darkness) Equal to* TRUE
    • (Item-type of (Item being manipulated)) Equal to* Collect Darkness
• Actions
  • Objet - Set the custom value of (Item being manipulated) to ((Custom value of (Item being manipulated)) + 1)
  • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
    • If - Conditions
      • (Custom value of (Item being manipulated)) Equal to* 666
    • Then - Actions
      • Joueur - Add ((Custom value of (Item being manipulated)) + 1) to (Owner of (Item being manipulated)) Or Current
    • Else - Actions

 

[Bribe]

There is no (item being manipulated). You need to retrieve the item carried by unit of that type, store it to an item variable for reference.

 

[aitz-]

still not working...

• Collect darkness
  • Evénements
    • Partie - DamageEvent becomes Egal Ã* 1.00
  • Conditions
    • IsDamageSpell Egal Ã* FALSE
    • (DamageEventTarget is Un bâtiment) Egal Ã* TRUE
    • (DamageEventSource has an item of type Collect Darkness) Egal Ã* TRUE
    • (Item-type of (Item being manipulated)) Egal Ã* Collect Darkness
  • Actions
    • Set ColDarkness = (Item being manipulated)
    • Objet - Set the custom value of ColDarkness to ((Custom value of ColDarkness) + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • Si - Conditions
        • (Custom value of ColDarkness) Egal Ã* 666
      • Alors - Actions
        • Joueur - Add ((Custom value of ColDarkness) + 1) to (Owner of ColDarkness) Or actuel
      • Sinon - Actions

 

[Bribe]

Again, there is no item being manipulated. You have to select the item itself from the hero's inventory.

 

[aitz-]

hmm, seems I don't get it xD

 

[Bribe]

The JASS function is GetItemOfTypeFromUnitBJ. I'll have to check what that is in GUI.

 

[KILLCIDE]

The JASS function is GetItemOfTypeFromUnitBJ. I'll have to check what that is in GUI.

(Item-type of (Item carried by <unit> of type <item>)) Equal to <item>

I think this is the one.

 

[aitz-]

I tried this but it's not working either...

• Collect darkness
  • Event
    • Game - DamageEvent becomes Equal to* 1.00
  • Conditions
    • IsDamageSpell Equal to* FALSE
    • (DamageEventTarget is A building) Equal to* TRUE
    • (DamageEventSource has an item of type Collect Darkness) Equal to* TRUE
    • (Item-type of (Item carried by DamageEventSource of type Collect Darkness)) Equal to* Collect Darkness
  • Actions
    • Item - Set the custom value of (Item carried by DamageEventSource of type Collect Darkness) to ((Custom value of (Item carried by DamageEventSource of type Collect Darkness)) + 1)
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Custom value of (Item carried by DamageEventSource of type Collect Darkness)) Equal to* 666
      • Then - Actions
        • Player - Add ((Custom value of (Item carried by DamageEventSource of type Collect Darkness)) + 1) to (Owner of (Item carried by DamageEventSource of type Collect Darkness)) Current gold
      • Else - Actions

 

[KILLCIDE]

Hmmm are you actually testing this until it hits the custom value of 666?

Also, I don't think this is going to work. Maybe try changing it to Owner of damage source?

(Owner of (Item carried by DamageEventSource of type Collect Darkness))

 

[aitz-]

Hmmm are you actually testing this until it hits the custom value of 666?

Also, I don't think this is going to work. Maybe try changing it to Owner of damage source?

(Owner of (Item carried by DamageEventSource of type Collect Darkness))

Not working :/

 

[KILLCIDE]

So the gold isn't being added? Judging from the triggers, the gold will not be added until the unit carrying the item hits a structure 666 times.

Try adding a debug message that displays the custom value of the item everytime it's changed. Also add another message that will display when the gold is added.

 

[aitz-]

the item isn't getting charges...and i don't know how to do the "debug message"

 

[KILLCIDE]

the item isn't getting charges...and i don't know how to do the "debug message"

Custom value doesn't add charges to an item...

"Debug message" is just the simple Game - Display to (All Players) Text function

 

[aitz-]

Custom value doesn't add charges to an item...

"Debug message" is just the simple Game - Display to (All Players) Text function

ahhhhhhh i thougt it added charges lol

Nevermind xD

 

[KILLCIDE]

ahhhhhhh i thougt it added charges lol

Nevermind xD

Custom value is only used for triggers. It doesn't affect the game at all. Make the "666" smaller for testing purposes so you know the gold is being added properly.

 

[aitz-]

Custom value is only used for triggers. It doesn't affect the game at all. Make the "666" smaller for testing purposes so you know the gold is being added properly.

Hmm i lowered the value to 2 and it's not giving any gold to the owner...

 

[KILLCIDE]

Hmm i lowered the value to 2 and it's not giving any gold to the owner...

Did you add the debug messages to see if the actions are running? Add one that shows the custom value of the item each time its ran, and add another one when the gold gets added.

 

[aitz-]

Did the debugg message but the trigger isn't running...

 

[KILLCIDE]

Did the debugg message but the trigger isn't running...

That means theres something in your conditions isnt being passed.

From the looks of it, it will only run if the damage is physical and towards structure.

 

[aitz-]

Well i put a unit on the map in front of an ennemi structure and basically it should work i don't get why it isn't working...

if you could try doing the trigger and testing it and telling me whats wrong i could learn something ...

Because i'm trying 10000 times other things and it's still not working...

also if you could put the exemple trigger here it would be awesome and helpfull for me...

thanks

 

[KILLCIDE]

Well i put a unit on the map in front of an ennemi structure and basically it should work i don't get why it isn't working...

if you could try doing the trigger and testing it and telling me whats wrong i could learn something ...

Because i'm trying 10000 times other things and it's still not working...

also if you could put the exemple trigger here it would be awesome and helpfull for me...

thanks

Oh wait I see it. When youre adding the gold, change this to Owner of damage source

(Owner of (Item carried by DamageEventSource of type Collect Darkness))

Also get rid of this condition. You do not need it:

(Item-type of (Item carried by DamageEventSource of type Collect Darkness)) Equal to Collect Darkness

 

[aitz-]

I found the way to add charges on an item ! but i still don't know how to add gold, if there is a specific amount of charges, at owner of the item...

• Collect darkness2
  • Event
    • Game - DamageEvent becomes Equal to* 1.00
  • Conditions
    • IsDamageSpell Equal to* FALSE
    • (DamageEventTarget is A Building) Equal to* TRUE
    • (DamageEventSource has an item of type Collect Darkness) Equal to* TRUE
  • Actions
    • Item - Set charges remaining in (Item carried by DamageEventSource of type Collect Darkness) to ((Charges remaining in (Item carried by DamageEventSource of type Collect Darkness)) + 1)
    • game - Display to (All players) the text: (String((Charges remaining in (Item carried by DamageEventSource of type Collect Darkness))))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Charges remaining in (Item carried by DamageEventSource of type Collect Darkness)) Equal to* 2
      • Then - Actions
        • Player - Add ((Charges remaining in (Item carried by DamageEventSource of type Collect Darkness)) + 1) to (Owner of (Item carried by DamageEventSource of type Collect Darkness)) Current gold
        • Game - Display to (All players) the text: (String(((Owner of (Triggering unit)) Or actuel)))
      • Else - Actions

 

[KILLCIDE]

I found the way to add charges on an item ! but i still don't know how to add gold, if there is a specific amount of charges, at owner of the item...

• Collect darkness2
  • Event
    • Game - DamageEvent becomes Equal to* 1.00
  • Conditions
    • IsDamageSpell Equal to* FALSE
    • (DamageEventTarget is A Building) Equal to* TRUE
    • (DamageEventSource has an item of type Collect Darkness) Equal to* TRUE
  • Actions
    • Item - Set charges remaining in (Item carried by DamageEventSource of type Collect Darkness) to ((Charges remaining in (Item carried by DamageEventSource of type Collect Darkness)) + 1)
    • game - Display to (All players) the text: (String((Charges remaining in (Item carried by DamageEventSource of type Collect Darkness))))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Charges remaining in (Item carried by DamageEventSource of type Collect Darkness)) Equal to* 2
      • Then - Actions
        • Player - Add ((Charges remaining in (Item carried by DamageEventSource of type Collect Darkness)) + 1) to (Owner of (Item carried by DamageEventSource of type Collect Darkness)) Current gold
        • Game - Display to (All players) the text: (String(((Owner of (Triggering unit)) Or actuel)))
      • Else - Actions

Lol did you just ignore what I said? >.> Reread above.

Also, are you sure you want to use charges to store the number? Couldn't the user accidently "use" the item and lose a charge?

 

[aitz-]

also you can't use the item it's only to show your current charges.

and i need a periodic gold income for add to the player the gold.

 

[KILLCIDE]

also you can't use the item it's only to show your current charges.

and i need a periodic gold income for add to the player the gold.

If you want a periodic income, you will need a seperate trigger that adds the gold in a periodic timer.