Add ability for x seconds

[GIMLI_2]

[SOLVED]Add ability for x seconds

Hi,
i want to make a simple trigger in Jass which adds an ability to a unit for x seconds. I use TimerUtils, but i dont know how to catch the unit in the called function at the end of the duration.

Code

function RemoveDetector takes nothing returns nothing
    call UnitRemoveAbility(?UNIT?, 'A00S')
    call ReleaseTimer(GetExpiredTimer())
endfunction

function Trig_Detector_Conditions takes nothing returns boolean
    local timer t
    if (GetSpellAbilityId() == 'A00T')) then
        set t = NewTimer()
        call TimerStart(t, 30.00, false, function RemoveDetector)
        call UnitAddAbility(GetTriggerUnit(), 'A00S')
        set t = null
    endif
    return false
endfunction

//===========================================================================
function InitTrig_Detector takes nothing returns nothing
    local integer index
    set index = 0
    set gg_trg_Detector = CreateTrigger()
    loop
        call TriggerRegisterPlayerUnitEvent(gg_trg_Detector, Player(index), EVENT_PLAYER_UNIT_SPELL_EFFECT, null)
        set index = index + 1
        exitwhen index == bj_MAX_PLAYER_SLOTS
    endloop
    call TriggerAddCondition(gg_trg_Detector, Condition(function Trig_Detector_Conditions))
endfunction

 

[Bribe]

You need to set and get a unique integer to the timer's data which can be used as the index in a unit array for storing that caster.

Alternatively, you could just use Table and attach the unit directly to the timer's handle ID.

 

[GIMLI_2]

so i need an unit indexer? which one would you suggest?

 

[Bribe]

GUI Unit Indexer is compatible with vJass resources, so when you set the timer data you use the UnitUserData of the caster and to retrieve the caster when the timer expires you use udg_UDexUnits[GetTimerData(t)]

 

[GIMLI_2]

well, thats great. I'm familiar with your indexer.

So, what if i need some more information like some reals and integers? do i need to create a global array for those or use a table?

 

[Bribe]

That's when you can get into "structs" where you can attach a bunch of stuff to a single integer. Or use multiple Tables, a HashTable or a TableArray to store the data. Structs (arrays) are faster but it's your choice since this isn't something which is bottlenecked by speed.

 

[GIMLI_2]

That's when you can get into "structs" where you can attach a bunch of stuff to a single integer. Or use multiple Tables, a HashTable or a TableArray to store the data. Structs (arrays) are faster but it's your choice since this isn't something which is bottlenecked by speed.

ok, thank you. Do i even need a unit indexer then?

 

[Bribe]

For this particular situation, you're talking about attaching data to a unit. There are multiple ways to do this, as you can see, but using the unit's custom value is the fastest.

A unit indexer also gives you access to a unit the instant it exists and when it is removed from the game forever. For simplicity, GUI Unit Indexer doesn't give you access to the removed unit the instant it's removed as then you'd need to get into Object Editor which would make it's import process more than just copy&paste the trigger. GUI Unit Event covers the instant a unit is removed from the game.

 

[GIMLI_2]

ok, but i would need to create global arrays for each trigger that uses timers then?

 

[Bribe]

That would be the case if you use structs and data attachment, but would not be the case if you use hashtables or Table.

If you're looking to make life easier, you could make this use Spell System.

function RemoveDetector takes nothing returns boolean
    call UnitRemoveAbility(udg_Spell__Caster, 'A00S')
    return false
endfunction

function Trig_Detector_Conditions takes nothing returns boolean
    set udg_Spell__Time = 30.00
    call UnitAddAbility(udg_Spell__Caster, 'A00S')
    return false
endfunction

//===========================================================================
function InitTrig_Detector takes nothing returns nothing
    set udg_Spell__Trigger_OnEffect = CreateTrigger()
    call TriggerAddCondition(udg_Spell__Trigger_OnEffect, Condition(function Trig_Detector_Conditions))
    set udg_Spell__Trigger_OnLoop = CreateTrigger()
    call TriggerAddCondition(udg_Spell__Trigger_OnLoop, Condition(function RemoveDetector))
    call TriggerExecute(gg_trg_Spell_System)
endfunction

 

[Chaosy]

There used to be a system in the spell section for this but it was removed for whatever reason.

 

[GIMLI_2]

If you're looking to make life easier, you could make this use Spell System.

There used to be a system in the spell section for this but it was removed for whatever reason.

maybe i'll use this later, but for now i want to learn new stuff

1

struct Variables
     unit caster
 endstruct

 function AfterTimer takes nothing returns nothing
     local timer t=GetExpiredTimer()
     local Variables var=GetTimerData(t)
     call SetUnitX(var.caster)
     call DestroyTimer(t)
     set t=null
 endfunction

 function test takes nothing returns nothing
     local timer t=CreateTimer()
     local Variables var=Data.create()
     set var.caster=CreateUnit(...)
     call SetTimerData(t, var)
     set t=null
 endfunction

2

globals
     unit array caster[]
endglobals

 function AfterTimer takes nothing returns nothing
     local timer t=GetExpiredTimer()
     local unit u = caster[GetTimerData(t)]
     call SetUnitX(u)
     call DestroyTimer(t)
     set t=null
 endfunction

 function test takes nothing returns nothing
     local timer t=CreateTimer()
     set SomeUnit=CreateUnit(...)
     call SetTimerData(t, GetUnitUserData(SomeUnit))
     set caster[GetUnitUserData(SomeUnit)] = SomeUnit
     set t=null
 endfunction

which of those 2 is the better way? I'm not even sure if it works correctly tbh.

 

[Bribe]

The second option will allow you to attach data to the unit instead of the timer via the unit's UserData. However, you could simplify it even more. If you're using GUI Unit Indexer, you can avoid creating a unit array since there already exists udg_UDexUnits[] which is already set to that unit.

 

[GIMLI_2]

ok, thanks.
so both options are fine?

 

[Bribe]

Yep, option 1 doesn't require Unit Indexer, option 2 doesn't require a struct.