[JASS] About location leaks

[envenger]

Hi guys..

Well i have a trigger where i need to use location a lot of times.
I remove the location after use like this

        set loc1 = GetUnitLoc(rotatecenter[n])
        set z1 = GetLocationZ(loc1)
        set loc2 = GetUnitLoc(rotateunit[n])
        set z2 = GetLocationZ(loc2)
        call SetUnitFlyHeight(rotateunit[n], (150 + z1 - z2) , 0)
        call RemoveLocation(loc1)
        call RemoveLocation(loc2)

Some one said i could use a global location instead of a local location and use move location all the time it will work and i don't need to remove it

I don't think mui will be a problem. So which do you think will be more efficient.

 

[watermelon_1234]

The global location method. You're only using one location the whole time instead of creating locations every time you want to get the unit's z.

 

[envenger]

The global location method. You're only using one location the whole time instead of creating locations every time you want to get the unit's z.

Can you do the trigger? Should i use move location or just keep on setting new ones?

 

[watermelon_1234]

It would look something like this:

    globals
        location loc = Location(0, 0)
    endglobals
    
    function GetPointZ takes real x, real y returns real
        call MoveLocation(loc, x, y)
        return GetLocationZ(loc)
    endfunction
    
    function GetUnitZ takes unit u returns real
        return GetPointZ(GetUnitX(u), GetUnitY(u))
    endfunction

You would need to have Jasshelper to declare a global block like that and should probably make the global have a longer name to avoid conflicts.

EDIT:
@Spartipilo: He needs at least one location to get the z of stuff.

 

[Spartipilo]

A good way to handle locations is not using them, but rather use X/Y coordenates Avoid creating / destroying the location

 

[baassee]

A good way to handle locations is not using them, but rather use X/Y coordenates Avoid creating / destroying the location

Not what he is asking about.

Anyway just use watermelon's method.

 

[HappyTauren]

A good way to handle locations is not using them, but rather use X/Y coordenates Avoid creating / destroying the location

Yeah, but try to return the

GetLocationZ(loc)

value without using locations.