3rd Person Camera + Smooth Arrow Key Movement 1.4

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

15:38, 5th Jan 2015
Maker: You have memory leaks.
Additionally this is just another arrow movement system
and it offers nothing new or interesting.
You could try to make it more original and interesting.

 

[Gismo359]

Post the code/triggers in the description and change the name to something suitable - atm, people will have no idea what this is.

 

[deathismyfriend]

http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

 

[Vinz]

Why is the title 1.00 Alpha? Give it a nice name.

Posting the code also helps people who

a.) Don't have Wc3 because of old age
b.) Are on mobile
c.) Are lazy

 

[DARKLORD24]

Alright guys, i`ve added a title to it, and posted the triggers, hopefully if there is some bug it will get noticed this way.

I`m kinda new here so, i had no clue how to post here but i figured it out.

Anyway please test my system and give me feedback, i`m curious how you find it to be.

 

[deathismyfriend]

Anything used twice or more should be stored in a variable and the variable should be used.
Example: (Player number of (Triggering player))
Variables are faster and more efficient than multiple function calls.

You should not use waits in spells / systems. They are inaccurate among other things. See my tutorial Things you should know when using triggers / gui. Link is in my sig below.

Never use integer A / B. They are inefficient and slow. Make your own custom integer to do the looping.

Only use And all conditions inside an or condition block.
please read the first ITE to find out the reason.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
    • And - All (Conditions) are true

Every 0.01 seconds is to fast. You should use every 0.03

You should use a list or player force to make looping more efficient rather than looping through all 11 indexes.

This currently has bugs as you can exit from the camera locking.

This is currently more of a template as it does not allow for configuration.

You should check out my camera system http://www.hiveworkshop.com/forums/spells-569/camera-lock-system-v2-5-0-1-a-239423/. It does tons of more stuff than this one. If you want to add the useability to yours and try to update it it may be approved but it is far from being approved in its current state.

 

[stan0033]

It's nice, man. But the acceleration is too much. Can't you make it move/accelerate with/to normal speed?

 

[Vincent_Freeman]

My car stops and don't move for some reason after a few seconds of actual driving. It turns round, but it doesn't move forward or backwards for some reason.
What could it be?

 

[Trigger.edge]

looks good but... why after a while I can not speed?

 

[DARKLORD24]

Anything used twice or more should be stored in a variable and the variable should be used.
Example: (Player number of (Triggering player))
Variables are faster and more efficient than multiple function calls.

Alright i will modify this, but now i`m concentrating on bug elimination first, then after no bugs are left i will optimize.

You should not use waits in spells / systems. They are inaccurate among other things. See my tutorial Things you should know when using triggers / gui. Link is in my sig below.

Unless you suggest an alternative, i have no idea what you want me to do, i must have that wait in it, otherwise if you press the LEFT,RIGHT keys and dont hold it for atleast 1 second, it wont steer the car, and it will look choppy.

Never use integer A / B. They are inefficient and slow. Make your own custom integer to do the looping.

Should I use Pick every player... is that faster?

Only use And all conditions inside an or condition block.

I do use it like this, there was 1 case where I didn't, so i fixed that, thanks.

Every 0.01 seconds is to fast. You should use every 0.03

I`ve set it to 0.03 but now it feels choppy, i have to change some setting to the camera to make it look better, but you are right 0.01 with 11 players might cause some lagg.However testing it all by myself it was very smooth.

You should use a list or player force to make looping more efficient rather than looping through all 11 indexes.

So Pick every player... is better than the for loop or not?

This currently has bugs as you can exit from the camera locking.

Please specify i have no idea what you are talking about

This is currently more of a template as it does not allow for configuration.
You should check out my camera system http://www.hiveworkshop.com/forums/spells-569/camera-lock-system-v2-5-0-1-a-239423/. It does tons of more stuff than this one. If you want to add the useability to yours and try to update it it may be approved but it is far from being approved in its current state.

It might get rejected at first but i`m woking on it to be approved later, i really really want to fix this as later i might make a car racing map.

It's nice, man. But the acceleration is too much. Can't you make it move/accelerate with/to normal speed?

Of course you can, in the init trigger you can set the PL_STATS_TOPSPEED[playerindex] array, as you wish to be the top speed, the car will accelerate until it hits the top speed.

Also the PL_STATS_ACCELERATION[1] = 0.25 for player 1 might be smaller. Set it to 0.05 for smaller acceleration.

Remember there are 3 variables that are important, which can be used for car game:

Set PL_STATS_HANDLING[] = steering speed
Set PL_STATS_TOPSPEED[] = max speed (accelerates until it hits this)
Set PL_STATS_ACCELERATION[] = the acceleration increment size (better cars accelerate faster than bad cars)

My car stops and don't move for some reason after a few seconds of actual driving. It turns round, but it doesn't move forward or backwards for some reason.
What could it be?

looks good but... why after a while I can not speed?

I`ve observed that, it is because the acceleration and deceleration is not properly synchronized, so far i can not figure out how to do that, maybe somebody can help me please

 

[Vinz]

Instead of adding the players manually, you can loop from 1 to 12 at map init and add Events to corresponding trigger.

Also why is Player 12 exempted?

 

[DARKLORD24]

Instead of adding the players manually, you can loop from 1 to 12 at map init and add Events to corresponding trigger.

Also why is Player 12 exempted?

Wait hold on, the Init trigger is not finished, is only for demonstration to test it on player 1. I will work on that on my next version.

Player 12 is exempted because there must be a computer player in a game to be able to play, and even if you somehow with jass or something go around this, i`ve never seen a map where you dont have atleast 1 NPC player, especially for a car game (where i suppose you can use my trigger) you need a tournament NPC player or something like that, Neutral Passive is just not good enough.

----------------------------------------------------------------------

Ok at the moment i`m woking on the spell, wait 30 maybe 45 minutes and i will post the new version where i will definitely correct that movement bug ASAP, i have a very good idea how to synchronize the acceleration/deceleration, i will use the rotation scheme to do it, because there even if you hold the RIGHT/LEFT arrow simultaneously it works perfectly, the same way i will do with UP/DOWN arrows. While the deceleration will be an absolute value always, so that it will always go to 0 speed when substracted, while the BACKWARDS move will be negative speed with a mirror NEGATIVE TOP SPEED at its cap, so that if you push the UP/DOWN simultaneously it will either substract/add a speed to it, and because the Reverse move is slower than the forward acceleration, it will go ahead, but it will slow down the car, as if its only the ACCELERATION pushed, then the car will accelerate at TOP SPEED.

Version 1.1

Changelog:
-Fixed sliding bug (fractional division leftover could cause the car to not stop is fixed)
-Fixed acceleration/deceleration sync, now you can do both at a time and it will add/subtract from the current speed
-Added custom car model and horn effect
-Reworked the triggers and removed unnecesary variables
-Added speedometer, however it might memory leak, but it is not meant to use in the main system, it is just for misc/debug stuff for now, the main system is MOVEMENTSYSTEM folder, everything else is misc or init stuff

I`ve fixed the car stopping/ and or going wild like a boomerang if keys are pressed in bad order, it was a crucial bug so im glad that its fixed, i had to rework the triggers a bit, and it was easy to fix.

Past version used unit facing (Car facing) for forward and (Car Facing-180*) for backwards which caused the bug as if you cant add or subtract speed to different angled variables, so i`m not only using Car facing, but the reverse direction is now using negative speed and negative top speed.So if i decide to work on a speedometer too then i will have to use absolute value of that, but otherwise its perfect now.

On the other hand the camera system is still a bit too crude and choppy but i will work on that, maybe i will use a custom camera system for that, as suggested by deathismyfriend

I will also try to add a collision system, and a car health system if it collides it loses health, maybe some nice animations for the car to get on fire if it collides with something.

 

[deathismyfriend]

Using an integer loop is faster than a player force loop. But you need to use an indexing type when players leave they need to be removed. When the game starts only the playing players should be put into the player force.
Player force will be better and easier to use here.

There were many cases where you used an and all condition block inside the ITE.

You lock you camera to a unit to prevent a player from moving the camera. This locking can be stopped by the keyboard (I forget the button/s).

About waits use timers / triggers with a time elapsed event to get rid of the use of the waits. Look at my tutorial for more information. Things You Should Know When Using Triggers / GUI

 

[DARKLORD24]

Using an integer loop is faster than a player force loop. But you need to use an indexing type when players leave they need to be removed. When the game starts only the playing players should be put into the player force.
Player force will be better and easier to use here.

What if i leave the integer loop but right at the beginning i test if the player is playing and or is a human player.
Will that be efficient and fast, faster than player loop?

There were many cases where you used an and all condition block inside the ITE.

I`m sure i fixed them all

You lock you camera to a unit to prevent a player from moving the camera. This locking can be stopped by the keyboard (I forget the button/s).

I will look into this

About waits use timers / triggers with a time elapsed event to get rid of the use of the waits. Look at my tutorial for more information. Things You Should Know When Using Triggers / GUI

Please give link, the only thing i found there is that you say that a 0.75 sec wait is more efficient, yet i have 0.1 second and the timing itself is not that important, its only for rotation effect if it delays 0.1-0.3 then its ok, the player will experience a bit of rotation sliding but i think its acceptable at that level.

 

[deathismyfriend]

Putting players in a permanent player force will be faster than always searching through a loop each iteration.

The link is in my sig.

Also post triggers in map description.

 

[DARKLORD24]

Putting players in a permanent player force will be faster than always searching through a loop each iteration.

The link is in my sig.

Also post triggers in map description.

Alright i will do that, and test for player if its human, or of its in game in case of somebody leaves to be faster.

However, i will disable these tests, since until i finish this system i would like to experience how it feels if all 11 are in.Because if i test it in 1st person alone, i would only experience how it feels with 1 person playing, but i want to experience how it feels with 11 person playing, to see if its lagging too much or what.

Anyway i really appreciate your feedback and help man, please continue to feedback, i need it.

 

[GywGod133]

• The name of the trigger must be read properly. (Optional) Ex: SP Int, SP Loop, etc • 0.01 using periodic time , some computers will become laggy . so use 0.03 instead or above. • Do not use Integer A or B , use an integer variable instead • Dont use Wait • You can also do it like this Example Example Events Map initialization Conditions Actions For each (Integer SP_TempInt) from 1 to 11, do (Actions) Loop - Actions Trigger - Add to LEFTxxPRESS <gen> the event (Player - (Player(SP_TempInt)) Presses the Left Arrow key) Trigger - Add to LEFTxxRELEASE <gen> the event (Player - (Player(SP_TempInt)) Releases the Left Arrow key) Trigger - Add to RIGHTxxPRESS <gen> the event (Player - (Player(SP_TempInt)) Presses the Right Arrow key) Trigger - Add to RIGHTxxRELEASE <gen> the event (Player - (Player(SP_TempInt)) Releases the Right Arrow key) Trigger - Add to FORWARDxxPRESSxxGAS <gen> the event (Player - (Player(SP_TempInt)) Presses the Up Arrow key) Trigger - Add to FORWARDxxRELEASE <gen> the event (Player - (Player(SP_TempInt)) Releases the Up Arrow key) Trigger - Add to BACKWARDSxxPRESSxxBREAK <gen> the event (Player - (Player(SP_TempInt)) Presses the Down Arrow key) Trigger - Add to BACKWARDSxxRELEASE <gen> the event (Player - (Player(SP_TempInt)) Releases the Down Arrow key) Custom script: call DestroyTrigger( GetTriggeringTrigger())

 

[DARKLORD24]

• The name of the trigger must be read properly. (Optional) Ex: SP Int, SP Loop, etc • 0.01 using periodic time , some computers will become laggy . so use 0.03 instead or above. • Do not use Integer A or B , use an integer variable instead • Dont use Wait • You can also do it like this Example Example Events Map initialization Conditions Actions For each (Integer SP_TempInt) from 1 to 11, do (Actions) Loop - Actions Trigger - Add to LEFTxxPRESS <gen> the event (Player - (Player(SP_TempInt)) Presses the Left Arrow key) Trigger - Add to LEFTxxRELEASE <gen> the event (Player - (Player(SP_TempInt)) Releases the Left Arrow key) Trigger - Add to RIGHTxxPRESS <gen> the event (Player - (Player(SP_TempInt)) Presses the Right Arrow key) Trigger - Add to RIGHTxxRELEASE <gen> the event (Player - (Player(SP_TempInt)) Releases the Right Arrow key) Trigger - Add to FORWARDxxPRESSxxGAS <gen> the event (Player - (Player(SP_TempInt)) Presses the Up Arrow key) Trigger - Add to FORWARDxxRELEASE <gen> the event (Player - (Player(SP_TempInt)) Releases the Up Arrow key) Trigger - Add to BACKWARDSxxPRESSxxBREAK <gen> the event (Player - (Player(SP_TempInt)) Presses the Down Arrow key) Trigger - Add to BACKWARDSxxRELEASE <gen> the event (Player - (Player(SP_TempInt)) Releases the Down Arrow key) Custom script: call DestroyTrigger( GetTriggeringTrigger())

Note that i`ve updated the map, fixed many stuff so please review it again.

Also i`m using now Pick every player ... , because deathismyfriend told that its faster than the integer, (not that it changes anything in the framepersecond, but probably its better with more players)

• Can you prove that your trigger inside the integer is faster than the one mentioned by deathismyfriend?
  If not then i will use the Pick every player ...
• Also if i were to use 0.03 then the camera gets too choppy i will test them map this afternoon with more players but i dont guarantee anything.
• Also give me an alternative to wait, all of you said that i should not use it, but none of you gave any alternative to it...

Putting players in a permanent player force will be faster than always searching through a loop each iteration.

The link is in my sig.

Also post triggers in map description.

Alright i`ve updated the map fixed many stuff, and did as you suggested, now i got a player group and a variable for player number of picked player and also its memory leak free.

However i didnt experienced any change between this method and the for loop integer method, the FPS is the same with both methods, are you sure this one is faster??

 

[GywGod133]

Also give me an alternative to wait, all of you said that i should not use it, but none of you gave any alternative to it...

Indexing Function. this is the most important in making spell

so that you can make alternative wait

 

[deathismyfriend]

However i didnt experienced any change between this method and the for loop integer method, the FPS is the same with both methods, are you sure this one is faster??

Yes it is definitely faster as it will only loop through 1 person if only one person is playing rather than always running through all 12 players.

Also As I have said put this.

• Set GROUP_PLAYINGPLAYERS = (All players controlled by a User player)

into a map init trigger. Never destroy this group never set it to anything else.

You also need to only add players if they are a player slot and that they are playing. Then you need another trigger to remove the players that leave.

Indexing Function. this is the most important in making spell

so that you can make alternative wait

I also said that way is better.

 

[IcemanBo]

System seems cool. I wanted to read the code, but the variable names are not really readable. Could you improve it?

First, if you use capitals-only names, you only should use it for constant variables. (if you never change it's value)
The namings don't have a proper structure. You should define it for and by the system, for example for GUI I prefer something like: Prefix + underscope + VariableName.

 

[DARKLORD24]

Indexing Function. this is the most important in making spell

so that you can make alternative wait

I have no idea what that is can you please explain more detailed not just in hint words, thanks

System seems cool. I wanted to read the code, but the variable names are not really readable. Could you improve it?

First, if you use capitals-only names, you only should use it for constant variables. (if you never change it's value)
The namings don't have a proper structure. You should define it for and by the system, for example for GUI I prefer something like: Prefix + underscope + VariableName.

Allright i will do that in the next update, i thought its easy to read as i named it first the role of the variables + then a custom name.

Yes it is definitely faster as it will only loop through 1 person if only one person is playing rather than always running through all 12 players.

Also As I have said put this.

• Set GROUP_PLAYINGPLAYERS = (All players controlled by a User player)

into a map init trigger. Never destroy this group never set it to anything else.

You also need to only add players if they are a player slot and that they are playing. Then you need another trigger to remove the players that leave.

I also said that way is better.

Alright its done 1.3 version, corrected that, its logical btw to only go through once since no PC players will be added.Thanks for this observation.

Btw can anyone please detailed explain how to replace the wait, because now i`m really confused, please help with that.Thanks!

 

[deathismyfriend]

I have no idea what that is can you please explain more detailed not just in hint words, thanks

You should stick with a player group as it will be slightly faster in most cases.

Btw can anyone please detailed explain how to replace the wait, because now i`m really confused, please help with that.Thanks!

Look at my tutorial Things you should know when using triggers / gui. Link is in my sig. The chapter on how to index will show you how to index a spell. It is the same way for the above system.


You do this in your init.

• ((Picked player) slot status) Equal to Is playing

You can't use a player loop for checking players on init. Change trigger to 0.00 time elapsed.
You also need this

• ((Picked player) controller) Equal to User

The above line is needed because even computer players are considered as playing. These two conditions will only add users that are playing. It will not add computer players.
You should also use a player variable to store picked player as it will be used more than once.

 

[DARKLORD24]

You should stick with a player group as it will be slightly faster in most cases.



Look at my tutorial Things you should know when using triggers / gui. Link is in my sig. The chapter on how to index will show you how to index a spell. It is the same way for the above system.


You do this in your init.

• ((Picked player) slot status) Equal to Is playing

You can't use a player loop for checking players on init. Change trigger to 0.00 time elapsed.
You also need this

• ((Picked player) controller) Equal to User

The above line is needed because even computer players are considered as playing. These two conditions will only add users that are playing. It will not add computer players.
You should also use a player variable to store picked player as it will be used more than once.

Whats wrong with:

• Set GROUP_PLAYINGPLAYERS = (All players controlled by a User player)

Doesnt this substitute for

• ((Picked player) controller) Equal to User

I mean there will be only 1 computer player , player12 which will remain constant, there will be no new computer players added inside the game or anything like that.

 

[deathismyfriend]

Whats wrong with:

• Set GROUP_PLAYINGPLAYERS = (All players controlled by a User player)

Doesnt this substitute for

• ((Picked player) controller) Equal to User

Yes it substitutes for that. But you also need to check if the player is currently playing. That will add players 1 to 11 even if players 2 through 6 are not playing.

You do this in your init.

• ((Picked player) slot status) Equal to Is playing

You can't use a player loop for checking players on init. Change trigger to 0.00 time elapsed.
You also need this

• ((Picked player) controller) Equal to User

The above line is needed because even computer players are considered as playing. These two conditions will only add users that are playing. It will not add computer players.

You can then remove the ITE in your player group since only players that are playing will be in there.
And as said above the map init event needs to be changed to 0.00 time elapsed.

I mean there will be only 1 computer player , player12 which will remain constant, there will be no new computer players added inside the game or anything like that.

A system uploaded to here needs to be able to be used for maps that use all 12 players. Also as I said above it needs to be changed because. This system needs to be expanded to allow for all 12 players.

 

[DARKLORD24]

Yes it substitutes for that. But you also need to check if the player is currently playing. That will add players 1 to 11 even if players 2 through 6 are not playing.


You can then remove the ITE in your player group since only players that are playing will be in there.
And as said above the map init event needs to be changed to 0.00 time elapsed.



A system uploaded to here needs to be able to be used for maps that use all 12 players. Also as I said above it needs to be changed because. This system needs to be expanded to allow for all 12 players.

Ok i just updated my system now, so come back and check the changes please.

I do check the players that are curretly playing, i dont know why you said i dont.
Right at the beginning of the new init (elapsed 0.00 seconds)

• Set Group_Playing_Players = (All players controlled by a User player)

This line completely replaces the

• ((Picked player) controller) Equal to User

because i only test it once at the beginning of the map elapsed 0.00 seconds, instead of testing it at every 0.01 seconds will just slow down the map, because either way there will be no more PC players added during the map.

As for

• ((Picked player) slot status) Equal to Is playing

That is also tested at init, and also at every 0.01 second it case there is a leaver player to not loop through that.

I also did as you requested, moved the picked player and triggering player into a variables to be more faster.

Also i resolved the wait stuff with something very simple yet effective, as i didnt understood how that indexing stuff worked.

So please review my code again, as it seems that you didnt saw the new updates.