Charge v1.00

[Moderator]

12:31, 13th Jul 2010
TriggerHappy:

You're using the wrong cast event.
You are also doing a lot of weird things like pausing the units, forcing hotkeys, and disabling and enabling spells for players. Really they're all quite useless.

 

[Klingo]

well , your spell is rigged.

 

[MortAr]

• Unit - Add a 0.40 second Generic expiration timer to (Last created unit)

Remove/kills the dummy, last trigger is completly useless with this.

• Custom script: if (GetLocalPlayer() == GetTriggerPlayer()) then
  • Sound - Play Error <gen>
  • Custom script: endif

Can and will cause desync in multiplayer.

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
  • (Distance between POINT[0] and POINT[1]) Less than 700.00

You can't imagine how annoying this is.. better remove it.

• Custom script: call IssuePointOrderLocBJ( GetEnumUnit(), "dreadlordinferno", udg_POINT[3] )

Will only confuse people, better use the GUI function.

 

[ALiEN95]

well , your spell is rigged.

what you mean?

1.)

• Unit - Add a 0.40 second Generic expiration timer to (Last created unit)

Remove/kills the dummy, last trigger is completly useless with this.
2.)

• Custom script: if (GetLocalPlayer() == GetTriggerPlayer()) then
  • Sound - Play Error <gen>
  • Custom script: endif

Can and will cause desync in multiplayer.
3.)

• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
  • If - Conditions
  • (Distance between POINT[0] and POINT[1]) Less than 700.00

You can't imagine how annoying this is.. better remove it.
4.)

• Custom script: call IssuePointOrderLocBJ( GetEnumUnit(), "dreadlordinferno", udg_POINT[3] )

Will only confuse people, better use the GUI function.

1.)
not true
if i just kill him it will stay to long
if i dont remove him after 0.40 sec it will again stay to long because it will decay
(and i cant fix it with changeing death type)
2.)
how to fix it?,or i just remove it?
3.)
its easy to remove/decrease but it should be a part of this spell because i think its stupid that you can charge to 100 range -.-
4.)
GUI sucks in that -.- instead typeing a string ID i have to list all that s... and find it -.- (il make it if needed,but it should´t be hard to get it like this)

 

[xDsss]

Cant see leaks btw nice concept t^

 

[Maker]

Use |n to change line in tooltip description.

Maybe try 0.03 instead of 0.06 in the looping trigger.

 

[Klingo]

I mean , 1500 damage , 10 seconds stun , High cast range (it's normal for your spell) Plus low cooldown. Maybe you should balance a bit your spell.

 

[MortAr]

I mean , 1500 damage , 10 seconds stun , High cast range (it's normal for your spell) Plus low cooldown. Maybe you should balance a bit your spell.

You do realize that's your part of the whole thing?

 

[ALiEN95]

Cant see leaks btw nice concept t^

ty

Use |n to change line in tooltip description.

next time xD

Maybe try 0.03 instead of 0.06 in the looping trigger.

nah,its fine as it is and if someone wants it he can change it

I mean , 1500 damage , 10 seconds stun , High cast range (it's normal for your spell) Plus low cooldown. Maybe you should balance a bit your spell.

its easy to change if you want to...all in object editor..i know its a bit unbalanced but all balance of spell depends on map itself anyway

1.)
You're using the wrong cast event.
2.)
You are also doing a lot of weird things like pausing the units,
3.)
forcing hotkeys,
4.)
and disabling and enabling spells for players.
5.)
Really they're all quite useless.

1.)
ok il change it -.-
Edit: Actually the event is fine and if i change it it will bug the spell ,so there is no reason to use another event (didnt see any rules about that)
2.)
that is the only way i know to make unit stop at that event, (event at trigger "S 001 minimum range")
please show me better way if you know it
3.)
i did it so that it looks like a real minimum range of spell
4.)
i just disable>use>enable Wind Walk to make icon of Wind Walk invisible
please show me better way to make unit go trough units but not buildings too
5.)
if its useless i would not do that!,remove it and see if the spell would be normal
you should of check if its useless or not if you want to review someone´s spell


dont be afraid of weird things.....
the only thing i should fix is sound error (i guess)

 

[DarkWerewolf]

I liked it.

 

[Dr Super Good]

Ok, I agree with trigger happy on many points.

pausing the units

I agree, this is probably unnescescary. The reason it does not stop is cause of when the event runs, instead of inturpting the triggering order it instead ques up any issued orders to the unit (cause the event triggering order still has to be fully issued). The most common work around without pausing the unit is to simly run a timer with 0 timeout which runs code to issue a new order to the unit, or atleast that is what I have seen. The whole problem though is what about qued order stacks, will both these methods not disrupt the que which can be annoying...

forcing hotkeys

This can be bug prone. For example if he shift qued up the order of the ability it could result in him suddenly having a totally different and unrelated unit casting or getting ready to use an ability which would be annoying as hell and clearly a bug. When forcing a player to press a hotkey you have to make sure that the unit is currently active in his interface (which I can only imagine happens if it is the only unit selected as he could be tabing through a group).

disabling and enabling spells for players

This is unnescescary and just hogs up unit ability data. Instead add the dummy windwalk to the hero and get him to cast it then remove it. If it still causes problems then add a disabled speelbook ability containing the windwalk ability and get the hero to use it and finally remove the permantly disabled spellbook ability. Remember that you can only choose so many abilities in the object editor for a hero and thus those slots are important and might be required by potential users.

What TriggerHappy did not point out is the fact you are always executing code 16.66... times a second which is a source of wasted processor time when added up the entire game. Instead of checking if the group is empty 16.66 times a second before running the code, just run the code but when you do make the group empty turn the trigger off so it runs 0 times a second. When you add a unit to the group you can then turn the trigger back on. The result is thousands of saved executions over the course of a game and each execution nolonger needs to evaluate a condition saving time when it is in use as well.

The problem is this spell is not very unique. Infact, hundreds of people have made this exact sort of spell before and many of them have used JASS and more efficent programming techniques (avoiding unnescescary hashtable lookups) to achieve a more usable and efficent product. Although I have to say you do have the potential to become a pretty good GUI trigger maker so do not be put off by the rejection, just this concept has been done too many people, of which some of them use scripting techniques which are unable to be reproduced in GUI efficently.

 

[ALiEN95]

Ok, I agree with trigger happy on many points.


1.) - stopping unit when issued an order
I agree, this is probably unnescescary. The reason it does not stop is cause of when the event runs, instead of inturpting the triggering order it instead ques up any issued orders to the unit (cause the event triggering order still has to be fully issued). The most common work around without pausing the unit is to simly run a timer with 0 timeout which runs code to issue a new order to the unit, or atleast that is what I have seen. The whole problem though is what about qued order stacks, will both these methods not disrupt the que which can be annoying...


2.) - hotkey
This can be bug prone. For example if he shift qued up the order of the ability it could result in him suddenly having a totally different and unrelated unit casting or getting ready to use an ability which would be annoying as hell and clearly a bug. When forcing a player to press a hotkey you have to make sure that the unit is currently active in his interface (which I can only imagine happens if it is the only unit selected as he could be tabing through a group).

3.) - wind walk
This is unnescescary and just hogs up unit ability data. Instead add the dummy windwalk to the hero and get him to cast it then remove it. If it still causes problems then add a disabled speelbook ability containing the windwalk ability and get the hero to use it and finally remove the permantly disabled spellbook ability. Remember that you can only choose so many abilities in the object editor for a hero and thus those slots are important and might be required by potential users.

4.)
What TriggerHappy did not point out is the fact you are always executing code 16.66... times a second which is a source of wasted processor time when added up the entire game. Instead of checking if the group is empty 16.66 times a second before running the code, just run the code but when you do make the group empty turn the trigger off so it runs 0 times a second. When you add a unit to the group you can then turn the trigger back on. The result is thousands of saved executions over the course of a game and each execution nolonger needs to evaluate a condition saving time when it is in use as well.

5.)
The problem is this spell is not very unique. Infact, hundreds of people have made this exact sort of spell before and many of them have used JASS and more efficent programming techniques (avoiding unnescescary hashtable lookups) to achieve a more usable and efficent product. Although I have to say you do have the potential to become a pretty good GUI trigger maker so do not be put off by the rejection, just this concept has been done too many people, of which some of them use scripting techniques which are unable to be reproduced in GUI efficently.

1.)
(just a question,can any sort of JASS make it without timer? )
i can do it with timer but i tough this is a good solution to avoid it
2.)
than i guess i will have to use blink to trigger the spell because it has minimum range at ability data
3.)
i think abilities in spellbook cannot be ordered to units...
(il check it again ...)
4.)
i tough checking 1 condition cant be a problem,well il do it that way,
5.)
true,but i think my effects are nice xD,actually i was a bit bored too and see how to actually make spells
-JASS (better bud harder...)
its a program language and i dont like to read it,also you have to be careful about everyy step,but i guess its not that hard when you get a hold of it


update 1.01

blink will be used like a triggering ability with minimum range
-no minimum range trigger,yeah the trigger does sux
-Run trigger will be off when the group is empty and on when the goup is not empty
-im not sure how to do this wind walk thing,il try it will spellbook
-im not sure will i be able to update this at all xD