- Joined
- May 26, 2009
- Messages
- 1,829
Thanks for your submission to the spell section, I'm setting this to needs fix for the time being for the following reasons:
- This site has an English-only rule, please translate the resource name
- lacks a proper description
- Do not use ripped models we do not have permission to use, remove it from the uploaded map (it also unnecessarily inflates the file size)
Now for some notes on the code:
- Fix the indentation of your code
- The configuration is lacking, doesn't contain many values which it should (such as dummy creation data, effects)
- Use a timer for loops instead of adding a timer event (this allows you to easily stop the loop when you don't need it to be enabled, which should also be done)
- Store values which are used multiple times into temporary variables (notably GetUnitFacing +- 70)
- The spell has very little implementation of leveling - this should have more options other than damage
- Don't use terrain deformations, they always leak
- Text tags should be optionally included (boolean configurable would be my suggestion) due to the texttag limits in maps
- You don't need to store hashtable values into locals - hashtable access is O(1)
- Lacks documentation
- This site has an English-only rule, please translate the resource name
- lacks a proper description
- Do not use ripped models we do not have permission to use, remove it from the uploaded map (it also unnecessarily inflates the file size)
Now for some notes on the code:
- Fix the indentation of your code
- The configuration is lacking, doesn't contain many values which it should (such as dummy creation data, effects)
- Use a timer for loops instead of adding a timer event (this allows you to easily stop the loop when you don't need it to be enabled, which should also be done)
- Store values which are used multiple times into temporary variables (notably GetUnitFacing +- 70)
- The spell has very little implementation of leveling - this should have more options other than damage
- Don't use terrain deformations, they always leak
- Text tags should be optionally included (boolean configurable would be my suggestion) due to the texttag limits in maps
- You don't need to store hashtable values into locals - hashtable access is O(1)
- Lacks documentation