[Snippet] WorldBounds

[Nestharus]

This resource has moved here.

--

gone

 

[azlier]

Kay. Approved.

 

[Bribe]

I don't know why you use operators instead of readonly... do array structs not compile readonly members? This just looks so much better:

library WorldBounds
    //struct WorldBounds extends array

    //static readonly rect world
    //  same as GetWorldBounds()
    
    //static readonly region worldRegion
    //  contains world for triggers
    
    //static readonly real maxX
    //static readonly real maxY
    //static readonly real minX
    //static readonly real minY
    //static readonly real centerX
    //static readonly real centerY
    
    struct WorldBounds extends array
        readonly static real maxX = 0.
        readonly static real maxY = 0.
        readonly static real minX = 0.
        readonly static real minY = 0.
        readonly static real centerX = 0.
        readonly static real centerY = 0.
        
        readonly static rect world = null
        readonly static region worldRegion = null
        
        private static method onInit takes nothing returns nothing
            set world = GetWorldBounds()
            set maxX = GetRectMaxX(world)
            set maxY = GetRectMaxY(world)
            set minX = GetRectMinX(world)
            set maxY = GetRectMaxY(world)
            set centerX = (maxX+minX)/2
            set centerY = (minY+maxY)/2
            set worldRegion = CreateRegion()
            call RegionAddRect(worldRegion, world)
        endmethod
    endstruct
endlibrary

 

[Nestharus]

I prefer operators.

Also, the onInit should be put into a module initializer : P. I'll fix that in a few.

 

[Bribe]

Operators are a problem because they equate to wasted text in-game, thus totally wasting space in the map-file size.

 

[Nestharus]

readonly equates to operator...

 

[Bribe]

I don't think you don't follow me. Readonly struct variables do not generate this:

//Generated method caller for world
function s_WorldBounds__world_operator takes integer this returns rect
    return s_WorldBounds__world[this]
endfunction

 

[Nestharus]

Last time I checked they do >.<.

 

[Bribe]

Well I have an Apple computer now and can't compile vJass. I've been working on my top-secret project in vanilla JASS.

 

[Bribe]

Just viewed the war3map.j file of my TimeTravel map; readonly members do not wastefully generate method operators. unit array s__retro_subject is all that gets compiled from it.

 

[Nestharus]

Eh, you're right ;\, but readonly is bugged with the public keyword >.>....

btw, fail optimizer that doesn't work with ExecuteFunc does remove those extra methods as they are inlined, but anyways..

updated

 

[Nestharus]

Updated to make rect and region optional

 

[Troll-Brain]

You don't get what i meant in the UnitIndexer thread, these constants are useless, one or less rect/region is really negligible, the previous version was fine.

 

[Magtheridon96]

What do you mean?
The readonly keyword stops the user from changing it

edit
Switch33, y u delete your post?

 

[Switch33]

Yeah; I realized that shortly after I looked more at it. You beat me to deleting my post. lol.

Although at least my map has an issue where it'd be good if map borders were sorta changeable; but i think it'd effect other scripts. So I might just use an border maxX, maxY, minX, MinY(that's set in another library that is not readonly) thats also set that will fall within the WorldBounds for spells that move units similar to blink etc.

Even I sorta agree with Troll-Brain here I can't see a reason for why you'd want an rect instead.

 

[Magtheridon96]

You can't use this to change the Bounds of the map
It's used for caching all the data you need involving the map boundaries for later use ^)^

 

[Switch33]

I know what it's used for.

Your misunderstanding what I'm saying.

Like i'm gonna confine the heroes to say a 64 by 64 section of forest of the 128 by 128 map i have and i'll have another section that is 64 by 64 that will be dungeon type terrain. (thats what i meant by changing bounds)

I'd have the bounds sort of shift to the new area(ofc this can't be done with this script; so i gotta code my own that'd run before the check for this for spells like blink etc(since i still use WorldBounds for other triggers); which just seems a bit odd/and almost redundant).

 

[Bribe]

The WorldBounds library is not meant to be used like that. If you have a
dynamic rect in your map you just need to reference that rect instead of
referencing WorldBounds.

What you are talking is more like you want bj_mapInitialPlayableArea.

 

[Troll-Brain]

Yeah; I realized that shortly after I looked more at it. You beat me to deleting my post. lol.

Although at least my map has an issue where it'd be good if map borders were sorta changeable; but i think it'd effect other scripts. So I might just use an border maxX, maxY, minX, MinY(that's set in another library that is not readonly) thats also set that will fall within the WorldBounds for spells that move units similar to blink etc.

Even I sorta agree with Troll-Brain here I can't see a reason for why you'd want an rect instead.

You totally miss what i meant.
The library in the previous state was right, now he had 2 booleans just for saving 2 static handles, pretty negligible, even vJass by itself makes much more handles.
But in an other side that doesn't matter.

What i said in the UnitIndexer thread is that this library should be included as an optional requirement in a public resource (inlined if the user doesn't have this library), that's all.

An yes as Bribe say this library is for map static rects/regions.

 

[Nestharus]

Well, I added the booleans in case you wanted only certain features.

For example, some maps may only need the coordinate extrema (like maxX, maxY). Others may only need the region.

 

[Troll-Brain]

That doesn't change the fact that one or less rect/region is negligible, but as i've said nevermind.
Though all these static if makes the API less readable, i suppose comments on the top would be welcome.

EDIT : Ofc don't take me wrong, i know how to use the API.

 

[Magtheridon96]

set centerX=(maxX+minX)/2
set centerY=(minY+maxY)/2

Ran some tests.
You could use 0 for both values instead.

 

[Bribe]

No, because there are often custom maps where the center is not 0. I have experienced this before.

 

[Nestharus]

Made all members integers instead of reals as they will always be integers anyways ; ).

 

[Magtheridon96]

Well, I guess comparisons and operations should be slightly faster now

edit

module WorldBoundsInit
    private static boolean CUSTOM_MAP_BOUNDS = true
    private static method onInit takes nothing returns nothing
        // bla bla bla
        static if CUSTOM_MAP_BOUNDS then
            set centerX=(maxX+minX)/2
            set centerY=(minY+maxY)/2
        else
            set centerX=0
            set centerY=0
        endif
        // bla bla bla
    endmethod
endmodule

 

[Nestharus]

Moved to repo

 

[Magtheridon96]

And there goes every resource linking to this thread.
Thanks.

 

[Nestharus]

I'll link to it in the repo then