Moderator
M
(7 ratings)
Thanks for the feedback
I'll definitly look into the it!
Unfortunatly most of the spells are Blizzard made since i'm not so good with Jass. As for the "honor points" i am refering to wood![]()
I have figured the Wood/honor thing out
btw, when you say add archers, do you mean Creeps?
Thanks for the feedback
I'll definitly look into the it!
Unfortunatly most of the spells are Blizzard made since i'm not so good with Jass. As for the "honor points" i am refering to wood![]()
I'll definitly make heroes summon closer to the shops
You suggested i remove "share unit shop." Where do i do this? Object editor or trigger?![]()
Rating | Number | Percent | Letter |
![]() ![]() ![]() ![]() ![]() | 5/5 | 91-100 | A |
Rating | Number | Percent | Letter |
![]() ![]() ![]() ![]() ![]() | 4/5 | 81-90% | B |
Rating | Number | Percent | Letter |
![]() ![]() ![]() ![]() ![]() | 3/5 | 75-80% | C |
Rating | Number | Percent | Letter |
![]() ![]() ![]() ![]() ![]() | 2/5 | 70-74% | D |
Rating | Number | Percent | Letter |
![]() ![]() ![]() ![]() ![]() | 1/5 | 50-69% | F |
Rating | Number | Percent | Letter |
![]() ![]() ![]() ![]() ![]() | 11/20 | 77% | C |
Your Triggers and their rating!
First of all, you shouldn't use wait actions!
I don't know why, but everyone says you shouldn't so.. well, just avoid them x)
2nd, your map leaks in points
Music List
Events
Conditions
Actions
Sound - Set the music list to DarkAgents <gen>, starting with song 1
Wait 65.00 seconds
Trigger - Run Music List <gen> (ignoring conditions)
Example and how to fix it:
This trigger above leaks!
Alliance Revival
Events
Unit - A unit Finishes reviving
Conditions
(Race of (Triggering unit)) Equal to Human
Actions
Selection - Select (Triggering unit) for (Owner of (Triggering unit))
Unit - Move (Triggering unit) instantly to (Center of AllianceStartZone <gen>)
Camera - Pan camera for (Owner of (Reviving Hero)) to (Center of AllianceStartZone <gen>) over 0.00 seconds
Here is how you fix it:
And it's leakless!
Alliance Revival
Events
Unit - A unit Finishes reviving
Conditions
(Race of (Triggering unit)) Equal to Human
Actions
Set Temp_Point = (Center of AllianceStartZone <gen>)
Selection - Select (Triggering unit) for (Owner of (Triggering unit))
Unit - Move (Triggering unit) instantly to Temp_Point
Camera - Pan camera for (Owner of (Reviving Hero)) to Temp_Point over 0.00 seconds
Custom script: call RemoveLocation (udg_Temp_Point)
All your triggers leaks with points, and unit groups.
Which is the 2 most commonly used actions, therefore the most important ones to fix.
I'll just end with saying Follow this guide I found to help you get rid of all the leaks, it is really awesome, i've looked thru it.
Tell me when the leaks are fixed and i'll rate it and vote for approval.
Untill then, good luck with your triggering!
EDIT:
Wow, found a biggi
Spawn Creeps
Events
Time - Every 50.00 seconds of game time
Conditions
Actions
Unit - Create 3 Footman for Player 11 (Dark Green) at (Center of MortalSouthSpawn <gen>) facing Default building facing degrees
Unit - Create 3 Felguard for Player 12 (Brown) at (Center of LegionSouthSpawn <gen>) facing Default building facing degrees
Unit - Create 3 Footman for Player 11 (Dark Green) at (Center of MortalNorthSpawn <gen>) facing Default building facing degrees
Unit - Create 3 Felguard for Player 12 (Brown) at (Center of LegionSpawnNorth <gen>) facing Default building facing degrees
Wait 1.50 seconds
Unit - Create 1 Lesser Voidwalker for Player 12 (Brown) at (Center of LegionSpawnNorth <gen>) facing Default building facing degrees
Unit - Create 1 Lesser Voidwalker for Player 12 (Brown) at (Center of LegionSouthSpawn <gen>) facing Default building facing degrees
Unit - Create 1 Archer for Player 11 (Dark Green) at (Center of MortalNorthSpawn <gen>) facing Default building facing degrees
Unit - Create 1 Archer for Player 11 (Dark Green) at (Center of MortalSouthSpawn <gen>) facing Default building facing degrees
Wait 0.50 seconds
Unit - Create 3 Footman for Player 11 (Dark Green) at (Center of MortalCenterSpawn <gen>) facing Default building facing degrees
Unit - Create 3 Felguard for Player 12 (Brown) at (Center of LegionCenterSpawn <gen>) facing Default building facing degrees
Wait 1.50 seconds
Unit - Create 1 Archer for Player 11 (Dark Green) at (Center of MortalCenterSpawn <gen>) facing Default building facing degrees
Unit - Create 1 Lesser Voidwalker for Player 12 (Brown) at (Center of LegionCenterSpawn <gen>) facing Default building facing degrees
This trigger creates 12 leaks every 50th sec ;o
I'll tell you why you should fix leaks above all this, since I got a little bit frustrated with all the triggers and not even a "Temp_X" variable xD
If you just got 1 leak, it won't be noticable at all, but the thing is that the leak stays in the map untill it's done and played.
So, if you got triggers like the above one, whom creates 12 leaks every now and then, they will add up on eachother,
Creating either alot of lagg or/and players to DC, which ofc is bad for the playing experience.
(Please, correct me if i'm wrong)
Also, Here is an easy custom script to remove triggers which only runs ONCE.
OBS; DO NOT use it on triggers which are supposed to run more than once!
Custom script: call DestroyTrigger( GetTriggeringTrigger() )
This one will destroy the trigger, saving memory when you play your map, making it run smother
Hope i've been to any help to you!
+rep if I'm not totaly off ^^
EDIT:
Also, please do floating texts like this:
This will make the text float upwards from the point it's created and it will automatically be destroyed after 2 seconds.
Alliance Honor
Events
Unit - A unit Dies
Conditions
((Triggering unit) is A Hero) Equal to True
((Owner of (Killing unit)) controller) Equal to User
(Race of (Killing unit)) Equal to Human
Actions
Player - Add 1 to (Owner of (Killing unit)) Current lumber
Floating Text - Create floating text that reads +1 Honor above (Killing unit) with Z offset 0.00, using font size 10.00, color (0.00%, 0.00%, 100.00%), and 0.00% transparency
Floating Text - Set the velocity of (Last created floating text) to 64.00 towards 90.00 degrees
Floating Text - Change (Last created floating text): Disable permanence
Floating Text - Change the lifespan of (Last created floating text) to 2.00 seconds
If you use wait action and just destroy it like you do now, it could bug and the text may stay on its spot for the rest of the game.
That can't happen if you do like i've done above!
#Hell Master: Thanks for the feed back
I'll make most if not all of these changes. As for the food bug can't belive i haven't seen that before and i'll definitly fix it
I have no plans for adding AI at this moment but maybe later if i get better with triggers![]()
Ok,from my point of view you need to change :Any criticism is most welcome