Z position Jass Help

[WanderingPeanut]

I need a trigger that will get the z height of a unit and if its below a certain height it will add it to a unit group and if it moves above that height it will be removed.
In GUI you cannot get z position but ive heard in Jass you can get it... unfortunately I cant do Jass whatsoever so I'd much appreciate some help.

 

[Adiktuz]

I need a trigger that will get the z height of a unit and if its below a certain height it will add it to a unit group and if it moves above that height it will be removed.
In GUI you cannot get z position but ive heard in Jass you can get it... unfortunately I cant do Jass whatsoever so I'd much appreciate some help.

if you need the Z of a location use this

• Custom Script - call GetLocationZ(location)

 

[WanderingPeanut]

Now ive got the Z position but I would love it if you could tell me how to set the Z postion of a picked unit as a local variable, and if its below a certain value reduce its movement speed. (I could do the movement speed bit myself its just the local variable bit I cant do).
Oh, and thanks for the quick reply.

 

[Adiktuz]

Now ive got the Z position but I would love it if you could tell me how to set the Z postion of a picked unit as a local variable, and if its below a certain value reduce its movement speed. (I could do the movement speed bit myself its just the local variable bit I cant do).
Oh, and thanks for the quick reply.

if the unit isnt flying you can set the locationZ into the local variable (real)

set height = GetLocationZ(location)

but if the unit is flying you must add its flying height to the location Z....

set height = GetLocationZ(location) + GetUnitFlyHeight(unit)

 

[WanderingPeanut]

• Unit Group - Pick every unit in (Units in (Playable map area)) matching (((Matching unit) is Undead) Equal to True) and do (Actions)
• Loop - Actions
• Custom script: call GetLocationZ(GetUnitLoc(GetEnumUnit()))
• Custom script: set localheight = call GetLocationZ(GetUnitLoc(GetEnumUnit()))
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• localheight Less than or equal to 100.00
• Then - Actions
• Unit - Set (Picked Unit) movement speed to ((Current movement speed of (Picked unit)) - 100.00)
• Else - Actions
• Do nothing

This should work then yeah? Event is every 2 seconds BTW.

 

[Adiktuz]

• Unit Group - Pick every unit in (Units in (Playable map area)) matching (((Matching unit) is Undead) Equal to True) and do (Actions)
• Loop - Actions
• Custom script: call GetLocationZ(GetUnitLoc(GetEnumUnit()))
• Custom script: set localheight = call GetLocationZ(GetUnitLoc(GetEnumUnit()))
• If (All Conditions are True) then do (Then Actions) else do (Else Actions)
• If - Conditions
• localheight Less than or equal to 100.00
• Then - Actions
• Unit - Set (Picked Unit) movement speed to ((Current movement speed of (Picked unit)) - 100.00)
• Else - Actions
• Do nothing

This should work then yeah? Event is every 2 seconds BTW.

yeah, though your trigger leaks location. and I think its better to make the interval smaller like every .03 seconds.

 

[WanderingPeanut]

Yeah ive just looked at some tutorials and scraped myself together a JASS version of this which uses local variables AND doesn't crash WE xD. Should do the job fine, again, thanks for your help.

Don't know if you're interested but it looks like this:

function Trig_Untitled_Trigger_002_Copy_Func001001002 takes nothing returns boolean
    return ( IsUnitType(GetFilterUnit(), UNIT_TYPE_UNDEAD) == true )
endfunction

function Trig_Untitled_Trigger_002_Copy_Func001Func003001 takes nothing returns boolean
    local real h = GetLocationZ(GetUnitLoc(GetEnumUnit()))
    return ( h == 179.20 )
endfunction

function Trig_Untitled_Trigger_002_Copy_Func001A takes nothing returns nothing
    call DoNothing(  )
    call DoNothing(  )
    if ( Trig_Untitled_Trigger_002_Copy_Func001Func003001() ) then
        call SetUnitMoveSpeed( GetEnumUnit(), ( GetUnitMoveSpeed(GetEnumUnit()) - 150.00 ) )
    else
        call SetUnitMoveSpeed( GetEnumUnit(), GetUnitDefaultMoveSpeed(GetEnumUnit()) )
    endif
endfunction

function Trig_Untitled_Trigger_002_Copy_Actions takes nothing returns nothing
    call ForGroupBJ( GetUnitsInRectMatching(GetPlayableMapRect(), Condition(function Trig_Untitled_Trigger_002_Copy_Func001001002)), function Trig_Untitled_Trigger_002_Copy_Func001A )
endfunction

//===========================================================================
function InitTrig_WaterSlow takes nothing returns nothing
    set gg_trg_WaterSlow = CreateTrigger(  )
    call TriggerRegisterTimerEventPeriodic( gg_trg_WaterSlow, 1 )
    call TriggerAddAction( gg_trg_WaterSlow, function Trig_Untitled_Trigger_002_Copy_Actions )
endfunction

Woo my first full JASS trigger.

 

[Berb]

Well first of all you'll want to add the units with decreased movement speed to a group and filter those units out so that the effect doesn't re-apply itself every second. When you remove it you'll want to remove them from the unit-group as well.

 

[M0RT]

Be careful, GetLocationZ() can desync game under certain circumstances (terrain deformations - 1) they don't display on lower graphic settings 2) spell terrain deformations don't display in fog of war)

 

[overload119]

Don't call DoNothing( ).

You're just wasting performance. Just remove those lines completely.

 

[WanderingPeanut]

Basically I,m using this trigger to slow movement speed of units on water (thats whats with the height must equal exactly 179.2) and I dont have any triggers or abilities than involve terrain deformations, so im not too worried abou that M0RT (Loving the Pratchett references).

Thanks for the tip Berbanog that'll help performance with lots of units.

Thanks for pointing that out to overload119, even I don't know why those are still there.

*EDIT* Also M0RT, I've downloaded your Space Engineers Beta, it looks great, I had an idea for a map like that once but couldn't figure out how to do it...

 

[M0RT]

Well terrain deformations also come from things like Thunderclap and War Stomp.
If you need to know, whether the unit is on water, test the location for pathability:

• Deep Water
• Conditions
  • (Terrain pathing at temp_loc of type Floatability is off) Equal to False
  • (Terrain pathing at temp_loc of type Walkability is off) Equal to True

• Shallow Water
• Conditions
  • (Terrain pathing at temp_loc of type Floatability is off) Equal to False
  • (Terrain pathing at temp_loc of type Walkability is off) Equal to False

(obviously if you want to test for any water, use only the "Flotability" condition.

Space engineers: glad you like it, I had this idea for like 7 years, and when I saw that space maps are becoming pretty common, I had to make one, too

 

[Berb]

Couldn't "GetLocationZ" be modified so that it returns a different value for each player (if necessary) in an attempt to avoid the desync?

function GetLocationZSafe takes location loc returns real
    local real z
    local integer i
    
    set i=0
    loop
        exitwhen i==16
        if GetLocalPlayer()==Player(i) then
            set z=GetLocationZ(loc)
        endif
        set i=i+1
    endloop
    return z
endfunction

 

[M0RT]

1) If it DID returned different value for each player, it would definetely cause desync (well not definetely, depends on what you use it for)
2) this function solves nothing, it calls the exact same line for each player
3) GetLocalPlayer() can never be players 12-15, since they are always AI players

The problem is that it might return different values, thats what we are trying to avoid. These situations are quite rare, so only if you use GetLocationZ() often and to decide unsafe code (like if you wanted to destroy all units on hills for some reason), you will need to worry about the terrain deformations.

 

[Berb]

What I was failing to show you with my function is a function that synchronizes the values returned so that it returns the same value for all players, kind of like a "standard" player.

GetLocalPlayer() can never be players 12-15, since they are always AI players

This is besides the point.

this function solves nothing, it calls the exact same line for each player

May not solve anything right now, but one of the strengths of having a forum thread is for idea brainstorming. I don't sit down at my computer for 30 minutes writing out code before I post here.

Couldn't "GetLocationZ" be modified so that it returns a different value for each player (if necessary) in an attempt to avoid the desync?

My example code is entirely besides the point, I don't know why you're putting so much effort into analyzing it. I merely posted the code to provide an example by which my point could be emphasized. I don't care if it has syntax errors when its compiling I asked if its possible that we modify the function to make it "safer".

 

[M0RT]

Ok, first, sorry for the tone of my last post, I didn't want to offend you.

My point was that the function imho doesn't synchronize returned value, because in the end, it just calls GetLocationZ(loc) at all computers, and it will still return different values. If you wanted to synchronize values, you would need to use GameCache and call SyncStoredInteger(...), which takes some time, so it's basically useless in most of triggers (since GetLocationZ() is usually called in triggers that somehow handle unit movement, that trigger like 20 times in second)

 

[Berb]

Well having synchronized values and "synchronizing" the values can be approached differently. For example, if your function only returns the "GetLocationZ" for Player 1 (Red) then where players' games would have crashed before they will simply have safe actions applied.

The problem I was having "expressing" is setting a variable for every player to a specific player's value, an effect that may only be possible through that "SyncStored...". Lamestylez.

 

[WanderingPeanut]

Damn, I forgot about the walkability/floatability native (I actually used that in the very same map), that could've saved me a lot of time and effort. Oh well at least its got me some basic JASS knowledge, (theres loads of stuff could optimize and neaten using it).