World's End v.1.0f

[Moderator]

World's End v.1.0e | Reviewed by Maker | 2nd Jun 2013

APPROVED

The spell is leakless and MUI I found the spell to be fun to cast and good looking. It uses the the projectile system well, in fact, most of the spell's work is done by that Improve the tooltip, look for standard Blizzard abilities for reference There's a wrong hotkey highlighted in the lear tooltip Reduce the sight range of the dummy

[tr]

Old review World's End v.1.0d | Reviewed by Maker | 1st Jun 2013 NEEDS FIX The dummy gives vision, uses upgrades and has build ability Load the ability level from a variable in WE Loop There's a wrong hotkey highlighted in the learn tooltip and there is one spelling error The dummy doesn't need invulnerability ability, it has Locust You could set the effect for the projectile system in setup trigger, not during every loop The hardcoded value of 7 in the looping trigger could be configurable The main loop only runs once per cast, therefore it is a 0.03 second delay What do you need that for, you could make it instant and get rid of the indexing [tr]

 

[MasterTrainer]

~Reserved

Oh and please do share your thoughts.

 

[Daffa]

Lul, Almia will check this spell first
Better take the second slot

Edit :

What is the use of this variable :

• Set MS_unit_hit_eff=<Effect>

Can you explain mate?

 

[MasterTrainer]

Lul, Almia will check this spell first
Better take the second slot

Edit :

What is the use of this variable :

• Set MS_unit_hit_eff=<Effect>

Can you explain mate?

That's the effect that is created when the missiles hit a unit. I figured that all I need was the effect when the missiles expired/reached their target, so I did not bother to put in a string variable there.

But now as I think about it again it might be useful... I might add it in the spell too tomorrow, because, at my place it is really late and I am tired.

Actually, I change 'I might' to 'I will'.

 

[deathismyfriend]

one thing i dont like is this

• Unit - Create 1 Casting Dummy for (Owner of WE_Caster[WE_CurrentIndex]) at WE_TempPoint facing Default building facing degrees

ik u use a timer to remove the unit but creating a unit every .03 is insane lol. u can use one dummy to do all ur spell instances just create the dummy on map init. then move the dummy to the unit to do the effect / buff or whatever. ur creating 34 units a second.
Also u should store the lvl of the ability when the unit casts it.
umm y not make this an instant spell ? it would be in one trigger and u could get rid of the loop and it will still be MUI.

 

[Pr0blemBro]

Its a very great spell, but
Change the hotkey O :/

 

[MasterTrainer]

one thing i dont like is this

• Unit - Create 1 Casting Dummy for (Owner of WE_Caster[WE_CurrentIndex]) at WE_TempPoint facing Default building facing degrees

ik u use a timer to remove the unit but creating a unit every .03 is insane lol. u can use one dummy to do all ur spell instances just create the dummy on map init. then move the dummy to the unit to do the effect / buff or whatever. ur creating 34 units a second.
Also u should store the lvl of the ability when the unit casts it.
umm y not make this an instant spell ? it would be in one trigger and u could get rid of the loop and it will still be MUI.

I don't think the dummy units will be created every .03 seconds because it will only be created MaxIndex times, and within that 'For each CurrentIndex' loop is the turn off trigger, so I don't think there would be a problem. Also, to support this, may game should have lagged while I was creating the spell.

Oh and I would also like to know what the difference is when I store the lvl of the ability when the units casts it or if I store the lvl in the loop.

And when I do make it an instant spell, won't that remove the 'select target' part of the spell?

@Pr0blemBr0 thanks! Though the reason I made the hotkey like that was because of the reason that the hotkeys with other spells might interfere with it, so I thought the user could just change it himself, but then again, just for testing purposes, I will change the hotkey.

 

[deathismyfriend]

umm i dont even see the select unit thing lol. also u dont show all of the triggers.

• Trigger - Run MS init <gen> (ignoring conditions)

 

[MasterTrainer]

umm i dont even see the select unit thing lol. also u dont show all of the triggers.

• Trigger - Run MS init <gen> (ignoring conditions)

Oh the 'select target' happens when you click on the spell icon and then you select which unit it's supposed to target. Pretty weird that you don't see this. It happens all the time with single-target spells like storm bolt, aerial shackles, death coil, etc.

Anyways the MS init is the projectile system's trigger so I don't think I need to show that.

 

[deathismyfriend]

u should show anything that has to do with ur spell.

and the select target wouldnt matter for this spell. this spell could be 2 triggers long ( config / spell ) it shouldnt be three.

 

[Almia]

Uhmmm, Camel-casing are only done for struct globals,methods and locals. So the variables here Should_BeNamedLikeThis.

All of the constants(configurables) here should be moved in the Setup Trigger:

Set MS_dmg_source = WE_Caster[WE_CurrentIndex] Set MS_owner = (Owner of WE_Caster[WE_CurrentIndex]) Set MS_create_point = (WE_TempPoint offset by WE_Offset[WE_Level] towards ((Real(WE_TempInt)) x (360.00 / 7.00)) degrees) Set MS_target_point = WE_TempPoint Set MS_damage = WE_Damage[WE_Level] Set MS_seconds_to_reach = ((Real(WE_LoopInt)) x WE_TimeToReach[WE_Level]) Set MS_angle = (Angle from MS_create_point to MS_target_point) Set MS_distance = (Distance between MS_create_point and MS_target_point) Set MS_missile_gfx = Abilities\Weapons\PhoenixMissile\Phoenix_Missile.mdl Set MS_impact_gfx = Abilities\Spells\Other\Doom\DoomDeath.mdl Set MS_unit_hit_eff = <Empty String> Set MS_arcs = True Set MS_arc_dist = ((Real(WE_LoopInt)) x 75.00) Set MS_arc_type = 1 Set MS_parabola = True Set MS_parabola_height = 300.00 Trigger - Run MS init <gen> (ignoring conditions)[/stable] Just refer them. Same goes to the other one. Set MS_owner = (Owner of WE_Caster[WE_CurrentIndex]) Use this in the Create Dummy Action. Do you use dummy.mdx? Why not use the Projectile System's dummy? Its a waste of object. When creating the missiles in that For Loop Integer,remove this line: Set MS_owner = (Owner of WE_Caster[WE_CurrentIndex]) Max integer of For Loop should be configurable. Actually,it was a nice spell. It reminds me a lot of my Projectile System Demo Spell

 

[MasterTrainer]

This... this is what I was waiting for.

It will take me some time to process this lot, but I think I can pull it off later tonight or first thing tomorrow.

Also, I now see the waste of object, thanks for pointing that out.

Oh and Almia, when you say move the constants in the Setup trigger, do you mean the variables I initialize for the projectile system to use that uses the variables in the setup trigger? (i.e. damage, time to reach, and offset)

@deathismyfriend I see your point now too, I did not know that because this is my first. I will post them later when I have figured my remaining hours of the day out.

 

[deathismyfriend]

@deathismyfriend I see your point now too, I did not know that because this is my first. I will post them later when I have figured my remaining hours of the day out.

lol thats ok i couldve explained a little better y it was better off as the other choice lol.

i was just busy making my first spell lol. provided a quick explanation here.

 

[MasterTrainer]

Oh I understand that I can shorten it to two triggers, but can you explain why the player shouldn't need a specific target for the spell?

Oh and @Almia/deathismyfriend what does this mean (Almia mentioned earlier this) Should_BeNamedLikeThis. What does it mean?

 

[deathismyfriend]

Oh I understand that I can shorten it to two triggers, but can you explain why the player shouldn't need a specific target for the spell?

Oh and @Almia/deathismyfriend what does this mean (Almia mentioned earlier this) Should_BeNamedLikeThis. What does it mean?

an instant spell can use a target lol. u dont have to change that.

he means the way u name things. Any constants ( things u dont change after setting them once) should be named

LIKE_THIS

any other variables should be

likeThis

any custom functions should be

LikeThis

 

[MasterTrainer]

Okay before I continue this only affects my variables right? Not the system's variables?

 

[Daredeamon]

You should post Kingz' edited version of the missile system also. (I know there's more to it because I used it for a long time.)

Anyway, thing is, I don't like his missile system.
Needs more terrain height detection!

 

[MasterTrainer]

I know... I don't like it in some way too, primarily because it doesn't have a homing missile function yet.

I tried many other projectile systems, but most of them have their limitations. I tried Almia's projectile system at Hordestudio, but I can't seem to properly import it.

But give me some time maybe 5 mins and I will post it

EDIT: Took me a while because of the long desc., but I have uploaded the triggers. The Projectile System's triggers.

 

[Daredeamon]

I know... I don't like it in some way too, primarily because it doesn't have a homing missile function yet.

I tried many other projectile systems, but most of them have their limitations. I tried Almia's projectile system at Hordestudio, but I can't seem to properly import it.

But give me some time maybe 5 mins and I will post it

EDIT: Took me a while because of the long desc., but I have uploaded the triggers. The Projectile System's triggers.

I'm still working on my projectile system, but it should totally pwn every GUI projectile system on the Hive as soon as I release it. :3 .. I hope. D

In any case, adding homing to Kingz' system is something I've done before. Where exactly do you need it?

 

[MasterTrainer]

I'm still working on my projectile system, but it should totally pwn every GUI projectile system on the Hive as soon as I release it. :3 .. I hope. D

In any case, adding homing to Kingz' system is something I've done before. Where exactly do you need it?

I'm not sure I can exactly answer your question 'where' as I don't understand projectile systems very much.

But I was planning to use it so that even as the target unit moves the missiles will move along the target/ to the position of the target.

 

[Daredeamon]

I'm not sure I can exactly answer your question 'where' as I don't understand projectile systems very much.

But I was planning to use it so that even as the target unit moves the missiles will move along the target/ to the position of the target.

Let me download the spell (I have only looked at it from triggers)
I'll know exactly where and how to add the homing part, after that. If you want, I could show you how ^.^ I know this missile system like the back of my hand.

EDIT 1:
First thing I noticed is you use Firebolt to trigger your spell. I have to advise against this, since it ministuns your target which I believe is an unwanted side effect, and you can't set the "stun duration" in the object editor to 0. If you DID mean for the ministun to happen, disregard this. Otherwise use "Channel", a spell that has no real effect other than registering you triggering your abilities.

 

[MasterTrainer]

Thanks a lot

If I only knew how to make arcing missiles I could've started my own projectile system too.

 

[Daredeamon]

Alright. First of all, the formula for calculating arcs is right there. Secondly you have a lot of unnecessary things going on in this whole trigger, I've realized now. This reduces efficiency and thus the performance of the spell (and ultimately of the game too).

Do you want me to edit it, document what I edit so you know what I changed, and send you an optimized version?

 

[MasterTrainer]

That would be an excellent opportunity for me to learn more about spells.

Please do.

 

[Almia]

Variables are named(in globals GUI) like this.

PS_DamageValue
JU_Mana
KI_Caster

not
PS_damagevalue
JU_mana
KI_caster

 

[MasterTrainer]

But my variables are like the ones in the top you mentioned:

WE_TempPoint
WE_LoopInt


Oh and Almia, can you also elaborate more on what you said about moving the constants in the loop in the Setup trigger?

 

[Almia]

Put them in the setup trigger dude. All constants should be moved there. Forever.

 

[MasterTrainer]

So I move these lines to the Configuration trigger?

• Set MS_damage = WE_Damage[WE_Level]
• Set MS_create_point = (WE_TempPoint offset by WE_Offset[WE_Level] towards ((Real(WE_TempInt)) x (360.00 / 7.00)) degrees)
  • Set MS_seconds_to_reach = ((Real(WE_LoopInt)) x WE_TimeToReach[WE_Level])

Because these are the only configurables I see in the loop... I'm getting a sense that I am wrong; I hope I'm not.

 

[Almia]

No the constants only.

If you don't know what constants are. Constants are somewhat exact , non-changing values.

 

[MasterTrainer]

Exact non-changing values so, these?
------------------------------------------------
((Real(WE_LoopInt)) x 75.00) {arc distance} //
300.00 (Parabola Height) //
1 (Arc type) //
True (Missile arcs; boolean) //
-----------------------------------------------

 

[Almia]

Exact non-changing values so, these?
------------------------------------------------
((Real(WE_LoopInt)) x 75.00) {arc distance} //
300.00 (Parabola Height) //
1 (Arc type) //
True (Missile arcs; boolean) //
-----------------------------------------------

WE_LoopInit is not a constant. But 75 does.
The other three yes.

If you are lost,why not look for some examples?
http://www.hiveworkshop.com/forums/spells-569/dark-portal-v1-5-a-221829/
http://www.hiveworkshop.com/forums/spells-569/void-sphere-v1-4-a-224044/

 

[MasterTrainer]

If I move it in the Setup trigger then it becomes a configurable right? So basically you wanted it to be configurable all along?

 

[Almia]

Yep.

 

[MasterTrainer]

You know you could've just said so in the first place; but okay. Thanks for your comments again Almia =)

I feel honored for a great coder such as yourself test my spell

 

[Almia]

Im not that great
Im a stupid coder who makes trash codes

 

[MasterTrainer]

Im not that great
Im a stupid coder who makes trash codes

If by trash codes you mean works of art, then yes. They are very trashy.

I think a great coder is a great coder when he has the potential and ability to inspire others to code better than they already can, in this case, me.

 

[deathismyfriend]

If by trash codes you mean works of art, then yes. They are very trashy.

I think a great coder is a great coder when he has the potential and ability to inspire others to code better than they already can, in this case, me.

so im a great coder lol ?

 

[MasterTrainer]

I'm sorry what?

I was referring to Almia, because his spells are what inspired me.

But yes, in a way, you and everyone else is a great coder.

 

[deathismyfriend]

I'm sorry what?

I was referring to Almia, because his spells are what inspired me.

But yes, in a way, you and everyone else is a great coder.

lol i was only messing with u.

 

[MasterTrainer]

I'm going to update the spell later, along with Almia's suggestions.

 

[Almia]

Literally trash codes.

 

[MasterTrainer]

Why do you say that?

 

[Almia]

Im just saying the truth. Specially when doing something in vJASS. Everytime I code a vJASS code,it always results into Trash. Perhaps not in Spells XD

 

[MasterTrainer]

Now that you mention it, I do notice most of your spells and systems are coded in GUI... but nonetheless you're still a great coder for me

 

[MasterTrainer]

Wait; after giving it some thought, would this spell work if I de-array the variables which use CurrentIndex and MaxIndex and remove the loop and put those actions in the Cast Trigger so that it would only consist of two triggers?

Would this still work because this is and I quote, 'an instant'?

 

[deathismyfriend]

Im just saying the truth. Specially when doing something in vJASS. Everytime I code a vJASS code,it always results into Trash. Perhaps not in Spells XD

it really is backwards on this site lol.
If its more efficient than GUI and a gui version is up it should be approved. Getting my systems approved is a joke right now. its been pending for months. Updated them plenty of times to were its just about as efficient as possible and still nothing.

 

[MasterTrainer]

Spell is approved; thanks guys!

 

[The.Final.Blow]

It's the world's end , btw very beautiful and very useful.