[Solved] Will 'pick every unit -and do- remove picked unit from the game' cause a leak?

[bobadoo2]

I definitely don't want any leaks because my triggers often repeat themselves throughout the game.

It's just I noticed normal unit groups only seam capable of containing 12 units at a time and I tested this trigger and it can do whole armies. But it seams to not be able to do an infinite amount of units either, not sure. I wonder how many units it can do, anyone know? Doesn't matter if it leaks so that's more important, does it leak???

Will these triggers circled in red cause a leak?
NOTE: I attached the level too.
View attachment 277721

 

[Dr Super Good]

Yes each action leaks a unit group and that unit group handle (I think). The handle is due to the local declared local handle variable reference counter leak on return bug with one of the group construction BJs.

 

[Damage]

You need to do something more like

Set (GroupVariable) = Units of Type [MyUnitType]

Then do actions on that group.

Lastly, do: Custom script: call DestroyGroup(udg_GroupVariable)


Easier still, just do something like this:

• Set GrouptoRemove = (Units owned by (Player 1 (Red)))
• Unit Group - Pick Every Unit in (GrouptoRemove) and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Or (Any Conditions are True)
          • Unit-Type of Picked Unit equal to English Captain 1
          • Unit-Type of Picked Unit equal to English Captain 2
          • Unit-Type of Picked Unit equal to .... (etc.)
          • ....
      • Then - Actions
        • Unit - Remove (Picked Unit) from the game.
      • Else - Actions
• Custom script: call DestroyGroup(udg_GrouptoRemove)

 

[Rheiko]

You can also do it like this

• Custom script: Set bj_wantDestroyGroup = true
• Unit Group - Pick Every Unit in (Units owned by (Player 1 (Red))) and do (Actions)
  • Loop - Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • Or (Any Conditions are True)
          • Unit-Type of Picked Unit equal to English Captain 1
          • Unit-Type of Picked Unit equal to English Captain 2
          • Unit-Type of Picked Unit equal to .... (etc.)
          • ....
      • Then - Actions
        • Unit - Remove (Picked Unit) from the game.
      • Else - Actions