Will multiple instances of this trigger overwrite data in the same variable?

[Warnem55]

Now this could be a dumb question but,
I'm making a blocking trigger that goes like the following:
A unit is attacked
If unit has item SHIELD
then silence unit (dummy caster)
then play unit's defend animation
then set charges in SHIELD to -1
then set VARIABLE1 to charges in SHIELD

and another trigger:
A unit is attacked
If unit has item SHIELD
If VARIABLE1 equal to 0
then destroy SHIELD from triggering unit

What im asking is if multiple units will have item SHIELD and are being attacked say one has 20 charges and the other 50 then will they be overwriting each others data in VARIABLE1 ?

 

[Dr Super Good]

Ofcourse they will. VARIABLE1 is a global and as such it will hold the value that it was assigned to last.

You can eithor use some complex index array system to get a unique index for each unit or use hashtables to attach the value to the unit (well use the handle ID of the unit as an index in the hashtable for the data).

 

[defskull]

But if you're using Local Variable, it's a different story

 

[Dr Super Good]

Yes, there you will get a syntax error as locals only exist within the function they are declared.

 

[Warnem55]

I have incorporated the second trigger into the first. The point is that a unit first sets the shield charges to a number, THEN the variable to the charges and THEN checks whether to destroy the item. Might this work out or would the overwriting still be a problem?

• Woodenshield blocking trigger incorporated
  • Events
    • Unit - A unit Is attacked
  • Conditions
    • (Random integer number between 1 and 100) Less than or equal to 50
    • ((Triggering unit) has an item of type Round Wooden shield) Equal to True
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • ((Attacking unit) is A melee attacker) Equal to True
      • Then - Actions
        • Item - Set charges remaining in (Item carried by (Triggering unit) of type Round Wooden shield) to ((Charges remaining in (Item carried by (Triggering unit) of type Round Wooden shield)) - 1)
        • Animation - Play (Triggering unit)'s defend animation
        • Unit - Order Dummy caster 0006 <gen> to Neutral Dark Ranger - Silence (Position of (Triggering unit))
        • Set Woodenshieldcharges = (Charges remaining in (Item carried by (Triggering unit) of type Round Wooden shield))
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • Woodenshieldcharges Greater than or equal to 1
          • Then - Actions
            • Do nothing
          • Else - Actions
            • Item - Remove (Item carried by (Triggering unit) of type Round Wooden shield)
      • Else - Actions
        • Animation - Play (Triggering unit)'s walk defend animation

If one unit would set charges to 0 his trigger would then destroy the item before another unit wold reset the variable to his own charges, ...or would it?

 

[Maker]

That will work variable-wise.

Remove the do nothing and get rid of the position leak.

 

[Bribe]

Curious... if there are 0 charges remaining, won't the item just remove itself? Why do you need to check if there are charges left?

 

[Maker]

Maybe he has set perishable to false in object editor. That way the item won't disappear when charges run out. Then you could repair or recharge the item instead of losing it.

EDIT: Wait, he wants to remove it when charges run out. Nevermind then.

 

[Warnem55]

I have perishable set to true, however when charges are set with triggers it wont perish.

get rid of the position leak.

Is this correct?

• Untitled Trigger 001
  • Events
  • Conditions
  • Actions
    • Set silencedUnitTemppoint = (Position of (Triggering unit))
    • Custom script: call RemoveLocation( udg_silencedUnitTemppoint )

Thanks for all help.

 

[Maker]

• Untitled Trigger 001
  • Events
  • Conditions
  • Actions
    • Set silencedUnitTemppoint = (Position of (Triggering unit))
    • Unit - Order Dummy caster 0006 <gen> to Neutral Dark Ranger - Silence silencedUnitTemppoint
    • Custom script: call RemoveLocation( udg_silencedUnitTemppoint )

Yes, that's how positions should be used.