Why isn't my trigger working? Range passive ability

[ZEROZX99]

Hi, I'm trying to create a trigger to increase a hero's attack range at level 6.I decided to do this using the Metamorphosis ability, replacing one unit with another when the skill is learned.I set it up this way, but it's not working:

• LongRange
  • Events
    • Unit - A unit Learns an ability
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (Level of Critical Strike X for (Triggering unit)) Equal to 1
      • Then - Actions
        • Unit - Add Metamorphosis 1 to (Triggering unit)
        • Unit - Order (Triggering unit) to Night Elf Demon Hunter - Metamorphosis.
        • Unit - Remove Metamorphosis 1 from (Triggering unit)
      • Else - Actions
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
            • (Level of Critical Strike X for (Triggering unit)) Equal to 2
          • Then - Actions
            • Unit - Add Metamorphosis 2 to (Triggering unit)
            • Unit - Order (Triggering unit) to Night Elf Demon Hunter - Metamorphosis.
            • Unit - Remove Metamorphosis 2 from (Triggering unit)
          • Else - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Level of Critical Strike X for (Triggering unit)) Equal to 3
              • Then - Actions
                • Unit - Add Metamorphosis 3 to (Triggering unit)
                • Unit - Order (Triggering unit) to Night Elf Demon Hunter - Metamorphosis.
                • Unit - Remove Metamorphosis 3 from (Triggering unit)
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Level of Critical Strike X for (Triggering unit)) Equal to 4
                  • Then - Actions
                    • Unit - Add Metamorphosis 4 to (Triggering unit)
                    • Unit - Order (Triggering unit) to Night Elf Demon Hunter - Metamorphosis.
                    • Unit - Remove Metamorphosis 4 from (Triggering unit)
                  • Else - Actions
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • (Level of Critical Strike X for (Triggering unit)) Equal to 5
                      • Then - Actions
                        • Unit - Add Metamorphosis 5 to (Triggering unit)
                        • Unit - Order (Triggering unit) to Night Elf Demon Hunter - Metamorphosis.
                        • Unit - Remove Metamorphosis 5 from (Triggering unit)
                      • Else - Actions
                        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                          • If - Conditions
                            • (Level of Critical Strike X for (Triggering unit)) Equal to 6
                          • Then - Actions
                            • Unit - Add Metamorphosis 6 to (Triggering unit)
                            • Unit - Order (Triggering unit) to Night Elf Demon Hunter - Metamorphosis.
                            • Unit - Remove Metamorphosis 6 from (Triggering unit)
                          • Else - Actions

I am trying to create a passive ability that increases a Hero's attack range and acquisition range by 200 per level.

Since I am working on version 1.27, I am using the 'Metamorphosis trick' to swap the unit type for one with higher range whenever the ability is learned or leveled up. However, the trigger is not working as expected.

I've tried using ChatGPT and Gemini AI for this, but the solutions provided didn't work for my specific version.

 

[khopesh]

I'm not very good at explaining, but I think if you've tested that the skill works without levels maybe you have to try the default variables of the skill, I think you could reduce the trigger quite a bit with
condition
%abbility%=Golpe critico
actions
custom script: Add meta !lvl %abbility%! triggering unit
...
custom script: Remove meta !lvl %abbility%! triggering unit

---

In any case, first try if it works without a level

 

[ThompZon]

If you can accept having a bigger acquisition range from the start (what it has at max upgrades), doing it with upgrades (dwarf gunner's range upgrade) could make sense.

Also, you posted triggers as images, making it hard to translate them. Consider doing it as How To Post Your Trigger suggests (it's easier to copy paste to translators to verify details of what you're doing instead of guessing).

 

[ZEROZX99]

Sorry, I missed a few details before, but I have corrected them now. I hope you can help me with this.

I think I am missing some conditions, but I'm not sure which ones to use.

 

[Chaosy]

Very clunky approach.

For example, what if the unit dies? next time he respawns it wont have the range bonus.

This is very much a "isn't worth it" situation because every solution have considerable downsides and are inelegant. Just change it to another stat you can more easily modify permanently. For 1% of the effort you can get a similar damage output increase. (obviously attack range is not strictly damage increase but anyway)

But yes you're not checking if the triggering unit is exactly level 6 which seems intended. Otherwise you get this bonus every time it levels up