What is the correct script for destroying these points?

[GenoHacker]

What is the correct script for destroying these points?

• Set OrbSword_Points[(Player number of (Owner of DamageEventSource))] = (Position of DamageEventSource)
• Set OrbFire_Point[(Player number of (Owner of DamageEventSource))] = (Position of DamageEventTarget)

 

[Wasabee]

The locations will leak so this should be followed by this:

• Custom script: call RemoveLocation(udg_OrbSword_Points[(Player number of (Owner of DamageEventSource))])
• Custom script: call RemoveLocation(udg_OrbFire_Point[(Player number of (Owner of DamageEventSource))])

 

[Ofel]

Store player number to a variable

• Set PlayerID = Player number of (Owner of DamageEventSource)
• Custom script: call RemoveLocation(udg_OrbSword_Points[udg_Player_ID])
• Custom script: call RemoveLocation(udg_OrbFire_Points[udg_Player_ID])

 

[Wasabee]

Store player number to a variable

• Set PlayerID = Player number of (Owner of DamageEventSource)
• Custom script: call RemoveLocation(udg_OrbSword_Points[udg_Player_ID])
• Custom script: call RemoveLocation(udg_OrbFire_Points[udg_Player_ID])

Storing the player number would be more efficient and save some time.

 

[KILLCIDE]

The locations will leak so this should be followed by this:

• Custom script: call RemoveLocation(udg_OrbSword_Points[(Player number of (Owner of DamageEventSource))])
• Custom script: call RemoveLocation(udg_OrbFire_Point[(Player number of (Owner of DamageEventSource))])

That wouldn't compile. You need to replace the index with the proper JASS natives GetPlayerId() and GetOwningPlayer():

call RemoveLocation(udg_OrbSword_Points[GetPlayerId(GetOwningPlayer(udg_DamageEventSource))])
call RemoveLocation(udg_OrbFire_Point[GetPlayerId(GetOwningPlayer(udg_DamageEventSource))])

Since JASS player indexes start at 0 (where as GUI starts at 1), he might have to increment the returned integer by 1 if he stored some important values specific to a player.