Listen to a special audio message from Bill Roper to the Hive Workshop community (Bill is a former Vice President of Blizzard Entertainment, Producer, Designer, Musician, Voice Actor) 🔗Click here to hear his message!
conditions:
(Ability being cast) Equal to Water Wall by Warilock
actions:
For each (Integer A) from 1 to 120 do (actions)
loop - Actions:
Unit - Create 1 Water Wall by Warilock for Neutral passive at ((Position of(Triggering unit)) offset by 700.00 towards (-3.00 x (Real((Integer A)))) degrees) facing Default building facing degrees
Unit - Make (Last created unit) Invulnerable
------------------------------------------------------------------------------------
Unit - Create a Water Wall by Warilock corpse for Neutral passive at (Position of(Trigering unit))
Keywords:
Water Wall, Wall, Water, Warilock, GB_Warilock
Bribe:
Unbelievable amount of units and memory leaks. Definitely does not belong in a practical spell environment. Maybe good as a cinematic.
Rejected.
Maker. You mispelled "Practice"! Reporting Post now -.- ... jk ^^
This spell is way too simple.
It leaks since it doesn't store a location variable and removes it later, causing the game to lag like hell. This isn't the only way though. You can store x and y real variables, but since you're a beginner, i think that would be kinda advanced for you
Just stick to locations for now, and when you move on to JASS, then you can start using X and Y reals.
To fix the spell:
Change the event to "Starts the effects of an ability".
Variable Name: What it's used for.
(WW_Loc): Use a location variable to store the position of the caster
(WW_Lvl): Use an integer to store the level ability incase you wanna add anything extra having to do with ability level.
(WW_Caster): Use a unit variable to store the caster
(WW_Radius): Use a real variable to store the offset
(WW_TempLoc): Use another location variable for the loop to store a location that is the offset of WW_Loc by a value of WW_Radius.
(WW_DummySpawnCount): Use this integer to store the number of dummies to create.
(WW_DummyAngleOffset): Use this real to determine what angle offset is needed for the dummy spawning. It would be equal to (360/(WW_DummySpawnCount)). Since your a beginner, i'm going to point out to you the fact that you should convert from integer to real to insert the WW_DummySpawnCount in the arithmetic.
(WW_int): Use this integer in the integer variable loop.
(WW_dest): Use this boolean to decide whether or not the spell destroys destructibles.
-----------------------------------------------
Use (integer variable) instead of (integer a)
Let the loop manipulate the integer variable for values ranging from 1 to WW_DummySpawnCount and when you spawn the dummies in the loop, give them a generic expiration timer.
Then, if WW_dest was set to true, it would destroy all destructibles within a radius of WW_Radius. You would use an If/Then/Else Loop here.
NOTE: DO NOT ADD THE ACTION "DO NOTHING" IN THE ELSE STATEMENT.
Finally, you would add these two actions in custom script:
If (All Conditions are True) then do (Then Actions) else do (Else Actions)
If - Conditions
WW_DestroyDestructibles Equal to True
Then - Actions
Destructible - Pick every destructible within WW_Radius of WW_Loc and do (Actions)
Loop - Actions
Destructible - Kill (Picked destructible)
Else - Actions
Custom script: call RemoveLocation(udg_WW_Loc)
I took the liberty of fixing the spell for you
I wanted to add a loop trigger so that the wall would move with the caster, but it seems that you lack.... the ability to .... comprehend the... nevermind ;p
Read the comments for each action.
The spell is still too simple, so before uploading one similar to this, plz read some tutorials, and learn how to use loops.
Also, you need to learn about removing leaks.
One more thing, don't double post. Moderators HATE that.
emm...
this spell is not finished...
since it's called "water wall" i suppose it blocks all units from entering and leaving the circle...
all you managed to do is to create the special effects...
anyway you should do what Magtheridon96 if you want to fix your spell...
ill give you a 3/5 for trying ;p
EDIT:
as i see you didn't even bother to update your spell?
This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.
Approved
jk ^^
Actions
-------- ------------------ --------
Set WW_Caster = (Triggering unit)
For each (Integer WW_int) from 1 to WW_DummyCount, do (Actions)
Unit - Create 1 Water Wall by Warilock Dummy2 for Neutral Passive at WW_TempLoc facing Default building facing degrees
Custom script: set udg_WW_TempDummy = null
If - Conditions
Destructible - Pick every destructible within WW_Radius of WW_Loc and do (Actions)
