Variable Question

[mr po]

Is these 2 variables basically the same thing? example:

Set UnitVariable = (Random unit from WhateverGroup1)
Set WhateverGroup2 = (Random 1 units from (WhateverGroup1))

If it is same then i assume the unit variable is faster, i don't have to clean group leak.

 

[DracoL1ch]

1st is unit, 2nd is group

 

[Pyrogasm]

Always use the first if you can to avoid creating excessive groups you will then need to destroy.

 

[mr po]

thank you

 

[IcemanBo]

It's actually not directly related, but I still mention it because I've seen people abusing it too much.

People in GUI often like to use it to get their builder/hero from their map like:

• Unit - Move (Random Unit From (Player 1 Players of Type <Hero>)) to <Region>)

...-- with the argument they have only one hero, so it will work always. But I can just say it's a horrible way of doing, and in case you're using it similary, then none of the mentioned 2 ways is good.

 

[Dr Super Good]

Set UnitVariable = (Random unit from WhateverGroup1)

This does not leak.

Set WhateverGroup2 = (Random 1 units from (WhateverGroup1))

This does leak. Unless the local declared local handle variable reference counter leak on return bug has been fixed with 1.27b (probably needs retesting).

function GetRandomSubGroup takes integer count,group sourceGroup returns group
    local group g = CreateGroup()
    set bj_randomSubGroupGroup = g
    set bj_randomSubGroupWant  = count
    set bj_randomSubGroupTotal = CountUnitsInGroup(sourceGroup)
    if (bj_randomSubGroupWant <= 0 or bj_randomSubGroupTotal <= 0) then
        return g
    endif
    set bj_randomSubGroupChance = I2R(bj_randomSubGroupWant) / I2R(bj_randomSubGroupTotal)
    call ForGroup(sourceGroup, function GetRandomSubGroupEnum)
    return g
endfunction

Local declared local group variable g is not null at function return. People have also reported that the results are not truly random due to a logical error with the selection probability.