[JASS] Unit in range using collision

[Dreadnought[dA]]

Assuming the units Point Value = Collision size, would this be a good check to see if they are within a certain range?

function UnitInRange takes real r, unit u, real x, real y returns boolean
local integer p = GetUnitPointValue(u)
local real x2 = GetUnitX(u)
local real y2 = GetUnitY(u)

return SquareRoot((x2-x)*(x2-x)+(y2-y)*(y2-y)) < r+p
endfunction

 

[aznricepuff]

There's already a native that does this:

constant native IsUnitInRangeXY takes unit whichUnit, real x, real y, real distance returns boolean

 

[PurplePoot]

Jass doesn't support implicit multiplication. Also, along with the native aznricepuff mentioned, there is IsUnitInRange to check between two units, and naturally IsUnitInRangeLoc (or however it's named).

 

[Dreadnought[dA]]

But does it take into account their collision size? I want it to where if there fattyness is within range than it selects them. Say I code a grenades damage and have it damage units in 100 AoE. It could land right next to a town hall and not damage it at all even though the town halls fat is in range.

See what I'm trying to do?

 

[aznricepuff]

The natives do take into account collision.

 

[Dreadnought[dA]]

So i'm trying to pick units in range using this and then damage them.
Should I select all units on the map and then use that function you posted?

call GroupEnumUnitsInRange(g,x2,y2,100+MC(),Condition(function RipperFilter))

(MC() is the largest collision size of any unit in the game)

Also is it bad to mimic natives with your own code? Are natives always faster?

private function RipperFilter takes nothing returns boolean
local integer p = GetUnitPointValue(GetFilterUnit())
local real x2 = GetUnitX(GetFilterUnit())
local real y2 = GetUnitY(GetFilterUnit())

return SquareRoot((x2-TempReal1)*(x2-TempReal1)+(y2-TempReal2)*(y2-TempReal2)) <= TempReal3+p
endfunction

I just tested your function and it didn't work. I set the dudes collision size to 300 and threw the grenade a short distance away. Didn't hurt him.

 

[PurplePoot]

IsUnitInRange works fine for collision - you must have done something wrong.

 

[Dreadnought[dA]]

I swear I set the units collision size to 200 and it didn't work. I set off the grenade nearby and it did no damage (and I know the grenade works). I just used the code I posted above and it works fine.

 

[PurplePoot]

And I swear you did it wrong. Test Blizzard on the various units - the IsUnitInRangeXY has exactly the same range (200) as Blizzard's AoE.

 

[Dreadnought[dA]]

Hmm, I don't know what I did wrong, but I'll try it again and thanks for showing me

EDIT: Alright I got it to work. Thanks for the help.