Unholy Spell Pack v1.1

[Moderator]

10:45, 15th Jun 2010
Hanky:
Your spells got some leaks and aren't even MUI/MPI. Next time please read the spell submission rules. Fix those things.

 

[-Berz-]

Spells are nice, but they need some work, starting with;
- tooltips, they are bad, they give you some general information but the grammar is just bad

- triggering, some spells aren't MUI( those that runs on periodic timer) Also you still have leaks:

Trigger

• Unholy Spirit Loop
  • Events
    • Time - Every 0.40 seconds of game time
  • Conditions
  • Actions
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (US_Dummy is dead) Equal to False
      • Then - Actions
        • Set US_Dummy_Point = (Position of US_Dummy)
        • Special Effect - Create a special effect at US_Dummy_Point using units\nightelf\SpiritOfVengeance\SpiritOfVengeance.mdl
        • Special Effect - Destroy (Last created special effect)
        • For each (Integer A) from 1 to 6, do (Actions)
          • Loop - Actions
            • Set US_LocationZ = (US_Dummy_Point offset by 15.00 towards (60.00 x (Real((Integer A)))) degrees)
            • Unit - Create 1 Dummy for (Owner of US_Caster) at US_LocationZ facing US_Dummy_Point
            • Unit - Add Unholy Spirit - Dummy to (Last created unit)
            • Unit - Set level of Unholy Spirit - Dummy for (Last created unit) to (Level of Unholy Spirit for US_Caster)
            • Unit - Order (Last created unit) to Neutral Pandaren Brewmaster - Breath Of Fire US_Dummy_Point
            • Unit - Add a 0.20 second Generic expiration timer to (Last created unit)
      • Else - Actions
    • Custom script: call RemoveLocation(udg_US_Dummy_Point)
    • Custom script: call RemoveLocation(udg_US_LocationZ)

Z location should be removed inside the loop, because you leak 5 locations every .40 second there

Trigger

• Unholy Wave Loop
  • Events
    • Time - Every 0.06 seconds of game time
  • Conditions
  • Actions
    • Set UW_Point3 = (Position of UW_Dummy)
    • Set UW_Unit_Group = (Units within (125.00 x (Real((Level of Unholy Wave for UW_Caster)))) of UW_Point3 matching ((((Matching unit) is alive) Equal to True) and (((Matching unit) belongs to an enemy of (Owner of UW_Caster)) Equal to True)))
    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
      • If - Conditions
        • (UW_Dummy is dead) Equal to False
      • Then - Actions
        • Destructible - Pick every destructible within 175.00 of UW_Point3 and do (Destructible - Kill (Picked destructible))
        • Unit - Move UW_Dummy instantly to (UW_Point3 offset by 47.00 towards UW_Angle degrees)
        • Unit - Add a 2.00 second Generic expiration timer to UW_Dummy
        • Special Effect - Create a special effect at UW_Point3 using Abilities\Spells\Undead\OrbOfDeath\AnnihilationMissile.mdl
        • Special Effect - Destroy (Last created special effect)
        • Unit Group - Pick every unit in UW_Unit_Group and do (Actions)
          • Loop - Actions
            • Special Effect - Create a special effect attached to the overhead of (Picked unit) using Abilities\Spells\Human\Feedback\ArcaneTowerAttack.mdl
            • Special Effect - Destroy (Last created special effect)
        • Unit - Create 1 Dummy for (Owner of UW_Caster) at UW_Point3 facing UW_Point3
        • Unit - Add Unholy Wave - Dummy to (Last created unit)
        • Unit - Set level of Unholy Wave - Dummy for (Last created unit) to (Level of Unholy Wave for UW_Caster)
        • Unit - Order (Last created unit) to Neutral Tinker - Cluster Rockets UW_Point3
        • Unit - Add a 0.40 second Generic expiration timer to (Last created unit)
      • Else - Actions
    • Custom script: call RemoveLocation(udg_UW_Point3)

Leaks unit group every .06 second

I'm not sure if there are any more leaks, I'm not checking the triggereing globally
-Replace your casting unit with triggering unit, it will boost your spell up
-

• Set UC_Text = (Last created floating text)

there is no need for this action, just use last created float
-I suggest you take a look after some tutorials about making your spells MUI (you can look at Hanky's template, Deuterium's indexing and overall triggering tutorial, hashtable tutorial)

As I said spells seems to appear nice ingame with nice special effect and nice spell effect, but you should improve your triggering.

Triggering	2/5
Eyecandy	4/5
Usefulness	3/5
Tooltip	1/5
Total	2.5/5

For now I would rate this 2.5/5 because you tried to make good spells (you tried to remove leaks, didn't use any waits and you "didn't" brake rules)

Have fun!

~Berz

 

[Bleed It Out]

LOL...sorry i didn't saw my leaks
My bad=(