[Trigger] Trigger leaks (lag)

[HaKKe_HaKKe_2]

Hey guys,

i don't really know how to explain the problem
i have written a trigger for a spell and he is working well, the only problem is
- if you use the spell about 10 or more times, it starts to lag

i have watched at the trigger over and over again and i simply can't find the problem, maybe someone can help me

i can't post you the trigger code here cause i got wc3 in german, so you won't understand very much
i will append my map to the post so you can look at it if you want to

Hero: Deadeye
Skill: Multishot

thx for any answers!

btw: sry 4 custom models, so the map is a little big atm


View attachment test.zip

 

[Child_0f_Bodom]

Your spells/triggers lagg because of Memory Leaks.

Check this tutorial to learn more about memory leaks and how to remove them.
http://www.hiveworkshop.com/forums/triggers-and-scripts-269/things-that-leak-35124/

 

[HaKKe_HaKKe_2]

hmm, i have already took a look at that

my problem is that i don't really know where to use the scrips

i already tried it for the unit group
call DestroyGroup(udg_MultishotDummys)
but it didn't realy help

do i really need a point variable for every position in my trigger to avoid such leaks?
are there any other things i have to take a look at?

sry 4 these nooby questions, but the tutorial goes about 43 pages and i think it would be a work of 30 sec to tell me whats missing

thanks in advance and sry 4 bad english

 

[Amigurumi]

you have many point leaks. and that every 0.01 seconds, that's quite....laggy
give me some minutes to fix those.

Edit: Made your trigger leakless. There were also some things that didn't work, I removed it for you.
!But make a copy of your own, because I'm not 100% shure, that the trigger work properly!

 

[HaKKe_HaKKe_2]

hmm the spell isn't working right now, but i will take a look what you have changed and fix it

seems like i should use a point variable every time i have to use a position
and the same for units / unit groups

the 0.01 sec trigger are laggy thats right, but i tought that when i turm them off after each cast it wont be a problem

thx for your help, will take your improvements in mind for my next triggers

i think there is no way around jass if you really want to make n1 abilitys and spells isn't it?

 

[Amigurumi]

GUI is limited, but you can make nice spells with it. JASS is detailed, and maybe easier, if you know how.