trigger help needed (do something ever 2 seconds hero is in region)

[Arth99]

Here is a silly thing ^_^

I cant seem to get a simple trigger to work...
Here is what I want to happen:

Hero enters region -> give owner of hero 10 gold every 2 seconds that the hero is in the region .

It sounds so simple and I feel ashamed to have such problems but I'm seriously confused.

 

[millzy]

• moneys
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Unit Group - Pick every unit in (Units in (your region) matching (((Matching unit) is A Hero) Equal to True)) and do (Actions)
      • Loop - Actions
        • Player - Add 100 to (Owner of (Picked unit)) Current gold

note that this leaks

 

[13oot-Me]

First of all, this is not the trigger section of the forum, this is for general map making questions. For trigger questions post in the triggers and scripts thread.

Second, I made a modification to millzy's trigger to remove the unit group leak.

• moneys
• Events
  • Time - Every 2.00 seconds of game time
• Conditions
• Actions
  • Set GroupVar = Pick every unit in (Units in (your region))
  • Unit Group - Pick every unit in GroupVar matching (((Matching unit) is A Hero) Equal to True)) and do (Actions)
    • Loop - Actions
      • Player - Add 10 to (Owner of (Picked unit)) Current gold
  • Unit Group - Pick every unit in GroupVar and do (Unit - Hide (Picked unit))
  • Custom script: call DestroyGroup(udg_GroupVar)

For more information about leaks, check Things That Leak.

 

[Bannar]

^I don't get why you have used action 'Hide unit' - explain.
Also, why not cut that trigger using bj?

Edited millzy version.

• moneys
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (your region) matching (((Matching unit) is A Hero) Equal to True)) and do (Actions)
      • Loop - Actions
        • Player - Add 100 to (Owner of (Picked unit)) Current gold

 

[13oot-Me]

@Spinnaker, I did that because that's what it said to do in things that leak.

 

[millzy]

• moneys
  • Events
    • Time - Every 2.00 seconds of game time
  • Conditions
  • Actions
    • Custom script: set bj_wantDestroyGroup = true
    • Unit Group - Pick every unit in (Units in (your region) matching (((Matching unit) is A Hero) Equal to True)) and do (Actions)
      • Loop - Actions
        • Player - Add 100 to (Owner of (Picked unit)) Current gold

this is alot better u dont need the hide units either

@Spinnaker, I did that because that's what it said to do in things that leak.

i read the thread u posted its just giving u an example of when u would need to pick units u dont need to hide them

 

[13oot-Me]

Oh ok, that makes sense then. Shouldn't the bj_wantdestroygroup be placed at the bottom of the trigger though? How come it's at the top?

 

[Bannar]

You have to understant how function which creates group look like.
That bj should be placed above function, since it destroys the next creates group. 'The next' is important here, since if we place it at the bottom, group above won't count, thus leak won't be removed.