Trigger fails to work sometimes

[BloodDrunk]

This trigger seems to fail to work sometimes. Any suggestions?

• Shadow Blast End
  • Events
    • Time - ShadowBlast_Timer expires
  • Conditions
  • Actions
    • Trigger - Turn off Shadow Blast Loop <gen>
    • For each (Integer A) from 1 to 4, do (Actions)
      • Loop - Actions
        • Set ShadowBlast_DummyPosition[(Integer A)] = (Position of ShadowBlast_Dummy[(Integer A)])
        • Special Effect - Create a special effect at ShadowBlast_DummyPosition[(Integer A)] using Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl
        • Special Effect - Destroy (Last created special effect)
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within 400.00 of ShadowBlast_DummyPosition[(Integer A)]) and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • (Level of Shadow Blast for ShadowBlast_TrigUnit) Equal to 1
                • ((Picked unit) is A structure) Equal to False
                • ((Picked unit) belongs to an enemy of (Owner of ShadowBlast_TrigUnit)) Equal to True
                • ((Picked unit) is alive) Equal to True
                • ((Picked unit) is dead) Equal to False
              • Then - Actions
                • Unit - Cause ShadowBlast_TrigUnit to damage (Picked unit), dealing 150.00 damage of attack type Spells and damage type Normal
              • Else - Actions
                • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                  • If - Conditions
                    • (Level of Shadow Blast for ShadowBlast_TrigUnit) Equal to 2
                    • ((Picked unit) is A structure) Equal to False
                    • ((Picked unit) belongs to an enemy of (Owner of ShadowBlast_TrigUnit)) Equal to True
                    • ((Picked unit) is alive) Equal to True
                    • ((Picked unit) is dead) Equal to False
                  • Then - Actions
                    • Unit - Cause ShadowBlast_TrigUnit to damage (Picked unit), dealing 300.00 damage of attack type Spells and damage type Normal
                  • Else - Actions
                    • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                      • If - Conditions
                        • (Level of Shadow Blast for ShadowBlast_TrigUnit) Equal to 3
                        • ((Picked unit) is A structure) Equal to False
                        • ((Picked unit) belongs to an enemy of (Owner of ShadowBlast_TrigUnit)) Equal to True
                        • ((Picked unit) is alive) Equal to True
                        • ((Picked unit) is dead) Equal to False
                      • Then - Actions
                        • Unit - Cause ShadowBlast_TrigUnit to damage (Picked unit), dealing 600.00 damage of attack type Spells and damage type Normal
                      • Else - Actions
                        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                          • If - Conditions
                            • (Level of Shadow Blast for ShadowBlast_TrigUnit) Equal to 4
                            • ((Picked unit) is A structure) Equal to False
                            • ((Picked unit) belongs to an enemy of (Owner of ShadowBlast_TrigUnit)) Equal to True
                            • ((Picked unit) is alive) Equal to True
                            • ((Picked unit) is dead) Equal to False
                          • Then - Actions
                            • Unit - Cause ShadowBlast_TrigUnit to damage (Picked unit), dealing 1200.00 damage of attack type Spells and damage type Normal
                          • Else - Actions
                            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
                              • If - Conditions
                                • (Level of Shadow Blast for ShadowBlast_TrigUnit) Equal to 5
                                • ((Picked unit) is A structure) Equal to False
                                • ((Picked unit) belongs to an enemy of (Owner of ShadowBlast_TrigUnit)) Equal to True
                                • ((Picked unit) is alive) Equal to True
                                • ((Picked unit) is dead) Equal to False
                              • Then - Actions
                                • Unit - Cause ShadowBlast_TrigUnit to damage (Picked unit), dealing 2400.00 damage of attack type Spells and damage type Normal
                              • Else - Actions
        • Custom script: call RemoveLocation(udg_ShadowBlast_DummyPosition[GetForLoopIndexA()])

 

[Almia]

I hate how you code the ifs
You must learn to use arrays

 

[TKF]

That glitches because its GUI and to many conditions. Make a loop instead of building else chain. Since it doubles its easy just make 75x(2^loop a)

 

[ap0calypse]

I hate how you code the ifs
You must learn to use arrays

Sometimes, math would be an even better option. The damage dealt here is 150 * 2^{level - 1}. This can be simplified as 75 * 2^level.
But since powers kinda suck in WC3, go for arrays .

Also: don't use both "Is Alive equal to true" and "Is Dead equal to false". That's 2 times the same thing.
Always use "Is Dead equal to false" (unless you want him to be dead, then "If Dead equal to true" ).

What Radamantus means: (probably)

• Shadow Blast End
  • Events
    • Time - ShadowBlast_Timer expires
  • Conditions
  • Actions
    • Trigger - Turn off Shadow Blast Loop <gen>
    • For each (Integer A) from 1 to 4, do (Actions)
      • Loop - Actions
        • Set ShadowBlast_DummyPosition[(Integer A)] = (Position of ShadowBlast_Dummy[(Integer A)])
        • Special Effect - Create a special effect at ShadowBlast_DummyPosition[(Integer A)] using Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl
        • Special Effect - Destroy (Last created special effect)
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within 400.00 of ShadowBlast_DummyPosition[(Integer A)]) and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) is A structure) Equal to False
                • ((Picked unit) belongs to an enemy of (Owner of ShadowBlast_TrigUnit)) Equal to True
                • ((Picked unit) is dead) Equal to False
              • Then - Actions
                • Unit - Cause ShadowBlast_TrigUnit to damage (Picked unit), dealing ShadowBlast_Damage[Level of Shadow Blast for unit] damage of attack type Spells and damage type Normal
        • Custom script: call RemoveLocation(udg_ShadowBlast_DummyPosition[GetForLoopIndexA()])

 

[Almia]

^ Correct.Follow what Apocalypse posted and what i suggested.

 

[BloodDrunk]

yeah, I was using damage variables before, but since I have much variables for spells, I try not to use damage variables. But in this case I will use Damage variable.
Thanks to all

 

[BloodDrunk]

Sometimes, math would be an even better option. The damage dealt here is 150 * 2^{level - 1}. This can be simplified as 75 * 2^level.
But since powers kinda suck in WC3, go for arrays .

Also: don't use both "Is Alive equal to true" and "Is Dead equal to false". That's 2 times the same thing.
Always use "Is Dead equal to false" (unless you want him to be dead, then "If Dead equal to true" ).

What Radamantus means: (probably)

• Shadow Blast End
  • Events
    • Time - ShadowBlast_Timer expires
  • Conditions
  • Actions
    • Trigger - Turn off Shadow Blast Loop <gen>
    • For each (Integer A) from 1 to 4, do (Actions)
      • Loop - Actions
        • Set ShadowBlast_DummyPosition[(Integer A)] = (Position of ShadowBlast_Dummy[(Integer A)])
        • Special Effect - Create a special effect at ShadowBlast_DummyPosition[(Integer A)] using Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl
        • Special Effect - Destroy (Last created special effect)
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within 400.00 of ShadowBlast_DummyPosition[(Integer A)]) and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) is A structure) Equal to False
                • ((Picked unit) belongs to an enemy of (Owner of ShadowBlast_TrigUnit)) Equal to True
                • ((Picked unit) is dead) Equal to False
              • Then - Actions
                • Unit - Cause ShadowBlast_TrigUnit to damage (Picked unit), dealing ShadowBlast_Damage[Level of Shadow Blast for unit] damage of attack type Spells and damage type Normal
        • Custom script: call RemoveLocation(udg_ShadowBlast_DummyPosition[GetForLoopIndexA()])

I'm posting back because it again doesn't works for all 4 loops, only the first one...

• Shadow Blast End
  • Events
    • Time - ShadowBlast_Timer expires
  • Conditions
  • Actions
    • Trigger - Turn off Shadow Blast Loop <gen>
    • For each (Integer A) from 1 to 4, do (Actions)
      • Loop - Actions
        • Set ShadowBlast_DummyPosition[(Integer A)] = (Position of ShadowBlast_Dummy[(Integer A)])
        • Special Effect - Create a special effect at ShadowBlast_DummyPosition[(Integer A)] using Abilities\Spells\Undead\AnimateDead\AnimateDeadTarget.mdl
        • Special Effect - Destroy (Last created special effect)
        • Custom script: set bj_wantDestroyGroup = true
        • Unit Group - Pick every unit in (Units within 400.00 of ShadowBlast_DummyPosition[(Integer A)]) and do (Actions)
          • Loop - Actions
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • ((Picked unit) is A structure) Equal to False
                • ((Picked unit) belongs to an enemy of (Owner of ShadowBlast_TrigUnit)) Equal to True
                • ((Picked unit) is dead) Equal to False
              • Then - Actions
                • Unit - Cause ShadowBlast_TrigUnit to damage (Picked unit), dealing ShadowBlast_Damage[(Level of Shadow Blast for ShadowBlast_TrigUnit)] damage of attack type Spells and damage type Normal
              • Else - Actions
        • Custom script: call RemoveLocation(udg_ShadowBlast_DummyPosition[GetForLoopIndexA()])

 

[ap0calypse]

It should work for the entire loop.
The only flaws I can see are minor ("ShadowBlast_DummyPosition" shouldn't be an array and you can combine the conditions with the unit-group pick).
That said, I am absolutely convinced the trigger itself works fine, on the condition that all variables are set up properly.

Where do you set the "ShadowBlast_Damage"? And the "ShadowBlast_Dummy"?
Another problem might be the "Integer A" loop you use: it's safer to use a variable loop.

 

[BloodDrunk]

I Fexed it Finally, no more troubles